Repository navigation
fix(web): stop wide ordered list markers from clipping - #16523
Conversation
ChatMarkdown sized the ordered list marker gutter at (digits + 1)ch, which counted the period but not the marker suffix space. Fonts whose digits, period and space all share one advance (Courier New, NSimSun) needed (digits + 2)ch, so the first digit of every 2+ digit marker hung past the gutter and was clipped by the chat timeline's overflow. Proportional fonts hid the bug because their period and space are narrower than a digit. Model: GPT 6.1 Sol via T3 Code. Harness: Codex.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a small, self-contained markdown presentation fix that adds the missing gutter space for multi-digit ordered-list markers. Its effect is limited to list layout, with single-digit lists and unrelated application behavior unchanged. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ordered-list gutter allowance increases by one character width. The sizing comment now specifies the marker characters included in the calculation. ChangesOrdered-list gutter sizing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The gutter adjustment has no identified adverse layout effect in the reviewed context, so no actionable merge risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…raming (#28) * fix(server): forks no longer merge into their upstream repo's project group (pingdotgg#16353) Fixes pingdotgg#4880. Originally pingdotgg#14639 by @Project516. Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com> * fix(server): stop the startup project sync from delaying the app window (pingdotgg#14912) * fix(web): avoid blocking image preparation conversions (pingdotgg#13342) * fix(server): return partial workspace index on timeout (pingdotgg#11500) * fix(server): probe project favicon candidates concurrently (pingdotgg#12543) * fix(observability): a failing trace disk no longer stalls the server (pingdotgg#13758) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): status polling no longer locks the git index (pingdotgg#14718) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * perf(shared): scan PATH once per command before spawning, not on every spawn (pingdotgg#12600) * fix(server): main's startup auto-pull test compiles again (pingdotgg#16357) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): project favicons stop being rescanned every minute (pingdotgg#16206) Favicons in ProjectEnrichmentService now keep for 15 minutes. Repository identity keeps its 1-minute TTL, so remote changes still show within a minute. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Claude limits load again for users with large transcript histories (pingdotgg#16358) The Claude capabilities probe now asks for usage with skipBehaviors, so it no longer scans every local transcript and misses its 4 s deadline. Takes over pingdotgg#14456. Co-authored-by: Ashkaan <a@ashkaan.me> * Add esthor to the list of GitHub users * fix(server): caches and ids are written atomically (pingdotgg#16242) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): one-shot initializers no longer race (pingdotgg#16260) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): the PR cache sweep only removes real entry files (pingdotgg#16285) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore: keep one copy each of undici 8 and ws 8 (pingdotgg#16211) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(shared): DrainableWorker keeps running after a failed item (pingdotgg#16223) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): metrics count interrupted work on the monotonic clock (pingdotgg#16207) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(web): import connection storage as a namespace in its test (pingdotgg#16315) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(contracts): trimmed IDs round-trip (pingdotgg#16300) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): main's settings, keybindings and session tests compile again (pingdotgg#16363) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(lint): catch known tags with Effect.catchTags (pingdotgg#16361) * fix(observability): T3 Connect tracing stops at the relay boundary (pingdotgg#16314) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(relay): error and deadline responses carry CORS headers (pingdotgg#16253) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): bring back the live shimmer on work log rows (pingdotgg#16372) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor: Effect code gets UUIDs and SHA-256 from Effect's Crypto (pingdotgg#16377) * fix(relay): export traces through one tracer, one request span each (pingdotgg#16382) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Pi thread titles use linked PR context (pingdotgg#16210) * fix(desktop): retry transient bearer bootstrap and degrade on session fetch failure (pingdotgg#12919) * fix(server): avoid scanning completed history for pending secrets (pingdotgg#16409) * fix(orchestration-v2): let Stop recover stalled runs (pingdotgg#15442) * fix(release): resolve version-qualified catalog overrides (pingdotgg#16411) * fix(web): type in front of bold that starts a composer line (pingdotgg#13217) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * fix(desktop): prevent browser screenshot filename collisions (pingdotgg#14784) * fix(server): end clone options before the repository URL (pingdotgg#14781) * fix(web): queued messages no longer split the composer notice stack (pingdotgg#16400) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> * fix(server): reject invalid explicit Bitbucket repositories (pingdotgg#15876) * fix(desktop): use the crypto service for screenshot IDs (pingdotgg#16415) * fix(shared): find versioned JetBrains macOS app bundles (pingdotgg#16246) * fix(server): OpenCode 2 threads get T3 Code's MCP tools (pingdotgg#16142) * feat(preview): run the browser on the environment server (pingdotgg#15328) * fix: restore service references breaking ci (pingdotgg#16495) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mcp): mark declared tool failures as errors (pingdotgg#15617) * fix(release): unblock nightly browser tests and cli builds (pingdotgg#16515) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(mcp): preserve thread command rejection reasons (pingdotgg#15627) * chore(deps): upgrade @effect/tsgo to 0.46.1 (pingdotgg#16360) Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(orchestration-v2): show reported subagent models (pingdotgg#14108) Co-authored-by: Yash Singh <saiansh2525@gmail.com> * fix(web): Apple logo no longer dips below the device host label (pingdotgg#14825) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): show subagent effort and speed in hover cards (pingdotgg#13056) Co-authored-by: Julius Marminge <julius0216@outlook.com> * feat(web): reopen closed tabs across the app (pingdotgg#15207) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(web): stop wide ordered list markers from clipping (pingdotgg#16523) * fix(desktop): build AppImage with the static runtime toolset (fixes libfuse2 launch failure) (pingdotgg#7765) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(mobile): keep usage-limit notice opaque (pingdotgg#15602) * feat(server): GitHub API transport that uses gh only for the token (pingdotgg#16319) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): pull requests talk to GitHub's API instead of the gh CLI (pingdotgg#16320) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): source control, media and discovery use GitHub's API instead of gh (pingdotgg#16321) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat: choose the GitHub account per host, save a GitHub token, and fewer reads per PR action (pingdotgg#16322) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): Rebase stack moves each layer onto the rebased layer below it (pingdotgg#16551) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): diff panel keeps the chosen scope while a turn runs (pingdotgg#16571) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(desktop): honor the telemetry opt-out from the shell profile (pingdotgg#16563) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(marketing): disclose product usage data in the privacy policy (pingdotgg#16562) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): note anonymous usage data in onboarding and link the privacy policy (pingdotgg#16564) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * perf(web): diff panel no longer re-renders every file header each time a patch arrives (pingdotgg#16033) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): every T3 MCP tool declares who may call it (pingdotgg#16335) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server): outside agents sign in to the T3 MCP server with OAuth (pingdotgg#16336) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): copy an environment's MCP URL for outside agents (pingdotgg#16337) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(tsconfig): turn off the Schema-over-JSON diagnostic in test files (pingdotgg#16375) Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(review): CodeRabbit gates outside contributors' pull requests (pingdotgg#16332) * fix(desktop): include Linux package license and app metadata (pingdotgg#16597) * fix(server): one failing RPC handler no longer ends the client's other requests (pingdotgg#15515) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(contracts): a context record that cannot be encoded no longer fails the send (pingdotgg#16398) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): open pull request row actions on right-click (pingdotgg#16612) * fix(web): show attempted paths in file preview errors (pingdotgg#15628) * fix(vcs): passive sidebar rows stop retaining remote pollers (pingdotgg#15666) * feat(web): group keybindings settings by area with a page toolbar (pingdotgg#12822) * feat(web): stop T3-owned subagents from Lineage (pingdotgg#15211) * feat(web): add fast actions to linked pull requests (pingdotgg#16627) * feat(web): open right panel tab menu with Mod+T (pingdotgg#15686) Co-authored-by: Julius Marminge <julius0216@outlook.com> * fix(server): provider sessions clean up when their start is interrupted (pingdotgg#15571) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): show "No project" near the top of the new thread picker (pingdotgg#16628) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * refactor(server): instrument WS RPCs in group middleware (pingdotgg#15548) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * chore(deps): upgrade @pierre/diffs to 1.5.2 and @pierre/trees to beta.6 (pingdotgg#16644) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(relay): a host restarting onto a deleted tunnel gets a new one (pingdotgg#16649) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): recover a deleted tunnel when Cloudflare says "Tunnel not found" (pingdotgg#16648) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): iPhone Duo fold controls follow the phone's orientation (pingdotgg#16630) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): keep workspace options when expanding lineage (pingdotgg#16635) * fix(web): preserve bare anchor placeholders in markdown (pingdotgg#16637) * fix(pi): preserve provider identity in discovered models (pingdotgg#16661) Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> * fix(auth): preserve explicitly granted pairing scopes (pingdotgg#9785) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate environment administration permissions (pingdotgg#9786) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate source control write permissions (pingdotgg#9787) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate filesystem read and write permissions (pingdotgg#9788) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate browser preview control permissions (pingdotgg#9789) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): separate diagnostics and usage permissions (pingdotgg#9790) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(auth): allow passive terminal observation (pingdotgg#9791) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * fix(auth): keep old clients connected across scope changes (pingdotgg#10298) Co-authored-by: Claude Fable 5 <noreply@anthropic.com> * feat(server): hosted agents like ChatGPT can sign in to the T3 MCP server (pingdotgg#16718) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: connect Claude Code, Codex, ChatGPT and bots over MCP (pingdotgg#16741) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(web): thread details card gives titles room to read (pingdotgg#16746) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(mcp): agent HTML pages stop painting slab backgrounds (pingdotgg#16752) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix: composer picks up new project skills without a server restart (pingdotgg#16750) * feat(server): run a project action when a worktree thread settles (pingdotgg#16290) Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(web): old Claude threads compact on send instead of stacking notices (pingdotgg#16631) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): settled threads stop polling their pull requests (pingdotgg#16762) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): stop storing tool image bytes no client reads (pingdotgg#16652) * fix(server): status refresh no longer pegs CPU in repos with thousands of untracked files (pingdotgg#16771) Co-authored-by: Braulio Oliveira <brauliobo@gmail.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com> * perf(server): background branch lookups share one GitHub query per sweep (pingdotgg#16760) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): threads settle as soon as a client sees their PR merge (pingdotgg#16761) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * feat(server,web,mobile): agents see snooze state and link to threads (pingdotgg#16782) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(release): Forgejo build resolves version-qualified catalog overrides Upstream now pins overrides such as undici@^8 to the catalog; the packaging script looked up the whole selector and failed. Mirrors upstream pingdotgg#16411. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): HTML renders and PDFs load behind a proxy that forbids framing Clients frame asset documents from the environment's origin, which is often not their own. A reverse proxy that adds X-Frame-Options: SAMEORIGIN blanked every HTML render and PDF preview in that setup. Inline HTML and PDF asset responses now carry `frame-ancestors *`, which browsers honour in place of X-Frame-Options. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(server): desktop renderer may frame asset documents CSP's `*` matches only http(s) ancestors, so the desktop app's custom scheme origins are listed explicitly. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Theo Browne <me@t3.gg> Co-authored-by: Project516 <138796702+Project516@users.noreply.github.com> Co-authored-by: Igor Makowski <56691628+Mnigos@users.noreply.github.com> Co-authored-by: Bilal Bakr <62337003+Bil0000@users.noreply.github.com> Co-authored-by: Michel Liao <107891771+Michel-Liao@users.noreply.github.com> Co-authored-by: Ishaan Kothari <ishaanko.mail@gmail.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: ahalekelly <7078138+ahalekelly@users.noreply.github.com> Co-authored-by: SkiTee3000 <39069192+SkiTee3000@users.noreply.github.com> Co-authored-by: Ashkaan <a@ashkaan.me> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Erik Thorelli <ethorelli@gmail.com> Co-authored-by: James Villarrubia <8172873+jamesvillarrubia@users.noreply.github.com> Co-authored-by: Yash Singh <saiansh2525@gmail.com> Co-authored-by: Alex Southwell <saphid@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tristan Manchester <108270628+tristanmanchester@users.noreply.github.com> Co-authored-by: Arav Jain <aravhawk@gmail.com> Co-authored-by: Sypher760-gif <sayffadil@gmail.com> Co-authored-by: Nikita Koynov <43469098+nkoynov@users.noreply.github.com> Co-authored-by: maria <maria@kuuro.net> Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Jake Leventhal <jakeleventhal@me.com> Co-authored-by: Utkarsh Patil <73941998+UtkarshUsername@users.noreply.github.com> Co-authored-by: Lorenzo <150276837+Bombatomica64@users.noreply.github.com> Co-authored-by: Benedikt Rump <bjrump@gmail.com> Co-authored-by: Stevan Borus <steva.borus@gmail.com> Co-authored-by: Gabriel De Andrade <30420087+gabrielelpidio@users.noreply.github.com> Co-authored-by: spoukyii <61633921+spoukyii@users.noreply.github.com> Co-authored-by: Derek Trimm <275381468+derektrimm@users.noreply.github.com> Co-authored-by: Braulio Oliveira <brauliobo@gmail.com>
Problem
With some Interface fonts like Courier New or NSimSun, the first digit of every 2+ digit marker in a chat numbered list gets cut off. Single-digit markers render fine.
Steps: set Interface font to Courier New (or NSimSun), then send or read any chat message containing an ordered list of 10 or more items.
Change
orderedListGutterStylereserved(digits + 1)chfor the marker gutter, which covers the digits and the period but not the trailing space after the marker.chis the width of the font's0, and monospace fonts give every glyph that same width, so10.plus its space needs 4ch and only 3ch was reserved. The marker sits left of the text, so that extra character hangs past the gutter and the chat timeline clips it. Proportional fonts never showed it because their period and space are narrower than a digit.The gutter now reserves the period and the trailing space.
Web and desktop share the renderer in
apps/web/src/components/ChatMarkdown.tsx.Scope and approval
Very small, focused fix of an obvious rendering bug: one arithmetic constant in a private helper. It changes no contract, no provider, no command, and no reverse state, so no triaged issue or maintainer discussion is required.
Verification
Before:

After:

Manual, in the web client with the Interface font set to Courier New, on an ordered list of 25 items. Before, the leading digit of
10.through21.was clipped; after, all markers render in full and align.Model: GPT 6.1 Sol
Harness: Codex in T3 Code