Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare Release 1.27.0 #1513

Merged
merged 4 commits into from
Aug 30, 2017
Merged

Prepare Release 1.27.0 #1513

merged 4 commits into from
Aug 30, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Aug 30, 2017 •
edited
Loading

🎆 Highlights: Table scrollToRegion(region: IRegion) instance method, Table renderMode to toggle batched cell rendering, Table onCompleteRender prop, new Suggest component

📖 Latest docs: blueprintjs.com/docs

@blueprintjs/core 1.27.0

🐛 Bug fixes

@blueprintjs/datetime 1.22.0

🐛 Bug fixes

@blueprintjs/table 1.24.0

💎 New features

  • [Table] scrollToRegion instance method #1496 🌟 Table now offers a scrollToRegion(region: IRegion) instance method to programmatically scroll a desired row, column, or cell into view!
    • The target region will be positioned in the top/left corner of the viewport.
      • Or if the table is maximally scrolled, then having the target cell simply in view is enough.
    • The target region will account for any frozen rows and/or columns and adjust its position accordingly to stay visible.
    • The scrolling happens instantaneously for now; in the future, we hope to add an animated?: boolean option to animate the scroll (see: [Table] Add animated option to scrollToRegion instance method #1501).
  • [Table] Add renderMode prop #1503 🌟 Table now supports a renderMode?: RenderMode prop:
  • [Table] Add onCompleteRender prop #1505 🌟 Table now offers an onCompleteRender prop.
    • This callback is invoked on mount/update when all cells in view have finished rendering.
    • This is particularly useful when batched cell rendering is enabled.

🐛 Bug fixes

@blueprintjs/labs 0.8.0

💎 New features

  • [Labs] Suggest component #1499 🌟 New Suggest component!
    • Suggest behaves similarly to Select, except it renders a text input as the Popover target instead of arbitrary children.
      2017-08-30 10 04 51

@blueprint-bot
Copy link

Prepare Release 1.27.0

Preview: documentation | landing | table | github pages
Coverage: core | datetime

@tgreenwatts
Copy link
Contributor

tgreenwatts commented Aug 30, 2017 •
edited by cmslewis
Loading

minor thoughts imo, language looks good

Need to fill in the version numbers DONE
Tabs feels like a bugfix or enhancement to me, not new feature? Moved to "Bug fixes"
Should we add a note to Scroll to region that animations will follow? Added a bullet point about that
Nit: the 1201 reference for onComplete doesn't seem necessary Removed
"perfectly" - you're just asking for someone to prove you wrong Changed to "properly"

giladgray
giladgray reviewed Aug 30, 2017
View reviewed changes
packages/docs/package.json Outdated
@@ -7,7 +7,7 @@
"style": "dist/docs.css",
"unpkg": "dist/docs.bundle.js",
"dependencies": {
"@blueprintjs/core": "^1.25.1",
"@blueprintjs/core": "^1.27.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

Copy link
Contributor Author

@cmslewis cmslewis Aug 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giladgray What's the rule of thumb with package versions in site-landing, site-docs, and docs? (For both dependencies and the package itself.)

packages/site-landing/package.json Outdated
@@ -22,7 +22,7 @@
"watch": "onchange 'src/**' -- npm-run-all build:copy build:webpack"
},
"devDependencies": {
"@blueprintjs/core": "^1.25.1",
"@blueprintjs/core": "^1.27.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@cmslewis
Copy link
Contributor Author

@giladgray done

@blueprint-bot
Copy link

Revert @blueprintjs/core dependency versions in site-landing/ and docs/

Preview: documentation | table | github pages
Coverage: core | datetime

cathyxz and others added 2 commits August 30, 2017 11:15
@cathyxz @cmslewis
[DateTimePicker] Fix where changing TimePicker clears date (#1474)
a4fe31f 
* Fixes #1402 time picker change clears data picker

* Add unit test to verify passing the same prop twice does not change the selected date

* Change unit test name to be more accurate

* Delete extra whitespace and newlines

* Add unit test for rerendering with undefined value prop
@cmslewis
Incorporate datetime PR #1474
be2a65d
@cmslewis cmslewis requested a review from gscshoyru August 30, 2017 18:25
@cmslewis
Copy link
Contributor Author

@giladgray @tgreenwatts @gscshoyru I added @cathyxz's #1474 PR to this release. take a look at that and anything else. 👍

@blueprint-bot
Copy link

Incorporate datetime PR #1474

Preview: documentation | table | github pages
Coverage: core | datetime

@cmslewis
Copy link
Contributor Author

:shipit:

@cmslewis cmslewis merged commit 74619bd into master Aug 30, 2017
@cmslewis cmslewis deleted the release/1.27.0 branch August 30, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgreenwatts tgreenwatts tgreenwatts approved these changes

@giladgray giladgray giladgray approved these changes

@gscshoyru gscshoyru Awaiting requested review from gscshoyru

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cmslewis @blueprint-bot @tgreenwatts @giladgray @cathyxz