[Table] Show focus cell appropriately when enableFocus becomes true #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show focus cell appropriately when enableFocus becomes truePreview: documentation | table |
giladgray
reviewed
Aug 15, 2017
packages/table/src/table.tsx
Outdated
| } else { | ||
| // focus the top-left cell of the table | ||
| newFocusedCellCoordinates = { col: 0, row: 0, focusSelectionIndex: 0 }; | ||
| } |
There was a problem hiding this comment.
might be nice to pull this out to getInitialFocusCell helper that simply returns in each if instead of assigning to a let variable?
then it's just const newFocusedCellCoordinates = this.getInitialFocusCell(args);
There was a problem hiding this comment.
Sounds like it's time to introduce focusUtils.ts (per https://github.com/palantir/blueprint/pull/1496/files#r135396325). 😎
gscshoyru
approved these changes
Aug 28, 2017
Oops, delete .onlyPreview: documentation | table |
giladgray
previously requested changes
Aug 30, 2017
| @@ -0,0 +1,3 @@ | |||
|
|
|||
Add missing file headerPreview: documentation | table |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1443
Checklist
Changes proposed in this pull request:
TableenableFocusprop totruenow shows a focused cell right away.Reviewers should focus on:
Screenshot