Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core/Tabs2 regression] cannot set to large anymore when using component's API #1506

Closed
bbenezech opened this issue Aug 26, 2017 · 2 comments
Closed

[Core/Tabs2 regression] cannot set to large anymore when using component's API #1506

bbenezech opened this issue Aug 26, 2017 · 2 comments
Assignees
@cmslewis
Labels
Domain: API P1 Package: core Type: bug Type: enhancement

Comments

@bbenezech
Copy link
Contributor

This is a recent regression.
The CSS property.pt-large has been moved to .pt-tab-list level (instead of the top-level the component before).
Yet there is no (obvious or documented?) way to set it there when using the API (that generates the .pt-tab-list part).
I suggest adding a large property on the component (to mimic the vertical one).

Cheers and thanks for the excellent work!
@bbenezech bbenezech changed the title [Core/Tabs2] cannot set to large anymore when using component's API [Core/Tabs2 regression] cannot set to large anymore when using component's API Aug 26, 2017
@cmslewis cmslewis mentioned this issue Aug 28, 2017
Merged
2 tasks
@cmslewis
Copy link
Contributor

Oy, sorry about that @bbenezech. Looks like we were distracted enough by Table issues last week that we didn't do a thorough enough pass on #1476. Fixing in PR #1510.

@cmslewis
Copy link
Contributor

[P1 due to the regression]

@cmslewis cmslewis self-assigned this Aug 28, 2017
@cmslewis cmslewis mentioned this issue Aug 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmslewis cmslewis

Labels
Domain: API P1 Package: core Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbenezech @cmslewis