Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Fix selection off-by-1px alignment issues #1507

Merged
merged 2 commits into from
Aug 28, 2017
Merged

[Table] Fix selection off-by-1px alignment issues #1507

merged 2 commits into from
Aug 28, 2017

Conversation

cmslewis
Copy link
Contributor

@cmslewis cmslewis commented Aug 27, 2017 •
edited
Loading

Fixes #1481

Checklist

  • Include tests (for FULL_TABLE selection only, not FULL_ROWS or FULL_COLUMNS)

Changes proposed in this pull request:

  • 🐛 FIXED Table FULL_ROWS, FULL_COLUMNS, and FULL_TABLE selection overlays now align properly to cells on their bottom/right sides.

Reviewers should focus on:

  • Are the alignmentCorrection and alignmentCorrectionString variables overkill?

Screenshot

Before:
FULL_ROWS selection is 1px too narrow.
image

FULL_COLUMNS selection is 1px too short.
image

FULL_TABLE selection is 1px too short and 1px too narrow.
image

After:
All overlays align perfectly with the cell borders below.

image

image

image

@blueprint-bot
Copy link

Write test

Preview: documentation | table
Coverage: core | datetime

gscshoyru
gscshoyru approved these changes Aug 28, 2017
View reviewed changes
Copy link
Contributor

@gscshoyru gscshoyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. This explains much.

@cmslewis cmslewis merged commit fb029f2 into master Aug 28, 2017
@cmslewis cmslewis deleted the cl/table-fix-selection-alignment branch August 28, 2017 22:28
@cmslewis cmslewis mentioned this pull request Aug 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gscshoyru gscshoyru gscshoyru approved these changes

@giladgray giladgray Awaiting requested review from giladgray

@themadcreator themadcreator Awaiting requested review from themadcreator

@tgreenwatts tgreenwatts Awaiting requested review from tgreenwatts

Assignees
No one assigned
Labels
Domain: design P2 Package: table Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmslewis @blueprint-bot @gscshoyru