Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateTimePicker] Clears selected day when arrow keys used in TimePicker #1402

Closed
jkillian opened this issue Aug 1, 2017 · 0 comments
Closed

[DateTimePicker] Clears selected day when arrow keys used in TimePicker #1402

jkillian opened this issue Aug 1, 2017 · 0 comments
Labels
help wanted P3 Package: datetime Type: bug

Comments

@jkillian
Copy link
Contributor

jkillian commented Aug 1, 2017 •
edited
Loading

Bug report

  • datetime 1.19.0
  • Chrome 60, macOS

Steps to reproduce

  1. Select a day and time in a DateTimePicker in the docs
  2. Click inside a TimePicker input and use the arrows to change the time

Actual behavior

The selected day unselects itself

Expected behavior

The selected day stays selected

Demo

2017-08-01 11 32 20

Just noticed this bug and wanted to report it! It isn't affect me personally, so it's not urgent at all from my end.
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 20, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
f17ef5f
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 20, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
3635ee6
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 20, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
9fb51f4
@cathyxz cathyxz mentioned this issue Aug 20, 2017
Merged
2 tasks
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 20, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
586f857
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 20, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
4f0d544
cathyxz added a commit to cathyxz/blueprint that referenced this issue Aug 22, 2017
@cathyxz
Fixes palantir#1402 time picker change clears data picker
4e2f2e4
cmslewis pushed a commit that referenced this issue Aug 30, 2017
@cathyxz @cmslewis
[DateTimePicker] Fix where changing TimePicker clears date (#1474)
3eb4b27 
* Fixes #1402 time picker change clears data picker

* Add unit test to verify passing the same prop twice does not change the selected date

* Change unit test name to be more accurate

* Delete extra whitespace and newlines

* Add unit test for rerendering with undefined value prop
cmslewis pushed a commit that referenced this issue Aug 30, 2017
@cathyxz @cmslewis
[DateTimePicker] Fix where changing TimePicker clears date (#1474)
a4fe31f 
* Fixes #1402 time picker change clears data picker

* Add unit test to verify passing the same prop twice does not change the selected date

* Change unit test name to be more accurate

* Delete extra whitespace and newlines

* Add unit test for rerendering with undefined value prop
cmslewis added a commit that referenced this issue Aug 30, 2017
@cmslewis
Prepare Release 1.27.0 (#1513)
74619bd 
* Prepare Release 1.27.0

* Revert @blueprintjs/core dependency versions in site-landing/ and docs/

* [DateTimePicker] Fix where changing TimePicker clears date (#1474)

* Fixes #1402 time picker change clears data picker

* Add unit test to verify passing the same prop twice does not change the selected date

* Change unit test name to be more accurate

* Delete extra whitespace and newlines

* Add unit test for rerendering with undefined value prop

* Incorporate datetime PR #1474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted P3 Package: datetime Type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@llorca @adidahiya @jkillian