Create instance from existing boot disk by benjaminleonard · Pull Request #2076 · oxidecomputer/console

benjaminleonard · 2024-03-18T12:35:13Z

This exacerbates the confusion with #2075 – where it is unclear what happens to the selected value when a user switches tabs. That doesn't necessarily need to be a blocker for this, would prefer to think through a design solution first.

Also seeing a flash from the navigation blocker after submission. Unsure if that's something I introduced with this PR by accident.

Fix click from number input to tab bar not setting value
Text that explains which disks are usable

vercel · 2024-03-18T12:35:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
console	✅ Ready (Inspect)	Visit Preview	Apr 3, 2024 5:00am

benjaminleonard · 2024-03-18T12:40:09Z

Also running into an issue where the disk size input does not apply if you exit focus by clicking on the tab bar. Maybe the setValue on bootDiskSource interrupts the disk size input applying its own value. This is causing a failed E2E test.

david-crespo · 2024-03-18T12:41:59Z

Ugh, thought I fixed the flash for good. Will look at it.

charliepark · 2024-03-21T22:19:24Z

Also running into an issue where the disk size input does not apply if you exit focus by clicking on the tab bar. Maybe the setValue on bootDiskSource interrupts the disk size input applying its own value. This is causing a failed E2E test.

This appears to be fixed now

charliepark

This looks good; sorry for the delayed approval. Was running into issues that stemmed from me not restarting vite, but this is solid.

david-crespo · 2024-03-22T22:02:43Z

        // default to the project images tab if there are only project images
        defaultValue={
-          projectImages.length > 0 && siloImages.length === 0 ? 'project' : 'silo'
+          siloImages.length > 0 ? 'silo' : projectImages.length > 0 ? 'project' : 'disk'


david-crespo · 2024-03-25T20:23:55Z


+const useBootDiskItems = (projectSelector: PP.Project) => {
+  const { data: disks } = useApiQuery('diskList', {
+    query: { ...projectSelector, limit: 1000 },


Tested this with 500 disks in the response and it doesn't seem to get bogged down at all. Obvious candidate for a combobox.

benjaminleonard · 2024-03-27T11:45:53Z

Great, copy changes look good to me

charliepark · 2024-03-27T20:15:25Z

I have a few fixes in #2097 that I'm close to merging here

#2097) * Fix issue with sourceType collision on project vs silo images and disks * refactor * Refactoring, and updating types * Maintain state of fields across tab navigation (#2100) * Simplify test; make it work for Safari * Clean up and add comments * verify in test that correct image used * clean up comment

david-crespo

Great work @benjaminleonard and @charliepark

Create instance from existing boot disk

cdc1c89

Remove setting undefined on tab change (for now)

630cb8a

vercel Bot deployed to Preview March 18, 2024 12:39 View deployment

benjaminleonard commented Mar 18, 2024

View reviewed changes

Comment thread app/forms/instance-create.tsx Outdated

Improve descriptions

dcc039d

benjaminleonard marked this pull request as ready for review March 22, 2024 12:27

vercel Bot deployed to Preview March 22, 2024 12:27 View deployment

charliepark approved these changes Mar 22, 2024

View reviewed changes

david-crespo reviewed Mar 22, 2024

View reviewed changes

david-crespo reviewed Mar 25, 2024

View reviewed changes

Comment thread app/forms/instance-create.tsx Outdated

david-crespo reviewed Mar 25, 2024

View reviewed changes

Comment thread app/forms/instance-create.tsx Outdated

copy tweaks

96ede78

vercel Bot deployed to Preview March 25, 2024 20:11 View deployment

david-crespo reviewed Mar 25, 2024

View reviewed changes

vercel Bot deployed to Preview March 25, 2024 22:41 View deployment

tweak empty states copy, fix diskList prefetch

6a9b374

david-crespo force-pushed the existing-boot-disk branch from fbd991f to 6a9b374 Compare March 25, 2024 22:48

vercel Bot deployed to Preview March 25, 2024 22:48 View deployment

Merge main into existing-boot-disk

da8fd69

vercel Bot deployed to Preview March 25, 2024 23:03 View deployment

Merge branch 'main' into existing-boot-disk

86453aa

vercel Bot deployed to Preview March 27, 2024 18:55 View deployment

david-crespo mentioned this pull request Mar 27, 2024

Fix issue with sourceType overload on project vs silo images and disks #2097

Merged

vercel Bot deployed to Preview March 27, 2024 23:00 View deployment

charliepark reviewed Mar 27, 2024

View reviewed changes

Comment thread app/forms/instance-create.tsx

Merge main into existing-boot-disk

00f859f

vercel Bot deployed to Preview April 2, 2024 22:37 View deployment

Merge branch 'main' into existing-boot-disk

09bc9ee

vercel Bot deployed to Preview April 2, 2024 23:11 View deployment

imageSize -> imageSizeGiB

530ff5c

vercel Bot deployed to Preview April 3, 2024 05:00 View deployment

david-crespo approved these changes Apr 3, 2024

View reviewed changes

david-crespo enabled auto-merge (squash) April 3, 2024 05:02

david-crespo disabled auto-merge April 3, 2024 16:09

david-crespo merged commit 2cfc8ee into main Apr 3, 2024

david-crespo deleted the existing-boot-disk branch April 3, 2024 16:09

david-crespo mentioned this pull request Apr 3, 2024

Bump web console (create instance with existing disk) oxidecomputer/omicron#5400

Merged

Navigation Menu

Repository navigation

Create instance from existing boot disk - #2076

Create instance from existing boot disk#2076
david-crespo merged 11 commits into
mainfrom
existing-boot-disk

benjaminleonard commented Mar 18, 2024 •

edited

Loading

Uh oh!

vercel Bot commented Mar 18, 2024 •

edited

Loading

Uh oh!

benjaminleonard commented Mar 18, 2024

Uh oh!

david-crespo commented Mar 18, 2024

Uh oh!

Uh oh!

charliepark commented Mar 21, 2024

Uh oh!

charliepark left a comment

Uh oh!

david-crespo Mar 22, 2024

Uh oh!

Uh oh!

Uh oh!

david-crespo Mar 25, 2024 •

edited

Loading

Uh oh!

benjaminleonard commented Mar 27, 2024

Uh oh!

charliepark commented Mar 27, 2024

Uh oh!

Uh oh!

david-crespo left a comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benjaminleonard commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benjaminleonard commented Mar 18, 2024

Uh oh!

david-crespo commented Mar 18, 2024

Uh oh!

Uh oh!

charliepark commented Mar 21, 2024

Uh oh!

charliepark left a comment

Choose a reason for hiding this comment

Uh oh!

david-crespo Mar 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

david-crespo Mar 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benjaminleonard commented Mar 27, 2024

Uh oh!

charliepark commented Mar 27, 2024

Uh oh!

Uh oh!

david-crespo left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benjaminleonard commented Mar 18, 2024 •

edited

Loading

vercel Bot commented Mar 18, 2024 •

edited

Loading

david-crespo Mar 25, 2024 •

edited

Loading