Repository navigation
Fix issue with sourceType overload on project vs silo images and disks - #2097
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charliepark
commented
Mar 26, 2024
charliepark
changed the title
charliepark
commented
Mar 26, 2024
Collaborator
|
This is looking really good. It fixes the bug. As we talked about in chat, I think it would be slightly better if your selection on each tab was preserved as you switch between tabs, so you could check what's on another tab without losing what you've done. This would require splitting |
charliepark
marked this pull request as ready for review
March 27, 2024 20:00
2 tasks done
david-crespo
approved these changes
Mar 27, 2024
david-crespo
left a comment
david-crespo
left a comment
Collaborator
There was a problem hiding this comment.
sweet. let’s do final review in #2076
david-crespo
added a commit
that referenced
this pull request
Apr 3, 2024
* Create instance from existing boot disk * Remove setting undefined on tab change (for now) * Improve descriptions * copy tweaks * tweak empty states copy, fix diskList prefetch * Fix issue with sourceType overload on project vs silo images and disks (#2097) * Fix issue with sourceType collision on project vs silo images and disks * refactor * Refactoring, and updating types * Maintain state of fields across tab navigation (#2100) * Simplify test; make it work for Safari * Clean up and add comments * verify in test that correct image used * clean up comment * imageSize -> imageSizeGiB --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com> Co-authored-by: Charlie Park <charlie@oxidecomputer.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal addresses an issue we're seeing in the instance create form.
Currently, because the create-instance form has a default image selected when the form is initialized, the form will use that image as the foundation for the instance, even if the user clicks to a different image source tab, if they don't select a new image. So they might select the "Project images" tab but end up creating an instance using the default Silo image. This is also a problem when the user selects the new "existing disk" tab.
This PR addresses the issue by setting up each of the tabs as their own piece of the form, and setting up a
bootDiskSourceTypethat keeps track of the desired boot disk source.This also allows us to maintain state across tab changes, so if the user has selected a source image and then clicks to a different tab, then clicks back, they don't lose their work.