Skip to content

Change all uses of RHF <Controller> to useController #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2024
Merged

Change all uses of RHF <Controller> to useController #2102

merged 1 commit into from
Mar 27, 2024

Conversation

david-crespo
Copy link
Collaborator

TIL <Controller> is just useController in a trenchcoat. Remove the trenchcoat. Render props are so 2016.

const Controller = <
  TFieldValues extends FieldValues = FieldValues,
  TName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>,
>(
  props: ControllerProps<TFieldValues, TName>,
) => props.render(useController<TFieldValues, TName>(props));

https://github.com/react-hook-form/react-hook-form/blob/306627e385738e322cad8dff9e752678f8210020/src/controller.tsx#L46-L51

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview Mar 27, 2024 7:07pm

charliepark
charliepark approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@charliepark charliepark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@david-crespo david-crespo merged commit e2a7bcd into main Mar 27, 2024
@david-crespo david-crespo deleted the use-controller branch March 27, 2024 20:07
david-crespo added a commit that referenced this pull request Mar 29, 2024
@david-crespo
Revert "Change all uses of RHF <Controller> to useController (#2102…
63d8156 
…)"

e2a7bcd

Will put back later today
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 29, 2024
@david-crespo
Bump web console (fix for quick draw mcgraws on ip pools list)
f580b2d 
oxidecomputer/console@c0dd895...156c082

* [156c082c](oxidecomputer/console@156c082c) oxidecomputer/console#2110
* [cfdb3aae](oxidecomputer/console@cfdb3aae) oxidecomputer/console#2106
* [63d8156f](oxidecomputer/console@63d8156f) Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)"
* [44c646f9](oxidecomputer/console@44c646f9) update API client gen script to use tsx directly
* [f5245ab4](oxidecomputer/console@f5245ab4) oxidecomputer/console#2104
* [e2a7bcd7](oxidecomputer/console@e2a7bcd7) oxidecomputer/console#2102
* [56a00488](oxidecomputer/console@56a00488) oxidecomputer/console#2101
@david-crespo david-crespo mentioned this pull request Mar 29, 2024
Merged
david-crespo added a commit that referenced this pull request Mar 29, 2024
@david-crespo
Revert "Revert "Change all uses of RHF <Controller> to `useControll…
9485ca2 
…er` (#2102)""

63d8156
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Mar 29, 2024
@david-crespo
Bump web console (fix for quick draw mcgraws on ip pools list) (#5350)
6e19854 
oxidecomputer/console@c0dd895...156c082

* [156c082c](oxidecomputer/console@156c082c)
oxidecomputer/console#2110
* [cfdb3aae](oxidecomputer/console@cfdb3aae)
oxidecomputer/console#2106
* [63d8156f](oxidecomputer/console@63d8156f)
Revert "Change all uses of RHF `<Controller>` to `useController`
(oxidecomputer/console#2102)"
* [44c646f9](oxidecomputer/console@44c646f9)
update API client gen script to use tsx directly
* [f5245ab4](oxidecomputer/console@f5245ab4)
oxidecomputer/console#2104
* [e2a7bcd7](oxidecomputer/console@e2a7bcd7)
oxidecomputer/console#2102
* [56a00488](oxidecomputer/console@56a00488)
oxidecomputer/console#2101
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Apr 3, 2024
@david-crespo
Bump web console
8c4fa5e 
oxidecomputer/console@156c082...b22ca1d

* [b22ca1dc](oxidecomputer/console@b22ca1dc) add loop comment to scp-assets
* [99173b92](oxidecomputer/console@99173b92) bump omicron script: automatically run gh run watch when assets aren't ready
* [2cfc8ee7](oxidecomputer/console@2cfc8ee7) oxidecomputer/console#2076
* [11411bb8](oxidecomputer/console@11411bb8) oxidecomputer/console#2121
* [1f8b25d7](oxidecomputer/console@1f8b25d7) oxidecomputer/console#2119
* [95f2e49e](oxidecomputer/console@95f2e49e) oxidecomputer/console#2108
* [8e3a2005](oxidecomputer/console@8e3a2005) oxidecomputer/console#2116
* [bf592a31](oxidecomputer/console@bf592a31) oxidecomputer/console#2105
* [b63c81ea](oxidecomputer/console@b63c81ea) oxidecomputer/console#2115
* [d5d70bd7](oxidecomputer/console@d5d70bd7) oxidecomputer/console#2113
* [1954709e](oxidecomputer/console@1954709e) oxidecomputer/console#2112
* [4db8d830](oxidecomputer/console@4db8d830) oxidecomputer/console#2111
* [9485ca23](oxidecomputer/console@9485ca23) Revert "Revert "Change all uses of RHF `<Controller>` to `useController` (oxidecomputer/console#2102)""
@david-crespo david-crespo mentioned this pull request Apr 3, 2024
Merged
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Apr 3, 2024
@david-crespo
Bump web console (create instance with existing disk) (#5400)
407143e 
oxidecomputer/console@156c082...b22ca1d

* [b22ca1dc](oxidecomputer/console@b22ca1dc)
add loop comment to scp-assets
* [99173b92](oxidecomputer/console@99173b92)
bump omicron script: automatically run gh run watch when assets aren't
ready
* [2cfc8ee7](oxidecomputer/console@2cfc8ee7)
oxidecomputer/console#2076
* [11411bb8](oxidecomputer/console@11411bb8)
oxidecomputer/console#2121
* [1f8b25d7](oxidecomputer/console@1f8b25d7)
oxidecomputer/console#2119
* [95f2e49e](oxidecomputer/console@95f2e49e)
oxidecomputer/console#2108
* [8e3a2005](oxidecomputer/console@8e3a2005)
oxidecomputer/console#2116
* [bf592a31](oxidecomputer/console@bf592a31)
oxidecomputer/console#2105
* [b63c81ea](oxidecomputer/console@b63c81ea)
oxidecomputer/console#2115
* [d5d70bd7](oxidecomputer/console@d5d70bd7)
oxidecomputer/console#2113
* [1954709e](oxidecomputer/console@1954709e)
oxidecomputer/console#2112
* [4db8d830](oxidecomputer/console@4db8d830)
oxidecomputer/console#2111
* [9485ca23](oxidecomputer/console@9485ca23)
Revert "Revert "Change all uses of RHF `<Controller>` to `useController`
(oxidecomputer/console#2102)""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliepark charliepark charliepark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-crespo @charliepark