Repository navigation
Maintain state of fields across tab navigation - #2100
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…election persistence
david-crespo
approved these changes
Mar 27, 2024
charliepark
marked this pull request as ready for review
March 27, 2024 18:48
david-crespo
pushed a commit
that referenced
this pull request
Mar 27, 2024
#2097) * Fix issue with sourceType collision on project vs silo images and disks * refactor * Refactoring, and updating types * Maintain state of fields across tab navigation (#2100) * Simplify test; make it work for Safari * Clean up and add comments * verify in test that correct image used * clean up comment
david-crespo
added a commit
that referenced
this pull request
Apr 3, 2024
* Create instance from existing boot disk * Remove setting undefined on tab change (for now) * Improve descriptions * copy tweaks * tweak empty states copy, fix diskList prefetch * Fix issue with sourceType overload on project vs silo images and disks (#2097) * Fix issue with sourceType collision on project vs silo images and disks * refactor * Refactoring, and updating types * Maintain state of fields across tab navigation (#2100) * Simplify test; make it work for Safari * Clean up and add comments * verify in test that correct image used * clean up comment * imageSize -> imageSizeGiB --------- Co-authored-by: David Crespo <david.crespo@oxidecomputer.com> Co-authored-by: Charlie Park <charlie@oxidecomputer.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to have the form retain the input values into the various tab's forms, I had to update a few fields in the form.
I'll want to take a look at this in the morning, as I suspect there are a few gnarly bits in it.
If this works as I believe it does, though, we'd merge it back into
fix-form-sourceType-bug, which is, itself, waiting to get merged toexisting-boot-disk. I was wary enough about the changes here that I didn't want to just Leeroy Jenkins it intofix-form-sourceType-bug.