fix(napi/parser): generate `.d.mts` extension for types #14038

danielroe · 2025-09-23T09:17:38Z

the latest version of oxc-parser (on npm) does not have resolvable types because the entry is .mjs and the types are .d.ts (these need to match - .d.mts). you can see this in the failing CI for this renovate PR but I'm happy to provide a more minimal reproduction if it helps

I also spotted that napi/parser/test/visit.test.ts was importing visitorKeys which was not exported from the corresponding declaration, so took the liberty to add that export as well.

let me know if this needs any changes 🙏

I hope it helps

graphite-app · 2025-09-23T09:17:47Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

Copilot

Pull Request Overview

This PR fixes TypeScript declaration file resolution issues for the oxc-parser npm package by updating file extensions from .d.ts to .d.mts to match the .mjs entry point.

Updated TypeScript declaration file extensions from .d.ts to .d.mts throughout the project
Added missing visitorKeys export to the type declarations
Modified build configuration to generate .d.mts files instead of .d.ts

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
napi/parser/src-js/index.d.mts	Updated import path and added missing visitorKeys export
napi/parser/src-js/header.d.mts	Updated import path to use .d.mts extension
napi/parser/package.json	Updated build script, file references, and header configuration to use .d.mts extensions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

overlookmotel · 2025-09-23T10:04:31Z

Thanks very much for spotting this and fixing. It needs a few amends to work around the oddities of NAPI-RS build and our infrastructure. I'm going to push a couple of commits - hope you don't mind.

Marking as draft for now.

danielroe · 2025-09-23T10:06:03Z

I don't mind at all! ❤️

thank you for spotting this so quickly. 🙏

overlookmotel · 2025-09-23T10:53:13Z

Well I broke it, so I should fix it!

Now that `apps/oxlint` and `napi/parser` are both ESM packages (#13723 and #14042), we can use `.js` file extensions for all ESM files, rather than the mix of `.js` and `.mjs` file we had previously. It's less confusing having to remember what's `.js` and what's `.mjs`, and avoids ugly workarounds like #14038 (`.d.mts`??).

## [1.17.0] - 2025-09-23 ### 🚀 Features - f47f978 linter/plugins: Add `definePlugin` API (#14008) (overlookmotel) - 3e117c6 linter/plugins: Add `defineRule` API (#13945) (overlookmotel) - 2dc8adb linter/plugins: Add `createOnce` API (#13944) (overlookmotel) - bef8753 linter/plugins: ESTree-compatible AST for JS plugins (#13942) (overlookmotel) - 55c2e11 editor: Add `oxc.fmt.experimental` flag (#13923) (Sysix) - a21ff54 language_server: Introduce `ServerFormatter` (#13700) (Sysix) - a14aa79 npm/oxlint: Convert to ES modules (#13876) (Boshen) - 15eb326 linter: Add `vue/no-required-prop-with-default` rule (#13613) (yefan) - 5d3ba00 linter: Add `vue/require-typed-ref` rule (#13857) (yefan) - b52389a node: Bump `engines` field to require Node.js 20.19.0+ for ESM support (#13879) (Copilot) - 8221a01 linter: Add `eslint/no-misleading-character-class` (#13365) (Sysix) - c75ae8c linter/plugins: Add options to `Context` (#13810) (overlookmotel) - 53d04dd linter: Convert `oxlint` to NAPI app (#13723) (overlookmotel) ### 🐛 Bug Fixes - 1f4be38 napi/parser: Generate `.d.mts` extension for types (#14038) (Daniel Roe) - a018756 linter/plugins: Pin `tsdown` dependency to 0.15.1 (#14005) (overlookmotel) - b8790c2 language_server: Output correct position for parser & semantic errors (#14010) (Sysix) - 4d3c6e1 linter: Support let-chains in codegen node type detection (#14006) (camc314) - a34918a linter/plugins: Avoid lint warnings compiling WASM or big-endian (#13968) (overlookmotel) - 27022ab linter/switch-case-braces: Add support for string including colon on case expression (#13687) (Lukinoh) - dd3843f linter: Set package version in `package.json` (#13890) (overlookmotel) - fa866b3 linter: Sort optimized/unoptimized diagnostics before comparison (#13850) (camc314) - fac7624 linter/plugins: Improve error for no JS plugins (#13858) (overlookmotel) ### 🚜 Refactor - bb040bc parser, linter: Replace `.mjs` files with `.js` (#14045) (overlookmotel) - b353750 linter/plugins: Remove unnecessary `Serialize` derives (#14031) (overlookmotel) - 0d48511 linter/plugins: Improve handling `Context` method calls in `createOnce` (#14032) (overlookmotel) - 36ac0fb language_server: Don't create `mpsc` channel (#14011) (Sysix) - 2e9ae3f linter: Make disable directives own the rule name (#13987) (camc314) - 6bc7664 oxlint: Run oxlint before tsgolint (#13519) (camc314) - 0c93f33 language_server: Use minimal text edit for `ServerFormatter` (#13960) (Sysix) - 823cb57 langauge_server: Move `Backend` into own file (#13955) (Sysix) - dc700f5 language_server: Introduce `LSPFileSystem` (#13731) (Sysix) - 42e2c1d linter: Remove `Rc` from `DisableDirectives` (#13924) (camc314) - ac3e9e9 napi/parser: Move JS code into `src-js` directory (#13899) (overlookmotel) - e90bfe3 linter: Remove double reference in unicorn/error-message (#13916) (camc314) - 83791a0 linter: Remove double reference in vue/jsx-no-undef (#13915) (camc314) - ebd22de linter: Remove double reference in vue/require-typed-ref (#13914) (camc314) - 873e231 language_server: Move `needs_linter_restart` to `ServerLinter` (#13834) (Sysix) - 7e0d736 linter/plugins: Rename `--experimental-js-plugins` to `--js-plugins` (#13860) (overlookmotel) - 6245c8c linter/plugins: Make `Context` properties getters (#13809) (overlookmotel) - a2342a6 linter/plugins: Import named in tests (#13807) (overlookmotel) ### 📚 Documentation - 601c876 linter: Add comment explaining why Mimalloc is feature-gated (#14037) (overlookmotel) ### ⚡ Performance - 4d04c6e linter/plugins: Flatten `LintFileResult` fields (#14033) (overlookmotel) - 06363e0 linter: Add node type codegen support for `match node.kind()` (#13736) (camchenry) - a79af0a linter: Replace `for (... of ...)` loops (#13913) (overlookmotel) - b53292d linter: Use unstable sort where possible (#13818) (sapphi-red) ### 🎨 Styling - 8083740 linter: Import `Serialize` at top level (#14030) (overlookmotel) ### 🧪 Testing - b807b6f language_server: Skip formatter test on windows (#13986) (Sysix) - 2600858 language_server: Add Tester for ServerFormatter (#13969) (Sysix) - 37aadf0 language_server: Add `test_and_snapshot_multiple_file` (#13966) (Sysix) - ad14a41 editor: Fix test setup (#13929) (Sysix) - f51240e linter/plugins: Tests for different import styles (#13859) (overlookmotel) - 407c95e linter/plugins: Check `this` is undefined in visit functions (#13811) (overlookmotel) - f023a22 linter/plugins: Include stack trace in plugin loading errors (#13808) (overlookmotel) ### 💼 Other - 0630d68 linter: Build `oxlint` locally with Mimalloc in release mode (#14034) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

fix(napi/parser): generate .d.mts extension for types

7707b64

Copilot AI review requested due to automatic review settings September 23, 2025 09:17

Copilot AI reviewed Sep 23, 2025

View reviewed changes

github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Sep 23, 2025

autofix-ci bot and others added 2 commits September 23, 2025 09:46

[autofix.ci] apply automated fixes

216b162

add visitorKeys to header.d.mts

e23bb2a

prevent dprint reformatting generated code

e0dcc07

overlookmotel marked this pull request as draft September 23, 2025 10:05

overlookmotel added 2 commits September 23, 2025 11:10

fix ast_tools codegen for renaming visitor.d.mts

640bc4d

fix oxlint

08835e9

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-ast-tools Area - AST tools labels Sep 23, 2025

Fix type errors in tests

d1915b5

overlookmotel marked this pull request as ready for review September 23, 2025 10:51

overlookmotel requested review from camc314 and overlookmotel as code owners September 23, 2025 10:51

overlookmotel merged commit 1f4be38 into oxc-project:main Sep 23, 2025
17 checks passed

overlookmotel mentioned this pull request Sep 23, 2025

refactor(parser, linter): replace .mjs files with .js #14045

Merged

Boshen mentioned this pull request Sep 23, 2025

release(oxlint): v1.17.0 #14054

Merged

Boshen mentioned this pull request Sep 24, 2025

release(crates): v0.92.0 #14067

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(napi/parser): generate `.d.mts` extension for types #14038

fix(napi/parser): generate `.d.mts` extension for types #14038

Uh oh!

danielroe commented Sep 23, 2025

Uh oh!

graphite-app bot commented Sep 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

overlookmotel commented Sep 23, 2025 •

edited

Loading

Uh oh!

danielroe commented Sep 23, 2025

Uh oh!

overlookmotel commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(napi/parser): generate .d.mts extension for types #14038

fix(napi/parser): generate .d.mts extension for types #14038

Uh oh!

Conversation

danielroe commented Sep 23, 2025

Uh oh!

graphite-app bot commented Sep 23, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

overlookmotel commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielroe commented Sep 23, 2025

Uh oh!

overlookmotel commented Sep 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(napi/parser): generate `.d.mts` extension for types #14038

fix(napi/parser): generate `.d.mts` extension for types #14038

overlookmotel commented Sep 23, 2025 •

edited

Loading