refactor(language_server): move `needs_linter_restart` to `ServerLinter` #13834

Sysix · 2025-09-16T19:09:26Z

The ServerLinter should know when a (full) restart is needed or not.
The same will come for ServerFormatter :)

Sysix · 2025-09-16T19:09:42Z

refactor(language_server): move needs_linter_restart to ServerLinter #13834 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR refactors the linting logic by moving the needs_linter_restart function from the WorkspaceWorker to the ServerLinter implementation. This improves code organization by placing restart logic closer to the linter implementation.

Moved needs_linter_restart function from WorkspaceWorker to ServerLinter as a static method
Updated call site to use the new location
Removed unnecessary import of LintOptions from worker module

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
crates/oxc_language_server/src/worker.rs	Removed `needs_linter_restart` function and unused import, updated call site
crates/oxc_language_server/src/linter/server_linter.rs	Added `needs_restart` static method to `ServerLinter`

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

codspeed-hq · 2025-09-16T19:18:33Z

CodSpeed Instrumentation Performance Report

Merging #13834 will not alter performance

_{Comparing 09-16-refactor_language_server_move_needs_linter_restart_to_serverlinter_ (873e231) with main (8221a01)¹}

Summary

✅ 37 untouched

No successful run was found on main (873e231) during the generation of this report, so 8221a01 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

camc314 · 2025-09-18T08:06:37Z

Merge activity

Sep 18, 8:06 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 18, 8:06 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 18, 8:19 AM UTC: Merged by the Graphite merge queue.

…er` (#13834) The `ServerLinter` should know when a (full) restart is needed or not. The same will come for `ServerFormatter` :)

## [1.17.0] - 2025-09-23 ### 🚀 Features - f47f978 linter/plugins: Add `definePlugin` API (#14008) (overlookmotel) - 3e117c6 linter/plugins: Add `defineRule` API (#13945) (overlookmotel) - 2dc8adb linter/plugins: Add `createOnce` API (#13944) (overlookmotel) - bef8753 linter/plugins: ESTree-compatible AST for JS plugins (#13942) (overlookmotel) - 55c2e11 editor: Add `oxc.fmt.experimental` flag (#13923) (Sysix) - a21ff54 language_server: Introduce `ServerFormatter` (#13700) (Sysix) - a14aa79 npm/oxlint: Convert to ES modules (#13876) (Boshen) - 15eb326 linter: Add `vue/no-required-prop-with-default` rule (#13613) (yefan) - 5d3ba00 linter: Add `vue/require-typed-ref` rule (#13857) (yefan) - b52389a node: Bump `engines` field to require Node.js 20.19.0+ for ESM support (#13879) (Copilot) - 8221a01 linter: Add `eslint/no-misleading-character-class` (#13365) (Sysix) - c75ae8c linter/plugins: Add options to `Context` (#13810) (overlookmotel) - 53d04dd linter: Convert `oxlint` to NAPI app (#13723) (overlookmotel) ### 🐛 Bug Fixes - 1f4be38 napi/parser: Generate `.d.mts` extension for types (#14038) (Daniel Roe) - a018756 linter/plugins: Pin `tsdown` dependency to 0.15.1 (#14005) (overlookmotel) - b8790c2 language_server: Output correct position for parser & semantic errors (#14010) (Sysix) - 4d3c6e1 linter: Support let-chains in codegen node type detection (#14006) (camc314) - a34918a linter/plugins: Avoid lint warnings compiling WASM or big-endian (#13968) (overlookmotel) - 27022ab linter/switch-case-braces: Add support for string including colon on case expression (#13687) (Lukinoh) - dd3843f linter: Set package version in `package.json` (#13890) (overlookmotel) - fa866b3 linter: Sort optimized/unoptimized diagnostics before comparison (#13850) (camc314) - fac7624 linter/plugins: Improve error for no JS plugins (#13858) (overlookmotel) ### 🚜 Refactor - bb040bc parser, linter: Replace `.mjs` files with `.js` (#14045) (overlookmotel) - b353750 linter/plugins: Remove unnecessary `Serialize` derives (#14031) (overlookmotel) - 0d48511 linter/plugins: Improve handling `Context` method calls in `createOnce` (#14032) (overlookmotel) - 36ac0fb language_server: Don't create `mpsc` channel (#14011) (Sysix) - 2e9ae3f linter: Make disable directives own the rule name (#13987) (camc314) - 6bc7664 oxlint: Run oxlint before tsgolint (#13519) (camc314) - 0c93f33 language_server: Use minimal text edit for `ServerFormatter` (#13960) (Sysix) - 823cb57 langauge_server: Move `Backend` into own file (#13955) (Sysix) - dc700f5 language_server: Introduce `LSPFileSystem` (#13731) (Sysix) - 42e2c1d linter: Remove `Rc` from `DisableDirectives` (#13924) (camc314) - ac3e9e9 napi/parser: Move JS code into `src-js` directory (#13899) (overlookmotel) - e90bfe3 linter: Remove double reference in unicorn/error-message (#13916) (camc314) - 83791a0 linter: Remove double reference in vue/jsx-no-undef (#13915) (camc314) - ebd22de linter: Remove double reference in vue/require-typed-ref (#13914) (camc314) - 873e231 language_server: Move `needs_linter_restart` to `ServerLinter` (#13834) (Sysix) - 7e0d736 linter/plugins: Rename `--experimental-js-plugins` to `--js-plugins` (#13860) (overlookmotel) - 6245c8c linter/plugins: Make `Context` properties getters (#13809) (overlookmotel) - a2342a6 linter/plugins: Import named in tests (#13807) (overlookmotel) ### 📚 Documentation - 601c876 linter: Add comment explaining why Mimalloc is feature-gated (#14037) (overlookmotel) ### ⚡ Performance - 4d04c6e linter/plugins: Flatten `LintFileResult` fields (#14033) (overlookmotel) - 06363e0 linter: Add node type codegen support for `match node.kind()` (#13736) (camchenry) - a79af0a linter: Replace `for (... of ...)` loops (#13913) (overlookmotel) - b53292d linter: Use unstable sort where possible (#13818) (sapphi-red) ### 🎨 Styling - 8083740 linter: Import `Serialize` at top level (#14030) (overlookmotel) ### 🧪 Testing - b807b6f language_server: Skip formatter test on windows (#13986) (Sysix) - 2600858 language_server: Add Tester for ServerFormatter (#13969) (Sysix) - 37aadf0 language_server: Add `test_and_snapshot_multiple_file` (#13966) (Sysix) - ad14a41 editor: Fix test setup (#13929) (Sysix) - f51240e linter/plugins: Tests for different import styles (#13859) (overlookmotel) - 407c95e linter/plugins: Check `this` is undefined in visit functions (#13811) (overlookmotel) - f023a22 linter/plugins: Include stack trace in plugin loading errors (#13808) (overlookmotel) ### 💼 Other - 0630d68 linter: Build `oxlint` locally with Mimalloc in release mode (#14034) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 16, 2025

Sysix marked this pull request as ready for review September 16, 2025 19:12

Sysix requested a review from camc314 as a code owner September 16, 2025 19:12

Copilot AI review requested due to automatic review settings September 16, 2025 19:12

Copilot AI reviewed Sep 16, 2025

View reviewed changes

camc314 approved these changes Sep 18, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025

refactor(language_server): move needs_linter_restart to `ServerLint…

873e231

…er` (#13834) The `ServerLinter` should know when a (full) restart is needed or not. The same will come for `ServerFormatter` :)

graphite-app bot force-pushed the 09-16-refactor_language_server_move_needs_linter_restart_to_serverlinter_ branch from 841061f to 873e231 Compare September 18, 2025 08:15

graphite-app bot merged commit 873e231 into main Sep 18, 2025
26 checks passed

graphite-app bot deleted the 09-16-refactor_language_server_move_needs_linter_restart_to_serverlinter_ branch September 18, 2025 08:19

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 18, 2025

This was referenced Sep 19, 2025

release(oxlint): v1.17.0 #13921

Closed

release(oxlint): v1.17.0 #14054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(language_server): move `needs_linter_restart` to `ServerLinter` #13834

refactor(language_server): move `needs_linter_restart` to `ServerLinter` #13834

Uh oh!

Sysix commented Sep 16, 2025 •

edited

Loading

Uh oh!

Sysix commented Sep 16, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

camc314 commented Sep 18, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(language_server): move needs_linter_restart to ServerLinter #13834

refactor(language_server): move needs_linter_restart to ServerLinter #13834

Uh oh!

Conversation

Sysix commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Sep 16, 2025

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

codspeed-hq bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #13834 will not alter performance

Summary

Footnotes

Uh oh!

camc314 commented Sep 18, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(language_server): move `needs_linter_restart` to `ServerLinter` #13834

refactor(language_server): move `needs_linter_restart` to `ServerLinter` #13834

Sysix commented Sep 16, 2025 •

edited

Loading

codspeed-hq bot commented Sep 16, 2025 •

edited

Loading

camc314 commented Sep 18, 2025 •

edited by graphite-app bot

Loading