refactor(linter/plugins): remove unnecessary `Serialize` derives #14031

overlookmotel · 2025-09-23T07:29:22Z

These types don't need to be serialized, only deserialized. So don't derive Serialize on them.

overlookmotel · 2025-09-23T07:29:42Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR removes unnecessary Serialize derives from types that only need to be deserialized. The refactoring simplifies the code by removing unused serialization capabilities from external linter plugin types.

Removed Serialize derive from PluginLoadResult and LintFileResult structs
Updated import statement to only include Deserialize from serde

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

overlookmotel · 2025-09-23T07:30:21Z

Merge activity

Sep 23, 7:30 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 23, 7:32 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
Sep 23, 7:38 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 23, 7:46 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14033.
Sep 23, 7:46 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #14033.
Sep 23, 8:07 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Sep 23, 8:12 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
Sep 23, 8:17 AM UTC: Merged by the Graphite merge queue.

codspeed-hq · 2025-09-23T07:38:18Z

CodSpeed Instrumentation Performance Report

Merging #14031 will not alter performance

_{Comparing 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives (b353750) with main (f4d6790)¹}

Summary

✅ 37 untouched

No successful run was found on main (b353750) during the generation of this report, so f4d6790 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

) These types don't need to be serialized, only deserialized. So don't derive `Serialize` on them.

## [1.17.0] - 2025-09-23 ### 🚀 Features - f47f978 linter/plugins: Add `definePlugin` API (#14008) (overlookmotel) - 3e117c6 linter/plugins: Add `defineRule` API (#13945) (overlookmotel) - 2dc8adb linter/plugins: Add `createOnce` API (#13944) (overlookmotel) - bef8753 linter/plugins: ESTree-compatible AST for JS plugins (#13942) (overlookmotel) - 55c2e11 editor: Add `oxc.fmt.experimental` flag (#13923) (Sysix) - a21ff54 language_server: Introduce `ServerFormatter` (#13700) (Sysix) - a14aa79 npm/oxlint: Convert to ES modules (#13876) (Boshen) - 15eb326 linter: Add `vue/no-required-prop-with-default` rule (#13613) (yefan) - 5d3ba00 linter: Add `vue/require-typed-ref` rule (#13857) (yefan) - b52389a node: Bump `engines` field to require Node.js 20.19.0+ for ESM support (#13879) (Copilot) - 8221a01 linter: Add `eslint/no-misleading-character-class` (#13365) (Sysix) - c75ae8c linter/plugins: Add options to `Context` (#13810) (overlookmotel) - 53d04dd linter: Convert `oxlint` to NAPI app (#13723) (overlookmotel) ### 🐛 Bug Fixes - 1f4be38 napi/parser: Generate `.d.mts` extension for types (#14038) (Daniel Roe) - a018756 linter/plugins: Pin `tsdown` dependency to 0.15.1 (#14005) (overlookmotel) - b8790c2 language_server: Output correct position for parser & semantic errors (#14010) (Sysix) - 4d3c6e1 linter: Support let-chains in codegen node type detection (#14006) (camc314) - a34918a linter/plugins: Avoid lint warnings compiling WASM or big-endian (#13968) (overlookmotel) - 27022ab linter/switch-case-braces: Add support for string including colon on case expression (#13687) (Lukinoh) - dd3843f linter: Set package version in `package.json` (#13890) (overlookmotel) - fa866b3 linter: Sort optimized/unoptimized diagnostics before comparison (#13850) (camc314) - fac7624 linter/plugins: Improve error for no JS plugins (#13858) (overlookmotel) ### 🚜 Refactor - bb040bc parser, linter: Replace `.mjs` files with `.js` (#14045) (overlookmotel) - b353750 linter/plugins: Remove unnecessary `Serialize` derives (#14031) (overlookmotel) - 0d48511 linter/plugins: Improve handling `Context` method calls in `createOnce` (#14032) (overlookmotel) - 36ac0fb language_server: Don't create `mpsc` channel (#14011) (Sysix) - 2e9ae3f linter: Make disable directives own the rule name (#13987) (camc314) - 6bc7664 oxlint: Run oxlint before tsgolint (#13519) (camc314) - 0c93f33 language_server: Use minimal text edit for `ServerFormatter` (#13960) (Sysix) - 823cb57 langauge_server: Move `Backend` into own file (#13955) (Sysix) - dc700f5 language_server: Introduce `LSPFileSystem` (#13731) (Sysix) - 42e2c1d linter: Remove `Rc` from `DisableDirectives` (#13924) (camc314) - ac3e9e9 napi/parser: Move JS code into `src-js` directory (#13899) (overlookmotel) - e90bfe3 linter: Remove double reference in unicorn/error-message (#13916) (camc314) - 83791a0 linter: Remove double reference in vue/jsx-no-undef (#13915) (camc314) - ebd22de linter: Remove double reference in vue/require-typed-ref (#13914) (camc314) - 873e231 language_server: Move `needs_linter_restart` to `ServerLinter` (#13834) (Sysix) - 7e0d736 linter/plugins: Rename `--experimental-js-plugins` to `--js-plugins` (#13860) (overlookmotel) - 6245c8c linter/plugins: Make `Context` properties getters (#13809) (overlookmotel) - a2342a6 linter/plugins: Import named in tests (#13807) (overlookmotel) ### 📚 Documentation - 601c876 linter: Add comment explaining why Mimalloc is feature-gated (#14037) (overlookmotel) ### ⚡ Performance - 4d04c6e linter/plugins: Flatten `LintFileResult` fields (#14033) (overlookmotel) - 06363e0 linter: Add node type codegen support for `match node.kind()` (#13736) (camchenry) - a79af0a linter: Replace `for (... of ...)` loops (#13913) (overlookmotel) - b53292d linter: Use unstable sort where possible (#13818) (sapphi-red) ### 🎨 Styling - 8083740 linter: Import `Serialize` at top level (#14030) (overlookmotel) ### 🧪 Testing - b807b6f language_server: Skip formatter test on windows (#13986) (Sysix) - 2600858 language_server: Add Tester for ServerFormatter (#13969) (Sysix) - 37aadf0 language_server: Add `test_and_snapshot_multiple_file` (#13966) (Sysix) - ad14a41 editor: Fix test setup (#13929) (Sysix) - f51240e linter/plugins: Tests for different import styles (#13859) (overlookmotel) - 407c95e linter/plugins: Check `this` is undefined in visit functions (#13811) (overlookmotel) - f023a22 linter/plugins: Include stack trace in plugin loading errors (#13808) (overlookmotel) ### 💼 Other - 0630d68 linter: Build `oxlint` locally with Mimalloc in release mode (#14034) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 23, 2025

overlookmotel marked this pull request as ready for review September 23, 2025 07:29

Copilot AI review requested due to automatic review settings September 23, 2025 07:30

overlookmotel requested a review from camc314 as a code owner September 23, 2025 07:30

Copilot AI reviewed Sep 23, 2025

View reviewed changes

overlookmotel self-assigned this Sep 23, 2025

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

overlookmotel changed the base branch from main to graphite-base/14031 September 23, 2025 07:31

overlookmotel force-pushed the 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives branch from 77c1531 to 56a5f82 Compare September 23, 2025 07:31

overlookmotel force-pushed the graphite-base/14031 branch from dec200d to f4d6790 Compare September 23, 2025 07:31

overlookmotel changed the base branch from graphite-base/14031 to 09-23-perf_linter_plugins_flatten_lintfileresult_fields September 23, 2025 07:31

github-actions bot added the A-cli Area - CLI label Sep 23, 2025

This was referenced Sep 23, 2025

refactor(linter/plugins): improve handling Context method calls in createOnce #14032

Merged

perf(linter/plugins): flatten LintFileResult fields #14033

Merged

graphite-app bot changed the base branch from 09-23-perf_linter_plugins_flatten_lintfileresult_fields to main September 23, 2025 07:32

overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

camc314 approved these changes Sep 23, 2025

View reviewed changes

overlookmotel changed the base branch from main to graphite-base/14031 September 23, 2025 07:39

overlookmotel force-pushed the 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives branch from 56a5f82 to 62b483f Compare September 23, 2025 07:39

overlookmotel changed the base branch from graphite-base/14031 to 09-23-perf_linter_plugins_flatten_lintfileresult_fields September 23, 2025 07:39

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

overlookmotel force-pushed the 09-23-perf_linter_plugins_flatten_lintfileresult_fields branch from dec200d to 2f7fa1b Compare September 23, 2025 08:06

overlookmotel force-pushed the 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives branch from 62b483f to 451fc7b Compare September 23, 2025 08:06

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

refactor(linter/plugins): remove unnecessary Serialize derives (#14031

b353750

) These types don't need to be serialized, only deserialized. So don't derive `Serialize` on them.

graphite-app bot force-pushed the 09-23-perf_linter_plugins_flatten_lintfileresult_fields branch from 2f7fa1b to 4d04c6e Compare September 23, 2025 08:11

graphite-app bot force-pushed the 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives branch from 451fc7b to b353750 Compare September 23, 2025 08:12

Base automatically changed from 09-23-perf_linter_plugins_flatten_lintfileresult_fields to main September 23, 2025 08:16

graphite-app bot merged commit b353750 into main Sep 23, 2025
26 checks passed

graphite-app bot deleted the 09-23-refactor_linter_plugins_remove_unnecessary_serialize_derives branch September 23, 2025 08:17

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 23, 2025

Boshen mentioned this pull request Sep 23, 2025

release(oxlint): v1.17.0 #14054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(linter/plugins): remove unnecessary `Serialize` derives #14031

refactor(linter/plugins): remove unnecessary `Serialize` derives #14031

overlookmotel commented Sep 23, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 23, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

overlookmotel commented Sep 23, 2025 •

edited by graphite-app bot

Loading

Uh oh!

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(linter/plugins): remove unnecessary Serialize derives #14031

refactor(linter/plugins): remove unnecessary Serialize derives #14031

Conversation

overlookmotel commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

overlookmotel commented Sep 23, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #14031 will not alter performance

Summary

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(linter/plugins): remove unnecessary `Serialize` derives #14031

refactor(linter/plugins): remove unnecessary `Serialize` derives #14031

overlookmotel commented Sep 23, 2025 •

edited

Loading

overlookmotel commented Sep 23, 2025 •

edited

Loading

overlookmotel commented Sep 23, 2025 •

edited by graphite-app bot

Loading

codspeed-hq bot commented Sep 23, 2025 •

edited

Loading