refactor(napi/parser): move JS code into `src-js` directory #13899

overlookmotel · 2025-09-18T16:31:46Z

Pure refactor. Root of napi/parser was getting really crowded with tons of files, and I'm about to add a load more for the ESTree walker.

Move JS source files into a src-js directory, like in apps/oxlint, so that the root of the package is just config files and scripts.

overlookmotel · 2025-09-18T16:32:05Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR refactors the napi/parser package by moving JavaScript source files into a src-js directory to reduce clutter in the package root, similar to the structure used in apps/oxlint.

Key changes:

Moved all JavaScript source files from the root directory to a new src-js subdirectory
Updated all import paths throughout the codebase to reference the new file locations
Modified build configuration and package.json to reflect the new directory structure

Reviewed Changes

Copilot reviewed 20 out of 34 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
napi/playground/playground.wasi-browser.js	Updated import path to reference parser files in src-js directory
napi/playground/patch.mjs	Updated import path in replacement string for parser files
napi/parser/test/*.ts	Updated import paths in test files to reference src-js directory
napi/parser/src-js/raw-transfer/*.mjs	Fixed relative import paths to correctly reference generated files
napi/parser/package.json	Updated main/browser entry points and build configuration for new structure
napi/parser/*.mjs	Updated import paths in example and build scripts
dprint.json	Updated exclusion patterns to handle new directory structure

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

graphite-app · 2025-09-19T08:44:16Z

Merge activity

Sep 19, 8:44 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 19, 8:44 AM UTC: camc314 removed this pull request from the Graphite merge queue.
Sep 19, 8:46 AM UTC: camc314 added this pull request to the Graphite merge queue.
Sep 19, 8:51 AM UTC: Merged by the Graphite merge queue.

Pure refactor. Root of `napi/parser` was getting really crowded with tons of files, and I'm about to add a load more for the ESTree walker. Move JS source files into a `src-js` directory, like in `apps/oxlint`, so that the root of the package is just config files and scripts.

Continuation of #13899. Move scripts from root of `napi/parser` package into a `scripts` directory.

Fix something I missed in #13899. `browser.js` is auto-generated by NAPI-RS, so needs to be in `src-js` dir with the rest.

#13899 made the `files` array in `package.json` for `napi/parser` package a short list of directories. Revert to an itemized list of all files to be included in NPM package. This is for compatibility with the release workflow which checks the list of files in `package.json` against file system. It fails when `files` list contains directories.

Fix (hopefully) the release workflow for NAPI packages, after it was broken by #13899.

## [1.17.0] - 2025-09-23 ### 🚀 Features - f47f978 linter/plugins: Add `definePlugin` API (#14008) (overlookmotel) - 3e117c6 linter/plugins: Add `defineRule` API (#13945) (overlookmotel) - 2dc8adb linter/plugins: Add `createOnce` API (#13944) (overlookmotel) - bef8753 linter/plugins: ESTree-compatible AST for JS plugins (#13942) (overlookmotel) - 55c2e11 editor: Add `oxc.fmt.experimental` flag (#13923) (Sysix) - a21ff54 language_server: Introduce `ServerFormatter` (#13700) (Sysix) - a14aa79 npm/oxlint: Convert to ES modules (#13876) (Boshen) - 15eb326 linter: Add `vue/no-required-prop-with-default` rule (#13613) (yefan) - 5d3ba00 linter: Add `vue/require-typed-ref` rule (#13857) (yefan) - b52389a node: Bump `engines` field to require Node.js 20.19.0+ for ESM support (#13879) (Copilot) - 8221a01 linter: Add `eslint/no-misleading-character-class` (#13365) (Sysix) - c75ae8c linter/plugins: Add options to `Context` (#13810) (overlookmotel) - 53d04dd linter: Convert `oxlint` to NAPI app (#13723) (overlookmotel) ### 🐛 Bug Fixes - 1f4be38 napi/parser: Generate `.d.mts` extension for types (#14038) (Daniel Roe) - a018756 linter/plugins: Pin `tsdown` dependency to 0.15.1 (#14005) (overlookmotel) - b8790c2 language_server: Output correct position for parser & semantic errors (#14010) (Sysix) - 4d3c6e1 linter: Support let-chains in codegen node type detection (#14006) (camc314) - a34918a linter/plugins: Avoid lint warnings compiling WASM or big-endian (#13968) (overlookmotel) - 27022ab linter/switch-case-braces: Add support for string including colon on case expression (#13687) (Lukinoh) - dd3843f linter: Set package version in `package.json` (#13890) (overlookmotel) - fa866b3 linter: Sort optimized/unoptimized diagnostics before comparison (#13850) (camc314) - fac7624 linter/plugins: Improve error for no JS plugins (#13858) (overlookmotel) ### 🚜 Refactor - bb040bc parser, linter: Replace `.mjs` files with `.js` (#14045) (overlookmotel) - b353750 linter/plugins: Remove unnecessary `Serialize` derives (#14031) (overlookmotel) - 0d48511 linter/plugins: Improve handling `Context` method calls in `createOnce` (#14032) (overlookmotel) - 36ac0fb language_server: Don't create `mpsc` channel (#14011) (Sysix) - 2e9ae3f linter: Make disable directives own the rule name (#13987) (camc314) - 6bc7664 oxlint: Run oxlint before tsgolint (#13519) (camc314) - 0c93f33 language_server: Use minimal text edit for `ServerFormatter` (#13960) (Sysix) - 823cb57 langauge_server: Move `Backend` into own file (#13955) (Sysix) - dc700f5 language_server: Introduce `LSPFileSystem` (#13731) (Sysix) - 42e2c1d linter: Remove `Rc` from `DisableDirectives` (#13924) (camc314) - ac3e9e9 napi/parser: Move JS code into `src-js` directory (#13899) (overlookmotel) - e90bfe3 linter: Remove double reference in unicorn/error-message (#13916) (camc314) - 83791a0 linter: Remove double reference in vue/jsx-no-undef (#13915) (camc314) - ebd22de linter: Remove double reference in vue/require-typed-ref (#13914) (camc314) - 873e231 language_server: Move `needs_linter_restart` to `ServerLinter` (#13834) (Sysix) - 7e0d736 linter/plugins: Rename `--experimental-js-plugins` to `--js-plugins` (#13860) (overlookmotel) - 6245c8c linter/plugins: Make `Context` properties getters (#13809) (overlookmotel) - a2342a6 linter/plugins: Import named in tests (#13807) (overlookmotel) ### 📚 Documentation - 601c876 linter: Add comment explaining why Mimalloc is feature-gated (#14037) (overlookmotel) ### ⚡ Performance - 4d04c6e linter/plugins: Flatten `LintFileResult` fields (#14033) (overlookmotel) - 06363e0 linter: Add node type codegen support for `match node.kind()` (#13736) (camchenry) - a79af0a linter: Replace `for (... of ...)` loops (#13913) (overlookmotel) - b53292d linter: Use unstable sort where possible (#13818) (sapphi-red) ### 🎨 Styling - 8083740 linter: Import `Serialize` at top level (#14030) (overlookmotel) ### 🧪 Testing - b807b6f language_server: Skip formatter test on windows (#13986) (Sysix) - 2600858 language_server: Add Tester for ServerFormatter (#13969) (Sysix) - 37aadf0 language_server: Add `test_and_snapshot_multiple_file` (#13966) (Sysix) - ad14a41 editor: Fix test setup (#13929) (Sysix) - f51240e linter/plugins: Tests for different import styles (#13859) (overlookmotel) - 407c95e linter/plugins: Check `this` is undefined in visit functions (#13811) (overlookmotel) - f023a22 linter/plugins: Include stack trace in plugin loading errors (#13808) (overlookmotel) ### 💼 Other - 0630d68 linter: Build `oxlint` locally with Mimalloc in release mode (#14034) (overlookmotel) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Sep 18, 2025

overlookmotel mentioned this pull request Sep 18, 2025

refactor(napi/parser): move scripts to scripts directory #13900

Merged

overlookmotel marked this pull request as ready for review September 18, 2025 16:35

Copilot AI review requested due to automatic review settings September 18, 2025 16:35

Copilot AI reviewed Sep 18, 2025

View reviewed changes

overlookmotel force-pushed the 09-18-refactor_napi_parser_move_js_code_into_src-js_directory branch 2 times, most recently from 7c59cd1 to d1cb6de Compare September 18, 2025 16:47

overlookmotel requested a review from camc314 as a code owner September 18, 2025 16:47

github-actions bot added A-linter Area - Linter A-cli Area - CLI A-ast-tools Area - AST tools labels Sep 18, 2025

overlookmotel mentioned this pull request Sep 18, 2025

refactor(napi/parser): remove outdated file #13901

Closed

camc314 approved these changes Sep 19, 2025

View reviewed changes

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025

graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Sep 19, 2025

graphite-app bot force-pushed the 09-18-refactor_napi_parser_move_js_code_into_src-js_directory branch from d1cb6de to ac3e9e9 Compare September 19, 2025 08:46

graphite-app bot pushed a commit that referenced this pull request Sep 19, 2025

refactor(napi/parser): move scripts to scripts directory (#13900)

329b7e7

Continuation of #13899. Move scripts from root of `napi/parser` package into a `scripts` directory.

graphite-app bot merged commit ac3e9e9 into main Sep 19, 2025
17 checks passed

graphite-app bot deleted the 09-18-refactor_napi_parser_move_js_code_into_src-js_directory branch September 19, 2025 08:51

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 19, 2025

overlookmotel mentioned this pull request Sep 19, 2025

fix(napi/parser): move browser.js file #13918

Merged

graphite-app bot pushed a commit that referenced this pull request Sep 19, 2025

fix(napi/parser): move browser.js file (#13918)

bd2fa90

Fix something I missed in #13899. `browser.js` is auto-generated by NAPI-RS, so needs to be in `src-js` dir with the rest.

This was referenced Sep 19, 2025

release(oxlint): v1.17.0 #13921

Closed

release(crates): v0.91.0 #13922

Closed

release(crates): v0.91.0 #13961

Merged

This was referenced Sep 21, 2025

refactor(napi/parser): itemize files in package.json #13978

Merged

ci(release): fix release workflow for NAPI packages #13979

Merged

graphite-app bot pushed a commit that referenced this pull request Sep 21, 2025

ci(release): fix release workflow for NAPI packages (#13979)

80c2d03

Fix (hopefully) the release workflow for NAPI packages, after it was broken by #13899.

This was referenced Sep 22, 2025

release(crates): v0.91.0 #13994

Closed

release(crates): v0.91.0 #14000

Merged

release(oxlint): v1.17.0 #14054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor(napi/parser): move JS code into `src-js` directory #13899

refactor(napi/parser): move JS code into `src-js` directory #13899

Uh oh!

overlookmotel commented Sep 18, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Sep 18, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

refactor(napi/parser): move JS code into src-js directory #13899

refactor(napi/parser): move JS code into src-js directory #13899

Uh oh!

Conversation

overlookmotel commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

graphite-app bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(napi/parser): move JS code into `src-js` directory #13899

refactor(napi/parser): move JS code into `src-js` directory #13899

overlookmotel commented Sep 18, 2025 •

edited

Loading

overlookmotel commented Sep 18, 2025 •

edited

Loading

graphite-app bot commented Sep 19, 2025 •

edited

Loading