feat(napi/parser)!: change oxc-parser to ESM
#14042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-parser
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request completes the transition of oxc-parser package to fully ESM by changing the package type from CommonJS to ESM. The only file extension change required is renaming the webcontainer fallback file to use the .cjs extension for proper CommonJS identification.
- Changed package.json type field from "commonjs" to "module"
- Renamed webcontainer-fallback.js to webcontainer-fallback.cjs to maintain CommonJS compatibility
- Updated file references to point to the renamed fallback file
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/parser/package.json | Changed type to "module" and updated files array to reference renamed fallback file |
| napi/parser/src-js/bindings.mjs | Updated require path to reference renamed webcontainer-fallback.cjs |
| napi/parser/scripts/patch.mjs | Updated string replacement pattern to reference renamed webcontainer-fallback.cjs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
overlookmotel
force-pushed
the
09-23-feat_napi_parser_change_oxc-parser_to_esm
branch
from
a8238ba to
894166f
Compare
This was referenced Sep 23, 2025
Member
Author
|
@camc314 Asking for your review, just because I know you're awake! |
camc314
approved these changes
Sep 23, 2025
Contributor
Merge activity
|
Completion of the work begun in #13432. Make `oxc-parser` package fully ESM. Aside from adding `"type": "module"` to `package.json`, only other change required is renaming `webcontainer-fallback.js` -> `webcontainer-fallback.cjs`. All other files already have the extension matching their ESM/CommonJS content.
graphite-app
bot
force-pushed
the
09-23-feat_napi_parser_change_oxc-parser_to_esm
branch
from
894166f to
b1da5d5
Compare
graphite-app
bot
deleted the
09-23-feat_napi_parser_change_oxc-parser_to_esm
branch
graphite-app bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
Now that `apps/oxlint` and `napi/parser` are both ESM packages (#13723 and #14042), we can use `.js` file extensions for all ESM files, rather than the mix of `.js` and `.mjs` file we had previously. It's less confusing having to remember what's `.js` and what's `.mjs`, and avoids ugly workarounds like #14038 (`.d.mts`??).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion of the work begun in #13432. Make
oxc-parserpackage fully ESM.Aside from adding
"type": "module"topackage.json, only other change required is renamingwebcontainer-fallback.js->webcontainer-fallback.cjs. All other files already have the extension matching their ESM/CommonJS content.