test(linter/no-undef): add test case for `TSImportType` #12800

camc314 · 2025-08-04T09:58:37Z

camc314 · 2025-08-04T09:58:51Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-08-04T10:04:36Z

CodSpeed Instrumentation Performance Report

Merging #12800 will not alter performance

_{Comparing c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ (3957fcc) with main (cacbd1e)¹}

Summary

✅ 34 untouched benchmarks

No successful run was found on main (47e2c59) during the generation of this report, so cacbd1e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sysix

closes #12693?

Sysix · 2025-08-04T16:57:09Z

Merge activity

Aug 4, 4:57 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Aug 4, 4:57 PM UTC: Sysix added this pull request to the Graphite merge queue.
Aug 4, 5:01 PM UTC: Sysix removed this pull request from the Graphite merge queue.
Aug 5, 5:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Aug 5, 5:55 AM UTC: Boshen added this pull request to the Graphite merge queue.
Aug 5, 6:03 AM UTC: Merged by the Graphite merge queue.

closes #12693

## [1.10.0] - 2025-08-06 ### 🚀 Features - 44ac5a1 linter: Add eslint/no-unassigned-vars rule (#11365) (yefan) - ce6eeee linter: Add `eslint/prefer-destructuring` rule (#12721) (yefan) - 9b35600 linter/jsx-a11y: Add support for mapped attributes in label association checks (#12805) (camc314) - 5475075 vscode/language_server: Add `tsConfigPath` option (#12484) (Sysix) - a754f7a linter: Support `countVoidThis` option in `max-params` rule (#12604) (yefan) ### 🐛 Bug Fixes - 2c1dab6 linter/no-unassigned-vars: False positive with variables in for loop (#12833) (camc314) - 5a24574 linter/func-style: Fix more false positives (#12828) (camc314) - 33a7320 linter/no-throw-literal: Fix unconditional recursion in `could_be_error` (#12819) (camc314) - a3aec6a linter/explicit-module-boundary-types: Debug assertion fail with top level return (#12820) (camc314) - 6efe457 linter/no-empty-function: Respect allow options for functions and arrow functions (#12814) (camc314) - 1c21c46 linter/new-cap: Fix panic with computed member expr (#12804) (camc314) - 45206dd linter: Apply fix span offset after fixing the section source text (#12758) (Sysix) - 1e97e35 linter/unicorn/prefer-structured-clone: Update Default implementation for `PreferStructuredCloneConfig` (#12791) (camc314) - d382159 linter/unicorn/prefer-object-from-entries: Update Default implementation for `PreferObjectFromEntriesConfig` (#12790) (camc314) - b07d29c linter/typescript/no-this-alias: Update Default implementation for `NoThisAliasConfig` (#12789) (camc314) - 0db34ab linter/react/jsx-filename-case: Update Default implementation for `JsxFilenameExtensionConfig` (#12788) (camc314) - ff84eff linter/jest/prefer-lowercase-title: Update Default implementation for `PreferLowercaseTitleConfig` (#12787) (camc314) - 5175c6d linter/jest/no-large-snapshots: Update Default implementation for `NoLargeSnapshotsConfig` (#12786) (camc314) - 0eaebcd linter/jest/no-deprecated-functions: Update Default implementation for `JestConfig` (#12785) (camc314) - 4265db7 linter/import/no-anonymous-default-export: Update Default implementation for `NoAnonymousDefaultExport` config (#12784) (camc314) - 6a360e3 linter/import/extensions: Update Default implementation for ExtensionsConfig (#12783) (camc314) - 42c8f29 linter: Default options for `eslint/no-else-return` (#12762) (Sysix) - 4eac511 linter: Default options for `eslint/no-unneeded-ternary` (#12761) (Sysix) - 9c01dbf linter: Default options for `eslint/new-cap` (#12760) (Sysix) - b25406f linter/explicit-function-return-types: Update default values in ExplicitFunctionReturnTypeConfig (#12718) (camc314) - ce5876d parser: Validate inner expression of type assertions in assignment targets (#12614) (camc314) - 5383331 linter/explicit-mod-boundary-types: False positive with jsx elements (#12678) (camc314) - d0e99b5 linter/explicit-mod-boundary-types: False positive with call expressions (#12677) (camc314) - 525137e linter: Add missing options to no-inner-declarations (#12661) (camc314) - fc4a327 linter: No-unused-vars false positive with class property initializers (#12660) (camc314) - 6af8631 linter/no-unused-vars: False positive with chain expression (#12609) (camc314) - 744ef52 linter: Correct `array-type` handling of `default: 'array-simple'` (#12607) (yefan) ### 🚜 Refactor - 3f37ed1 linter: Replace `lazy_static` with `std::sync::LazyLock` (#12822) (Copilot) - 69fd08d semantic: Improve unused label tracking and add debug assertions (#12812) (camc314) - 030e397 linter: Simplify parsing CLI args (#12802) (overlookmotel) - c0e224a linter: Store `ExternalRuleId` in `OxlintOverrides` not raw names (#12502) (camc314) - 61587e4 linter: Correct comment (#12792) (overlookmotel) - 5adcb98 linter: Use `u32` to keep track of last fixed source text position (#12696) (Sysix) - 77acc11 linter, transformer: Use `Scoping::symbol_is_unused` (#12666) (overlookmotel) - ecf1cff language_server: Simplify offset adjustment by using `Message.move_offset` (#12647) (Sysix) - 7695393 linter: Simplify offset adjustment by using `Message.move_offset` (#12595) (Sysix) - b36dc92 linter: Refactor large arrays to reduce binary size (#12603) (Boshen) - 3b9f1f0 linter: Update iter_outer_expressions to take AstNodes reference (#12583) (camc314) ### 📚 Documentation - e760fd4 linter: Complete linter rules documentation with missing "Why is this bad?" sections (#12757) (Copilot) - 514322c rust: Add minimal documentation to example files in crates directory (#12731) (Copilot) - 1d910d5 linter: Fix typescript/consistent-type-imports rule options to match TypeScript ESLint (#12707) (Copilot) - 45e2fe8 rust: Fix typos and grammar mistakes in Rust documentation comments (#12715) (Copilot) - 7660a88 linter: Improve linter rule documentation with "Why is this bad?" sections and enhanced examples (#12711) (Copilot) - de1de35 rust: Add comprehensive README.md documentation for all Rust crates (#12706) (Copilot) ### ⚡ Performance - 09ae2a9 linter: Eliminate unnecessary Iterator::collect() allocations (#12776) (Copilot) - 693673b linter: Reduce iterations when collecting directories for nested configs (#12329) (overlookmotel) ### 🎨 Styling - cacbd1e linter/no-empty-function: Order match arms consistently (#12815) (camc314) - c15da81 codegen, formatter, linter, minifier, transformer: Re-order imports (#12725) (Copilot) ### 🧪 Testing - 3957fcc linter/no-undef: Add test case for `TSImportType` (#12800) (camc314) - d8ccff7 oxlint: Add `Tester::test_fix` mehod (#12754) (Sysix) - c6bfb8a linter: Add rule configuration consistency test (#12744) (camc314) - 2ceb835 linter: Fix offset for partical source texts (#12594) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

…12800) closes oxc-project#12693

## [1.10.0] - 2025-08-06 ### 🚀 Features - 44ac5a1 linter: Add eslint/no-unassigned-vars rule (oxc-project#11365) (yefan) - ce6eeee linter: Add `eslint/prefer-destructuring` rule (oxc-project#12721) (yefan) - 9b35600 linter/jsx-a11y: Add support for mapped attributes in label association checks (oxc-project#12805) (camc314) - 5475075 vscode/language_server: Add `tsConfigPath` option (oxc-project#12484) (Sysix) - a754f7a linter: Support `countVoidThis` option in `max-params` rule (oxc-project#12604) (yefan) ### 🐛 Bug Fixes - 2c1dab6 linter/no-unassigned-vars: False positive with variables in for loop (oxc-project#12833) (camc314) - 5a24574 linter/func-style: Fix more false positives (oxc-project#12828) (camc314) - 33a7320 linter/no-throw-literal: Fix unconditional recursion in `could_be_error` (oxc-project#12819) (camc314) - a3aec6a linter/explicit-module-boundary-types: Debug assertion fail with top level return (oxc-project#12820) (camc314) - 6efe457 linter/no-empty-function: Respect allow options for functions and arrow functions (oxc-project#12814) (camc314) - 1c21c46 linter/new-cap: Fix panic with computed member expr (oxc-project#12804) (camc314) - 45206dd linter: Apply fix span offset after fixing the section source text (oxc-project#12758) (Sysix) - 1e97e35 linter/unicorn/prefer-structured-clone: Update Default implementation for `PreferStructuredCloneConfig` (oxc-project#12791) (camc314) - d382159 linter/unicorn/prefer-object-from-entries: Update Default implementation for `PreferObjectFromEntriesConfig` (oxc-project#12790) (camc314) - b07d29c linter/typescript/no-this-alias: Update Default implementation for `NoThisAliasConfig` (oxc-project#12789) (camc314) - 0db34ab linter/react/jsx-filename-case: Update Default implementation for `JsxFilenameExtensionConfig` (oxc-project#12788) (camc314) - ff84eff linter/jest/prefer-lowercase-title: Update Default implementation for `PreferLowercaseTitleConfig` (oxc-project#12787) (camc314) - 5175c6d linter/jest/no-large-snapshots: Update Default implementation for `NoLargeSnapshotsConfig` (oxc-project#12786) (camc314) - 0eaebcd linter/jest/no-deprecated-functions: Update Default implementation for `JestConfig` (oxc-project#12785) (camc314) - 4265db7 linter/import/no-anonymous-default-export: Update Default implementation for `NoAnonymousDefaultExport` config (oxc-project#12784) (camc314) - 6a360e3 linter/import/extensions: Update Default implementation for ExtensionsConfig (oxc-project#12783) (camc314) - 42c8f29 linter: Default options for `eslint/no-else-return` (oxc-project#12762) (Sysix) - 4eac511 linter: Default options for `eslint/no-unneeded-ternary` (oxc-project#12761) (Sysix) - 9c01dbf linter: Default options for `eslint/new-cap` (oxc-project#12760) (Sysix) - b25406f linter/explicit-function-return-types: Update default values in ExplicitFunctionReturnTypeConfig (oxc-project#12718) (camc314) - ce5876d parser: Validate inner expression of type assertions in assignment targets (oxc-project#12614) (camc314) - 5383331 linter/explicit-mod-boundary-types: False positive with jsx elements (oxc-project#12678) (camc314) - d0e99b5 linter/explicit-mod-boundary-types: False positive with call expressions (oxc-project#12677) (camc314) - 525137e linter: Add missing options to no-inner-declarations (oxc-project#12661) (camc314) - fc4a327 linter: No-unused-vars false positive with class property initializers (oxc-project#12660) (camc314) - 6af8631 linter/no-unused-vars: False positive with chain expression (oxc-project#12609) (camc314) - 744ef52 linter: Correct `array-type` handling of `default: 'array-simple'` (oxc-project#12607) (yefan) ### 🚜 Refactor - 3f37ed1 linter: Replace `lazy_static` with `std::sync::LazyLock` (oxc-project#12822) (Copilot) - 69fd08d semantic: Improve unused label tracking and add debug assertions (oxc-project#12812) (camc314) - 030e397 linter: Simplify parsing CLI args (oxc-project#12802) (overlookmotel) - c0e224a linter: Store `ExternalRuleId` in `OxlintOverrides` not raw names (oxc-project#12502) (camc314) - 61587e4 linter: Correct comment (oxc-project#12792) (overlookmotel) - 5adcb98 linter: Use `u32` to keep track of last fixed source text position (oxc-project#12696) (Sysix) - 77acc11 linter, transformer: Use `Scoping::symbol_is_unused` (oxc-project#12666) (overlookmotel) - ecf1cff language_server: Simplify offset adjustment by using `Message.move_offset` (oxc-project#12647) (Sysix) - 7695393 linter: Simplify offset adjustment by using `Message.move_offset` (oxc-project#12595) (Sysix) - b36dc92 linter: Refactor large arrays to reduce binary size (oxc-project#12603) (Boshen) - 3b9f1f0 linter: Update iter_outer_expressions to take AstNodes reference (oxc-project#12583) (camc314) ### 📚 Documentation - e760fd4 linter: Complete linter rules documentation with missing "Why is this bad?" sections (oxc-project#12757) (Copilot) - 514322c rust: Add minimal documentation to example files in crates directory (oxc-project#12731) (Copilot) - 1d910d5 linter: Fix typescript/consistent-type-imports rule options to match TypeScript ESLint (oxc-project#12707) (Copilot) - 45e2fe8 rust: Fix typos and grammar mistakes in Rust documentation comments (oxc-project#12715) (Copilot) - 7660a88 linter: Improve linter rule documentation with "Why is this bad?" sections and enhanced examples (oxc-project#12711) (Copilot) - de1de35 rust: Add comprehensive README.md documentation for all Rust crates (oxc-project#12706) (Copilot) ### ⚡ Performance - 09ae2a9 linter: Eliminate unnecessary Iterator::collect() allocations (oxc-project#12776) (Copilot) - 693673b linter: Reduce iterations when collecting directories for nested configs (oxc-project#12329) (overlookmotel) ### 🎨 Styling - cacbd1e linter/no-empty-function: Order match arms consistently (oxc-project#12815) (camc314) - c15da81 codegen, formatter, linter, minifier, transformer: Re-order imports (oxc-project#12725) (Copilot) ### 🧪 Testing - 3957fcc linter/no-undef: Add test case for `TSImportType` (oxc-project#12800) (camc314) - d8ccff7 oxlint: Add `Tester::test_fix` mehod (oxc-project#12754) (Sysix) - c6bfb8a linter: Add rule configuration consistency test (oxc-project#12744) (camc314) - 2ceb835 linter: Fix offset for partical source texts (oxc-project#12594) (Sysix) Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>

camc314 mentioned this pull request Aug 4, 2025

feat(ast)!: remove IdentifierReference from qualifier field of TSImportType #12799

Merged

github-actions bot added the A-linter Area - Linter label Aug 4, 2025

github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Aug 4, 2025

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from e90d338 to aa0bcc3 Compare August 4, 2025 10:04

camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from e1da626 to cf903e2 Compare August 4, 2025 10:04

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from aa0bcc3 to acdd40b Compare August 4, 2025 10:28

camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from cf903e2 to c8f4709 Compare August 4, 2025 10:28

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from acdd40b to 79536c3 Compare August 4, 2025 10:38

camc314 force-pushed the c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ branch from c8f4709 to 8b59143 Compare August 4, 2025 10:38

camc314 changed the base branch from c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_ to graphite-base/12800 August 4, 2025 10:57

camc314 mentioned this pull request Aug 4, 2025

fix(estree): fix serialization of TSImportTypeQualifier #12801

Merged

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from 79536c3 to 3a311e6 Compare August 4, 2025 10:57

camc314 changed the base branch from graphite-base/12800 to c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ August 4, 2025 10:58

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from 3a311e6 to e4340c6 Compare August 4, 2025 11:03

camc314 force-pushed the c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ branch from deaa510 to 08e03b1 Compare August 4, 2025 11:03

camc314 marked this pull request as ready for review August 4, 2025 11:14

camc314 force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from e4340c6 to 9d7332e Compare August 4, 2025 11:57

camc314 force-pushed the c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ branch from 08e03b1 to 283b510 Compare August 4, 2025 11:57

Sysix approved these changes Aug 4, 2025

View reviewed changes

Sysix added the 0-merge Merge with Graphite Merge Queue label Aug 4, 2025

graphite-app bot force-pushed the c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ branch from 283b510 to 2650fc1 Compare August 4, 2025 16:58

graphite-app bot requested review from Dunqing and overlookmotel as code owners August 4, 2025 16:58

graphite-app bot pushed a commit that referenced this pull request Aug 4, 2025

test(linter/no-undef): add test case for TSImportType (#12800)

c04a1bd

graphite-app bot force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from 9d7332e to c04a1bd Compare August 4, 2025 16:58

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 4, 2025

Boshen added the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025

test(linter/no-undef): add test case for TSImportType (#12800)

3957fcc

closes #12693

graphite-app bot force-pushed the c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ branch from 2650fc1 to 47e2c59 Compare August 5, 2025 05:56

graphite-app bot force-pushed the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch from c04a1bd to 3957fcc Compare August 5, 2025 05:56

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Aug 5, 2025

Base automatically changed from c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_ to main August 5, 2025 06:02

graphite-app bot merged commit 3957fcc into main Aug 5, 2025
25 checks passed

graphite-app bot deleted the c/08-04-test_linter_no-undef_add_test_case_for_tsimporttype_ branch August 5, 2025 06:03

oxc-bot mentioned this pull request Aug 6, 2025

release(oxlint): v1.10.0 #12846

Merged

taearls pushed a commit to taearls/oxc that referenced this pull request Aug 12, 2025

test(linter/no-undef): add test case for TSImportType (oxc-project#…

0b599e0

…12800) closes oxc-project#12693

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

test(linter/no-undef): add test case for `TSImportType` #12800

test(linter/no-undef): add test case for `TSImportType` #12800

Uh oh!

camc314 commented Aug 4, 2025 •

edited

Loading

Uh oh!

camc314 commented Aug 4, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Aug 4, 2025 •

edited

Loading

Uh oh!

Sysix left a comment

Uh oh!

Sysix commented Aug 4, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

test(linter/no-undef): add test case for TSImportType #12800

test(linter/no-undef): add test case for TSImportType #12800

Uh oh!

Conversation

camc314 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Aug 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #12800 will not alter performance

Summary

Footnotes

Uh oh!

Sysix left a comment

Choose a reason for hiding this comment

Uh oh!

Sysix commented Aug 4, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

test(linter/no-undef): add test case for `TSImportType` #12800

test(linter/no-undef): add test case for `TSImportType` #12800

camc314 commented Aug 4, 2025 •

edited

Loading

camc314 commented Aug 4, 2025 •

edited

Loading

codspeed-hq bot commented Aug 4, 2025 •

edited

Loading

Sysix commented Aug 4, 2025 •

edited by graphite-app bot

Loading