Skip to content

Commit 6a360e3

Browse files
committed
fix(linter/import/extensions): update Default implementation for ExtensionsConfig (#12783)
1 parent 445414c commit 6a360e3

File tree

2 files changed

+16
-2
lines changed

2 files changed

+16
-2
lines changed

crates/oxc_linter/src/rules/import/extensions.rs

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ impl FileExtensionConfig {
5252
}
5353
}
5454

55-
#[derive(Debug, Default, Clone)]
55+
#[derive(Debug, Clone)]
5656
pub struct ExtensionsConfig {
5757
ignore_packages: bool,
5858
require_extension: Option<FileExtensionConfig>,
@@ -88,6 +88,21 @@ impl ExtensionsConfig {
8888
}
8989
}
9090

91+
impl Default for ExtensionsConfig {
92+
fn default() -> Self {
93+
Self {
94+
ignore_packages: true,
95+
require_extension: None,
96+
check_type_imports: false,
97+
js: FileExtensionConfig::Never,
98+
jsx: FileExtensionConfig::Never,
99+
ts: FileExtensionConfig::Never,
100+
tsx: FileExtensionConfig::Never,
101+
json: FileExtensionConfig::Never,
102+
}
103+
}
104+
}
105+
91106
#[derive(Debug, Default, Clone)]
92107
pub struct Extensions(Box<ExtensionsConfig>);
93108

crates/oxc_linter/tests/rule_configuration_test.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ fn test_rule_default_matches_from_configuration_null() {
2525
// 1. The Default implementation returns the same values as from_configuration(null), or
2626
// 2. The from_configuration method is updated to return Default::default() when given null
2727
let exceptions = [
28-
"import/extensions",
2928
"import/no-anonymous-default-export",
3029
"jest/no-deprecated-functions",
3130
"jest/no-large-snapshots",

0 commit comments

Comments
 (0)