fix(estree): fix serialization of TSImportTypeQualifier
#12801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
changed the base branch from
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
to
graphite-base/12801
CodSpeed Instrumentation Performance ReportMerging #12801 will not alter performanceComparing Summary
Footnotes |
camc314
force-pushed
the
graphite-base/12801
branch
from
8b59143 to
bcc9307
Compare
camc314
force-pushed
the
c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_
branch
from
deaa510 to
08e03b1
Compare
camc314
changed the base branch from
graphite-base/12801
to
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
camc314
force-pushed
the
c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_
branch
from
08e03b1 to
283b510
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
branch
from
bcc9307 to
e069284
Compare
graphite-app
bot
requested review from
Dunqing and
overlookmotel
as code owners
graphite-app
bot
force-pushed
the
c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_
branch
from
283b510 to
2650fc1
Compare
graphite-app
bot
added
0-merge
graphite-app
bot
force-pushed
the
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
branch
from
e069284 to
50b91ac
Compare
graphite-app
bot
force-pushed
the
c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_
branch
from
2650fc1 to
47e2c59
Compare
Base automatically changed from
c/08-04-feat_ast_remove_identifierreference_from_qualifier_field_of_tsimporttype_
to
main
August 5, 2025 06:01
graphite-app
bot
deleted the
c/08-04-fix_estree_fix_serialization_of_tsimporttypequalifier_
branch
This was referenced Aug 6, 2025
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Aug 12, 2025
…fier` (oxc-project#12961) Follow-on after oxc-project#12801. Remove the custom serializer for `TSImportTypeQualifier`. All we need is to rename `TSImportTypeQualifiedName` to `TSQualifiedName`, so we can use `#[estree(rename = "TSQualifiedName")]`, and let the codegen do the rest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.