perf(linter): Eliminate unnecessary Iterator::collect() allocations (oxc-project#12776)

Author: Copilot

crates/oxc_linter/src/rules/react/exhaustive_deps.rs

@@ -590,9 +590,6 @@ impl Rule for ExhaustiveDeps {
 
         // effects are allowed to have extra dependencies
         if !is_effect {
-            let unnecessary_deps: Vec<_> =
-                declared_dependencies.difference(&found_dependencies).collect();
-
             // lastly, we need co compare for any unnecessary deps
             // for example if `props.foo`, AND `props.foo.bar.baz` was declared in the deps array
             // `props.foo.bar.baz` is unnecessary (already covered by `props.foo`)
@@ -612,7 +609,7 @@ impl Rule for ExhaustiveDeps {
                 }
             });
 
-            for dep in unnecessary_deps {
+            for dep in declared_dependencies.difference(&found_dependencies) {
                 if found_dependencies.iter().any(|found_dep| found_dep.contains(dep)) {
                     continue;
                 }

crates/oxc_semantic/examples/cfg.rs

@@ -139,15 +139,16 @@ fn main() -> std::io::Result<()> {
             },
             &|_graph, node| {
                 let nodes = ast_nodes_by_block.get(node.1).map_or("None".to_string(), |nodes| {
-                    let nodes: Vec<_> =
-                        nodes.iter().map(|node| format!("{}", node.kind().debug_name())).collect();
                     if nodes.len() > 1 {
                         format!(
                             "{}\\l",
-                            nodes.into_iter().map(|it| format!("\\l    {it}")).join("")
+                            nodes
+                                .iter()
+                                .map(|node| format!("\\l    {}", node.kind().debug_name()))
+                                .join("")
                         )
                     } else {
-                        nodes.into_iter().join("")
+                        nodes.iter().map(|node| format!("{}", node.kind().debug_name())).join("")
                     }
                 });
                 format!(