build: release v6.153.0

[KenLSM]

New

• test(emailpreview): chromatic support #7786
• fix: update the form field type for v3 test cases #7787
• feat: email response summary #7781
• fix: set form fields to use formfielddto type #7783
• chore: upgrade ts-eslint to v8 #7759
• build: merge release v6.152.0 to develop #7779
• chore: manually upgrade webpack #7780
• feat: no notify for steps after reject step #7771
• feat: mrf be field validation #7718
• build: release v6.152.0 #7773

Dependencies

• fix(deps): bump libphonenumber-js from 1.11.11 to 1.11.12 in /shared #7791

Dev-Dependencies

• chore(deps-dev): bump @types/jsonwebtoken from 9.0.6 to 9.0.7 #7790
• chore(deps-dev): bump @typescript-eslint/eslint-plugin from 8.8.1 to 8.10.0 in /shared #7792
• chore(deps-dev): bump @typescript-eslint/parser from 8.8.1 to 8.10.0 in /shared #7793
• chore(deps-dev): bump @types/uid-generator from 2.0.3 to 2.0.6 #7784
• chore(deps-dev): bump prettier from 3.3.2 to 3.3.3 #7785
• chore(deps-dev): bump ts-jest from 29.1.2 to 29.2.5 #7782
• chore(deps-dev): bump @types/promise-timeout from 1.3.0 to 1.3.3 #7775

Tests

feat: email response summary #7781

Test workflow completion email:

• Create an MRF form with a variety of form field types (decimal, short text, email, mobile number, table and attachment). Ensure at least one of the form fields is optional.
• Set email notification to your email inbox.
• Set a single workflow step to fill up all the forms.
• Submit the single step to complete the MRF workflow. Leave the optional field blank.
• Verify workflow completion email is received with correct fields. The blank optional field should be excluded from the responses summary.

Test workflow approved email:

• Add a yes/no field and set it to second step in workflow.
• Submit both steps. Ensure the optional field is now filled.
• Verify the workflow approved email is received with the correct field values. The optional field should now be included in the email since it is filled.

Test workflow rejected email:

• Repeat the previous TC, but reject the workflow.
• Verify the workflow not approved email is received with the correct field values.

feat: no notify for steps after reject step #7771

TC1: Regression test for approve

• Create MRF workflow with 3 steps
• Set step 2 and step 3 as approval step
• Set steps 2 and 3 as notification step
• Approve form completely.
• See that steps 2 and 3 email get approve email.

TC2: No notify for steps after reject step

• From MRF from TC1
• Reject at step 2
• Ensure only step 2 gets the reject email (Step 3 does not get an email)

TC3: Regression test for reject

• From MRF from TC1
• Reject at step 3
• Ensure both step 2 and 3 gets the reject email

feat: mrf be field validation #7718

Regression test:

• Create an MRF form with all types of basic fields, try a combination of different field settings.
• Create a table with dropdown field and text field col.
• Fill in with valid values and ensure that we can still submit all fields without validation error.

Setup for next few tests:

• Set all fields in earlier MRF form to optional to prepare for the next few test cases.
• Go to web console (inspect -> find the XHR request -> copy as cURL), save this in a text editor to create invalidate submissions

Checkbox field validation - no duplicates with others:

• Create a option called Others: A
• Enabled others
• Submit the form with checkbox response selecting the option Others: A and a custom A value in others
• Should return a validation failure, which matches Storage/email mode validation.

Table field validation:

• From the cURL command in setup, add row to table field type value despite addMoreRows disabled, it should reject.
• From the cURL command in setup, add row to table field type value, enable addMoreRows, it should accept.
• From the cURL command in setup, add more rows than maxRowsAllowed to table field type value with addMoreRows enabled, it should reject.
• Make text field required, set the textField value in row to '' empty string, it should reject.
• Change dropdown to invalid value, it should reject.
• Set text field and dropdown to not required, send empty string values for both, it should accept.

Short text length enforced:

• From the cURL command in setup, change the value of 'textfield' to less than the minimum text length set and submit, it should reject.

Children field not allowed in MRF:

• From the cURL command in setup, change the fieldType of any to children and submit, it should reject.

Decimal field range is enforced:

• From the cURL command in setup, change the value of decimal fieldType to beyond the valid range and submit, it should reject.

Short text length is enforced:

• From the cURL command in setup, change the value of short fieldType to beyond the valid range and submit, it should reject.

Valid country/region only:

• From the cURL command in setup, change the value of country_region fieldType to invalid value and submit, it should reject.

NRIC must be valid:

• From the cURL command in setup, change the value of nric fieldType to invalid nric value and submit, it should reject.

Invalid field types not allowed:

• From the cURL command in setup, change the value of fieldType to invalid field type eg, abc and submit, it should reject.

[datadog-opengovsg]

Datadog Report

Branch report: release_v6.153.0
Commit report: 07186a9
Test service: formsg

✅ 0 Failed, 1856 Passed, 1 Skipped, 3m 9.38s Total duration (2m 51.15s time saved)

[kevin9foong]

lgtm!

[KenLSM]

For the curl requests, we're checking through errorCodes instead of outright reject as we're introducing the validation on shadow.

Verified that we're receiving errorCode: 100702