Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(emailpreview): chromatic support #7786

Merged
merged 3 commits into from
Oct 18, 2024
Merged

test(emailpreview): chromatic support #7786

merged 3 commits into from
Oct 18, 2024

Conversation

KenLSM
Copy link
Contributor

@KenLSM KenLSM commented Oct 17, 2024 •
edited
Loading

Problem

  1. Our email previews are not published to chromatic, thus it is difficult for our designers to review them without developers deploying to staging / production.
  2. We are also unaware of unintended changes to emails without snapshot comparison.

Closes FRM-1884

Solution

Adds support to publish to chromatic.

Breaking Changes

  • No - this PR is backwards compatible

@linear Linear
Copy link

linear bot commented Oct 17, 2024

FRM-1884 Email preview chromatic / storybook integration

@KenLSM KenLSM force-pushed the chore/chromatic-email-preview branch 2 times, most recently from 0e25092 to bbde468 Compare October 17, 2024 06:38
@KenLSM KenLSM force-pushed the chore/chromatic-email-preview branch from bbde468 to db2640b Compare October 17, 2024 06:43
@KenLSM KenLSM enabled auto-merge (squash) October 17, 2024 07:09
kevin9foong
kevin9foong approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@kevin9foong kevin9foong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KenLSM KenLSM merged commit 6fb8623 into develop Oct 18, 2024
25 of 26 checks passed
@KenLSM KenLSM deleted the chore/chromatic-email-preview branch October 18, 2024 07:36
@KenLSM KenLSM mentioned this pull request Oct 20, 2024
Merged
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin9foong kevin9foong kevin9foong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KenLSM @kevin9foong