Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set form fields to use formfielddto type #7783

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

kevin9foong
Copy link
Contributor

Problem

See linear ticket.

Closes FRM-1881

Solution

See linear ticket.

Breaking Changes

  • No - this PR is backwards compatible

Copy link

linear bot commented Oct 16, 2024

Copy link
Contributor

@KenLSM KenLSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Paired to solve this.

@datadog-opengovsg
Copy link

Datadog Report

Branch report: fix/mrf-be-validation-formfield-type-collision
Commit report: c1bcc11
Test service: formsg

✅ 0 Failed, 1241 Passed, 1 Skipped, 1m 49.87s Total duration (4m 10.66s time saved)

@kevin9foong kevin9foong merged commit 249fe0d into develop Oct 16, 2024
15 checks passed
@kevin9foong kevin9foong deleted the fix/mrf-be-validation-formfield-type-collision branch October 16, 2024 07:55
@KenLSM KenLSM mentioned this pull request Oct 20, 2024
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants