feat: no notify for steps after reject step #7771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 109 Passed, 0 Skipped, 44.39s Total duration (11m 2.39s time saved) |
kevin9foong
force-pushed
the
fix/no-notify-steps-after-rejection
branch
from
b64e756
to
07343cc
Compare
KenLSM
reviewed
Oct 15, 2024
| }, | ||
| } as FieldResponsesV3 | ||
|
|
||
| const fourStepApprovalWorkflow: FormWorkflowStepDto[] = [ |
There was a problem hiding this comment.
Wouldn't this be regarded as 5 steps?
There was a problem hiding this comment.
yes, i added another step but forgot to update the name. Thanks for this catch!
KenLSM
reviewed
Oct 15, 2024
| }, | ||
| ] | ||
|
|
||
| const currentStepNumber = 1 // 2nd step of 3 steps workflow |
There was a problem hiding this comment.
Suggested change
| const currentStepNumber = 1 // 2nd step of 3 steps workflow | |
| const currentStepNumber = 1 // 2nd step of 5 steps workflow |
KenLSM
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For rejected workflows, steps after the rejection should not be notified when a rejection happens earlier in the chain.
Closes FRM-1876
Solution
Do not notify subsequent steps if earlier step rejects.
Breaking Changes
Tests
TC1: Regression test for approve
TC2: No notify for steps after reject step
TC3: Regression test for reject