fix: update the form field type for v3 test cases #7787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 26 Passed, 0 Skipped, 27.06s Total duration (11m 34s time saved) |
KenLSM
reviewed
Oct 17, 2024
| attachmentSize: AttachmentSize.OneMb, | ||
| }) | ||
| }) as FormFieldDto |
There was a problem hiding this comment.
Is this typecasting still required since generateDefaultFieldV3 returns FormFieldDto
There was a problem hiding this comment.
I missed out the removal of this cast as that was my initial solution before deciding to make a common generateDefaultFieldV3 function. Thanks for the catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Due to the update in the type that the
fieldValidatorV3argument accepts, the test case types are mismatched.Closes FRM-1881
Solution
Update the formfield to use defaultFieldGenerator which casts the type to
FormFieldDtoBreaking Changes