Skip to content

cli: fix spacing for port range error - #54495

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-105
Sep 18, 2024
Merged

cli: fix spacing for port range error#54495
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-105

Conversation

@avivkeller

@avivkeller avivkeller commented Aug 22, 2024

Copy link
Copy Markdown
Member

Before

node:  must be 0 or in range 1024 to 65535.

After

node: must be 0 or in range 1024 to 65535.

Note the double spacing in the before comparison.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 22, 2024
@codecov

codecov Bot commented Aug 22, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.34%. Comparing base (cc26951) to head (dcb3f1d).
Report is 279 commits behind head on main.

Files with missing lines Patch % Lines
src/node_options.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #54495   +/-   ##
=======================================
  Coverage   87.34%   87.34%           
=======================================
  Files         649      649           
  Lines      182544   182524   -20     
  Branches    35030    35028    -2     
=======================================
- Hits       159445   159428   -17     
  Misses      16372    16372           
+ Partials     6727     6724    -3     
Files with missing lines Coverage Δ
src/node_options.cc 87.82% <0.00%> (ø)

... and 24 files with indirect coverage changes

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkeller

Copy link
Copy Markdown
Member Author

It's been a week since the last CI, however the failures appear to flakes. I assume it needs another run, right?

@avivkeller avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@avivkeller

Copy link
Copy Markdown
Member Author

2 weeks have passed... I've started a new CI, as the last one is old.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 18, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 18, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 65768bc into nodejs:main Sep 18, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 65768bc

@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants