benchmark: create benchmark for typescript #54904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
benchmark
RedYetiDev
reviewed
Sep 12, 2024
|
IIRC, dead-code elimination may affect the becnhmark, so setting a variable, and later asserting it will prevent that. |
RedYetiDev
reviewed
Sep 12, 2024
RafaelGSS
reviewed
Sep 12, 2024
There's no guarantee on that. It's just an assumption that might not be true. However, it's recommended to do it. |
marco-ippolito
force-pushed
the
benchmark/bench-strip-transform-types
branch
2 times, most recently
from
bdfb933
to
b8e57a3
Compare
RedYetiDev
reviewed
Sep 12, 2024
marco-ippolito
force-pushed
the
benchmark/bench-strip-transform-types
branch
3 times, most recently
from
3489ce0
to
5bafadd
Compare
RafaelGSS
reviewed
Sep 12, 2024
mcollina
requested changes
Sep 14, 2024
marco-ippolito
force-pushed
the
benchmark/bench-strip-transform-types
branch
from
5bafadd
to
a8d3872
Compare
marco-ippolito
force-pushed
the
benchmark/bench-strip-transform-types
branch
from
a8d3872
to
f7bda51
Compare
|
@mcollina can this land? I believe the request has been resolved since with the query param the modules are not cached |
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 00d4f80 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54904 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
6 tasks
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54904 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some benchmarks for
--experimental-strip-typesand--experimental-transform-types.First time writing a benchmark so open to suggestions