-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: ensure invalid SubtleCrypto JWK data import results in DataError #55041
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:webcrypto-ensure-DataError
Sep 23, 2024
Merged
crypto: ensure invalid SubtleCrypto JWK data import results in DataError #55041
nodejs-github-bot
merged 1 commit into
nodejs:main
from
panva:webcrypto-ensure-DataError
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panva
added
crypto
Issues and PRs related to the crypto subsystem.
request-ci
Add this label to start a Jenkins CI on a PR.
webcrypto
labels
Sep 21, 2024
Review requested:
|
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Sep 21, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 21, 2024
panva
added
lts-watch-v18.x
PRs that may need to be released in v18.x.
lts-watch-v20.x
PRs that may need to be released in v20.x
web-standards
Issues and PRs related to Web APIs
labels
Sep 21, 2024
cc @nodejs/web-standards |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55041 +/- ##
==========================================
+ Coverage 88.06% 88.23% +0.16%
==========================================
Files 652 652
Lines 183546 183886 +340
Branches 35860 35860
==========================================
+ Hits 161648 162251 +603
+ Misses 15149 14916 -233
+ Partials 6749 6719 -30
|
jasnell
approved these changes
Sep 21, 2024
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 21, 2024
anonrig
approved these changes
Sep 23, 2024
panva
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 23, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 23, 2024
Landed in b64006c |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #55041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 2, 2024
PR-URL: #55041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
added
backported-to-v18.x
PRs backported to the v18.x-staging branch.
and removed
lts-watch-v18.x
PRs that may need to be released in v18.x.
labels
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
crypto
Issues and PRs related to the crypto subsystem.
lib / src
Issues and PRs related to general changes in the lib or src directory.
lts-watch-v20.x
PRs that may need to be released in v20.x
needs-ci
PRs that need a full CI run.
web-standards
Issues and PRs related to Web APIs
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All invalid data during import is supposed to return
DataError
DOMException
. See https://w3c.github.io/webcrypto/The WPTs for this are coming in web-platform-tests/wpt#48243 but I'm opening this separately to be able to backport this easily.