build: print Running XYZ linter... for py and yml
#54386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
RedYetiDev
added
the
commit-queue-squash
lpinca
approved these changes
Aug 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54386 +/- ##
==========================================
+ Coverage 87.09% 87.32% +0.23%
==========================================
Files 648 648
Lines 182250 182359 +109
Branches 34967 34982 +15
==========================================
+ Hits 158732 159247 +515
+ Misses 16797 16383 -414
- Partials 6721 6729 +8 |
github-actions
bot
removed
the
request-ci
|
No objections in a week, but the CI isn't passing (though I don't think its related) |
|
CI is 🟢 |
|
The last CI was from several weeks ago, so I've started a new one. |
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Something was pushed to the Pull Request branch since the last approving review. ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/10799312241 |
github-actions
bot
removed
the
request-ci
RedYetiDev
removed
the
request-ci-failed
|
Aside from the flaky failures, CI LGTM |
|
Is this land-able? |
lpinca
approved these changes
Sep 18, 2024
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 96e0570 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54386 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54386 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
lint-pyandlint-yamllinters printRunning [Python/YAML] linter...just like the others.lint-pypreviously printed the ruff version, which isn't needed, as it's not printed in any other linter.