repl: catch \v and \r in new-line detection
#54512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
Can you add a test? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54512 +/- ##
==========================================
- Coverage 88.26% 88.24% -0.03%
==========================================
Files 651 651
Lines 183894 183877 -17
Branches 35858 35857 -1
==========================================
- Hits 162315 162255 -60
- Misses 14882 14898 +16
- Partials 6697 6724 +27
|
|
@RedYetiDev Thanks for the quick fix. |
|
CC @nodejs/repl |
BridgeAR
approved these changes
Aug 24, 2024
github-actions
bot
removed
the
request-ci
LiviaMedeiros
approved these changes
Aug 31, 2024
RedYetiDev
added
the
commit-queue-squash
|
Maybe this'll fix it? |
|
Could someone start a new CI? Triagers can't start one without an approving review. |
github-actions
bot
removed
the
request-ci
RedYetiDev
added
author ready
|
CI LGTM. This should be good to |
H4ad
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54512 ✔ Done loading data for nodejs/node/pull/54512 ----------------------------------- PR info ------------------------------------ Title repl: catch `\v` and `\r` in new-line detection (#54512) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-106 -> nodejs:main Labels repl, author ready, needs-ci, commit-queue-squash Commits 2 - repl: catch `\v` and `\r` in new-line detection - disable if no inspector Committers 2 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - disable if no inspector ℹ This PR was created on Thu, 22 Aug 2024 20:48:50 GMT ✔ Approvals: 3 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2258269961 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54512#pullrequestreview-2259289159 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54512#pullrequestreview-2274130019 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-21T15:51:28Z: https://ci.nodejs.org/job/node-test-pull-request/62627/ - Querying data for job/node-test-pull-request/62627/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11001786432 |
aduh95
reviewed
Sep 23, 2024
aduh95
approved these changes
Sep 23, 2024
RedYetiDev
force-pushed
the
patch-106
branch
from
da344b7
to
500c5ee
Compare
|
I reverted the change suggested because |
jakecastelli
added
request-ci
github-actions
bot
removed
the
request-ci
|
CI is 🟢 (yay!) |
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54512 ✔ Done loading data for nodejs/node/pull/54512 ----------------------------------- PR info ------------------------------------ Title repl: catch `\v` and `\r` in new-line detection (#54512) Author Aviv Keller <redyetidev@gmail.com> (@RedYetiDev) Branch RedYetiDev:patch-106 -> nodejs:main Labels repl, author ready, needs-ci, commit-queue-squash Commits 4 - repl: catch `\v` and `\r` in new-line detection - disable if no inspector - fixup! - fixup! fixup! Committers 1 - RedYetiDev <38299977+RedYetiDev@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - repl: catch `\v` and `\r` in new-line detection ⚠ - disable if no inspector ⚠ - fixup! ⚠ - fixup! fixup! ℹ This PR was created on Thu, 22 Aug 2024 20:48:50 GMT ✔ Approvals: 4 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2258269961 ✔ - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/54512#pullrequestreview-2259289159 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/54512#pullrequestreview-2274130019 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/54512#pullrequestreview-2323267187 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-24T15:06:29Z: https://ci.nodejs.org/job/node-test-pull-request/62735/ - Querying data for job/node-test-pull-request/62735/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11021667751 |
aduh95
approved these changes
Sep 25, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c6d20a0 |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54512 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54504
Uses
RegExpPrototypeExec(with\n,\r, and\v) rather thanStringPrototypeIndexOfwith\n.