cluster: send or handle later instead of closing it when the worker can not accept a connection #43747

theanarkh · 2022-07-09T21:24:16Z

If there are several servers, send the connection to other server when the worker can not accept it, instead of closing it.
If only on server, the worker will accept the connection later, instead of closing it.

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected subsystem: cluster

theanarkh · 2022-07-13T02:01:44Z

@mcollina @ShogunPanda Hi ! can you help review this PR ?

mcollina

lgtm

nodejs-github-bot · 2022-07-13T10:07:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45388/

ShogunPanda

LGTM!

nodejs-github-bot · 2022-07-17T08:08:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45482/

nodejs-github-bot · 2022-07-17T09:49:25Z

Commit Queue failed

- Loading data for nodejs/node/pull/43747
✔  Done loading data for nodejs/node/pull/43747
----------------------------------- PR info ------------------------------------
Title      cluster: send or handle later instead of closing it when the worker can not accept a connection (#43747)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:send_connection_to_other_server_when_worker_drop_it -> nodejs:main
Labels     cluster, author ready, needs-ci
Commits    1
 - cluster: send connection to other server when worker drop it
Committers 1
 - theanarkh 
PR-URL: https://github.com/nodejs/node/pull/43747
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43747
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - cluster: send connection to other server when worker drop it
   ℹ  This PR was created on Sat, 09 Jul 2022 21:24:16 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43747#pullrequestreview-1037103767
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43747#pullrequestreview-1037128282
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-07-17T08:08:07Z: https://ci.nodejs.org/job/node-test-pull-request/45482/
- Querying data for job/node-test-pull-request/45482/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2685047248

mcollina

lgtm

nodejs-github-bot · 2022-07-18T09:06:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45515/

nodejs-github-bot · 2022-07-21T16:47:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45582/

nodejs-github-bot · 2022-07-22T16:18:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45597/

theanarkh · 2022-07-22T18:11:32Z

Failed on windows. I will take a look.

Mismatched function calls. Expected exactly 9, actual 0.
at Proxy.mustCall (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:396:10)
at Object. (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-cluster-net-server-drop-connection.js:45:42)
at Module._compile (node:internal/modules/cjs/loader:1120:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
at Module.load (node:internal/modules/cjs/loader:998:32)
at Module._load (node:internal/modules/cjs/loader:839:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:17:47
node:internal/child_process:821
handle.setSimultaneousAccepts(true);
^

TypeError: handle.setSimultaneousAccepts is not a function
at target._send (node:internal/child_process:821:16)
at target.send (node:internal/child_process:738:19)
at sendHelper (node:internal/cluster/utils:28:15)
at RoundRobinHandle.handoff (node:internal/cluster/round_robin_handle:128:3)
at RoundRobinHandle.distribute (node:internal/cluster/round_robin_handle:108:10)
at handle.onconnection (node:internal/cluster/round_robin_handle:45:54)

theanarkh · 2022-07-22T19:48:42Z

It seems a bug of Node.js core. I will pull another PR to fix it.

nodejs-github-bot · 2022-07-23T08:08:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45607/

nodejs-github-bot · 2022-07-23T10:12:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/45609/

nodejs-github-bot · 2022-07-23T11:11:24Z

Commit Queue failed

- Loading data for nodejs/node/pull/43747
✔  Done loading data for nodejs/node/pull/43747
----------------------------------- PR info ------------------------------------
Title      cluster: send or handle later instead of closing it when the worker can not accept a connection (#43747)
Author     theanarkh  (@theanarkh)
Branch     theanarkh:send_connection_to_other_server_when_worker_drop_it -> nodejs:main
Labels     cluster, author ready, needs-ci, commit-queue-squash
Commits    1
 - cluster: send connection to other server when worker drop it
Committers 1
 - theanarkh 
PR-URL: https://github.com/nodejs/node/pull/43747
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43747
Reviewed-By: Matteo Collina 
Reviewed-By: Paolo Insogna 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - cluster: send connection to other server when worker drop it
   ℹ  This PR was created on Sat, 09 Jul 2022 21:24:16 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/43747#pullrequestreview-1041490503
   ✔  - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/43747#pullrequestreview-1037128282
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-07-23T10:12:43Z: https://ci.nodejs.org/job/node-test-pull-request/45609/
- Querying data for job/node-test-pull-request/45609/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2723454691

theanarkh · 2022-07-23T12:46:56Z

@mcollina Hi, can you help review this again ? What i update after last approve is as follows.

// The core has bug in handling pipe handle by ipc when platform is win32,
// it can be triggered on win32. I will fix it in another pr.
if (common.isWindows)
  common.skip('no setSimultaneousAccepts on pipe handle');

mcollina · 2022-07-23T13:27:16Z

What happens on win32? Unfortunately it's still a platform we support.

I think we would need an additional check for win32 also in child.js.

theanarkh · 2022-07-23T13:57:23Z

Node.js core have a bug on win32 when send pipe handle by IPC channel.

TypeError: handle.setSimultaneousAccepts is not a function
at target._send (node:internal/child_process:821:16)
at target.send (node:internal/child_process:738:19)
at sendHelper (node:internal/cluster/utils:28:15)
at RoundRobinHandle.handoff (node:internal/cluster/round_robin_handle:128:3)
at RoundRobinHandle.distribute (node:internal/cluster/round_robin_handle:108:10)
at handle.onconnection (node:internal/cluster/round_robin_handle:45:54)

I will fix it in #43951. And i think the feature of this PR is not related to platform🤔.

mcollina

lgtm

nodejs-github-bot · 2022-07-24T10:18:35Z

Landed in c7ac42f

PR-URL: #43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

##### [\`v18.7.0\`](https://github.com/nodejs/node/releases/tag/v18.7.0) ##### Notable changes - **doc**: - add F3n67u to collaborators (Feng Yu) [#43953](nodejs/node#43953) - deprecate coercion to integer in process.exit (Daeyeon Jeong) [#43738](nodejs/node#43738) - **(SEMVER-MINOR)** deprecate diagnostics_channel object subscribe method (Stephen Belanger) [#42714](nodejs/node#42714) - **events**: - **(SEMVER-MINOR)** expose CustomEvent on global with CLI flag (Daeyeon Jeong) [#43885](nodejs/node#43885) - **(SEMVER-MINOR)** add `CustomEvent` (Daeyeon Jeong) [#43514](nodejs/node#43514) - **http**: - **(SEMVER-MINOR)** add drop request event for http server (theanarkh) [#43806](nodejs/node#43806) - **lib**: - **(SEMVER-MINOR)** improved diagnostics_channel subscribe/unsubscribe (Stephen Belanger) [#42714](nodejs/node#42714) - **util**: - **(SEMVER-MINOR)** add tokens to parseArgs (John Gee) [#43459](nodejs/node#43459) ##### Commits - \[[`0aa255ab72`](nodejs/node@0aa255ab72)] - **bootstrap**: handle snapshot errors gracefully (Joyee Cheung) [#43531](nodejs/node#43531) - \[[`0783ddf57e`](nodejs/node@0783ddf57e)] - **buffer**: do not leak memory if buffer is too big (Keyhan Vakil) [#43938](nodejs/node#43938) - \[[`12657accdd`](nodejs/node@12657accdd)] - **build**: add .gitattributes for npm and other shims (Hrishikesh Kadam) [#43879](nodejs/node#43879) - \[[`c2db4f4581`](nodejs/node@c2db4f4581)] - **build**: make GitPod less noisy (Rich Trott) [#43829](nodejs/node#43829) - \[[`364deeadcd`](nodejs/node@364deeadcd)] - **build**: add GitHub token permissions for workflows (Varun Sharma) [#43743](nodejs/node#43743) - \[[`8b83b4d5be`](nodejs/node@8b83b4d5be)] - **child_process**: do not need to count length when maxBuffer is Infinity (theanarkh) [#43822](nodejs/node#43822) - \[[`c1893b7a7c`](nodejs/node@c1893b7a7c)] - **child_process**: avoid repeated calls to `normalizeSpawnArguments` (木杉) [#43345](nodejs/node#43345) - \[[`7b276b89b9`](nodejs/node@7b276b89b9)] - **cluster**: send connection to other server when worker drop it (theanarkh) [#43747](nodejs/node#43747) - \[[`e8c66f92a5`](nodejs/node@e8c66f92a5)] - **crypto**: remove unneeded guard (Rich Trott) [#43856](nodejs/node#43856) - \[[`c95132e9ea`](nodejs/node@c95132e9ea)] - **deps**: cherry-pick [libuv/libuv@`3a7b955`](libuv/libuv@3a7b955) (Ben Noordhuis) [#43950](nodejs/node#43950) - \[[`cc8d5426d2`](nodejs/node@cc8d5426d2)] - **deps**: cherry-pick [libuv/libuv@`abb109f`](libuv/libuv@abb109f) (Ben Noordhuis) [#43950](nodejs/node#43950) - \[[`7762e463d6`](nodejs/node@7762e463d6)] - **deps**: update corepack to 0.12.1 (Node.js GitHub Bot) [#43965](nodejs/node#43965) - \[[`1256c4dad5`](nodejs/node@1256c4dad5)] - **deps**: update hast-util-raw (Moshe Atlow) [#43927](nodejs/node#43927) - \[[`aac97c2d2a`](nodejs/node@aac97c2d2a)] - **deps**: update undici to 5.8.0 (Node.js GitHub Bot) [#43886](nodejs/node#43886) - \[[`cdff61917d`](nodejs/node@cdff61917d)] - **deps**: clean archs files for OpenSSL (RafaelGSS) [#43735](nodejs/node#43735) - \[[`fc936a84e4`](nodejs/node@fc936a84e4)] - **deps**: remove not used architectures (RafaelGSS) [#43735](nodejs/node#43735) - \[[`361a643d8b`](nodejs/node@361a643d8b)] - **deps**: V8: backport [`f3cad8c`](nodejs/node@f3cad8cec656) (Joyee Cheung) [#43531](nodejs/node#43531) - \[[`2e1732ebd0`](nodejs/node@2e1732ebd0)] - **deps**: V8: backport [`22698d2`](nodejs/node@22698d267667) (Chengzhong Wu) [#43751](nodejs/node#43751) - \[[`979f469d3a`](nodejs/node@979f469d3a)] - **deps**: upgrade npm to 8.15.0 (npm team) [#43917](nodejs/node#43917) - \[[`4096d81988`](nodejs/node@4096d81988)] - **deps**: upgrade npm to 8.14.0 (npm team) [#43826](nodejs/node#43826) - \[[`2ec8092e2c`](nodejs/node@2ec8092e2c)] - **deps,src**: use SIMD for normal base64 encoding (Brian White) [#39775](nodejs/node#39775) - \[[`67b4edde37`](nodejs/node@67b4edde37)] - **dns**: fix getServers return undefined (jiahao.si) [#43922](nodejs/node#43922) - \[[`7c75539a88`](nodejs/node@7c75539a88)] - **dns**: fix cares memory leak (theanarkh) [#43912](nodejs/node#43912) - \[[`1f80b88da5`](nodejs/node@1f80b88da5)] - **doc**: update email and mailmap for BethGriggs (Beth Griggs) [#43985](nodejs/node#43985) - \[[`8a2a6e16eb`](nodejs/node@8a2a6e16eb)] - **doc**: add 15.x - 18.x to Other Versions section (shhh7612) [#43940](nodejs/node#43940) - \[[`51cb0d42ca`](nodejs/node@51cb0d42ca)] - **doc**: inspector.close undefined in worker threads (Keyhan Vakil) [#43867](nodejs/node#43867) - \[[`c789c0f5f7`](nodejs/node@c789c0f5f7)] - **doc**: improve documentation for safe `Promise` statics alternatives (Antoine du Hamel) [#43759](nodejs/node#43759) - \[[`cb9b0e0011`](nodejs/node@cb9b0e0011)] - **doc**: recommend git-node-v8 (Keyhan Vakil) [#43934](nodejs/node#43934) - \[[`d7e9bd1830`](nodejs/node@d7e9bd1830)] - **doc**: clarify subprocess.stdout/in/err property (Kohei Ueno) [#43910](nodejs/node#43910) - \[[`808793ebb5`](nodejs/node@808793ebb5)] - **doc**: fix typo in `src/crypto/README.md` (Jianru Lin) [#43968](nodejs/node#43968) - \[[`bbc455c4f9`](nodejs/node@bbc455c4f9)] - **doc**: remind backporter about v8\_embedder_string (Keyhan Vakil) [#43924](nodejs/node#43924) - \[[`a86b66c8b4`](nodejs/node@a86b66c8b4)] - **doc**: fix typo in http.md (Airing) [#43933](nodejs/node#43933) - \[[`a96af37233`](nodejs/node@a96af37233)] - **doc**: add F3n67u to collaborators (Feng Yu) [#43953](nodejs/node#43953) - \[[`aa7d4e59f7`](nodejs/node@aa7d4e59f7)] - **doc**: improve test runner timeout docs (Tobias Nießen) [#43836](nodejs/node#43836) - \[[`80c2fa8212`](nodejs/node@80c2fa8212)] - **doc**: mention Win 32-bit openssl build issue (RafaelGSS) [#43853](nodejs/node#43853) - \[[`8b8c55df7e`](nodejs/node@8b8c55df7e)] - **doc**: add security release specifics to releases.md (Beth Griggs) [#43835](nodejs/node#43835) - \[[`42693aaf9f`](nodejs/node@42693aaf9f)] - **doc**: add history info for `global.performance` (Antoine du Hamel) [#43841](nodejs/node#43841) - \[[`140d6af572`](nodejs/node@140d6af572)] - **doc**: add platform-windows-arm to who to CC (Michael Dawson) [#43808](nodejs/node#43808) - \[[`976093efe3`](nodejs/node@976093efe3)] - **doc**: document ES2022's Error "cause" property (James Ide) [#43830](nodejs/node#43830) - \[[`ec7e45e4a2`](nodejs/node@ec7e45e4a2)] - **doc**: include make clean to openssl arch (RafaelGSS) [#43735](nodejs/node#43735) - \[[`d64dfd53c9`](nodejs/node@d64dfd53c9)] - **doc**: add link to diagnostic tools (Rafael Gonzaga) [#43736](nodejs/node#43736) - \[[`2910136920`](nodejs/node@2910136920)] - **doc**: update links to MDN page about dynamic imports (Jannis R) [#43847](nodejs/node#43847) - \[[`d88a9fae79`](nodejs/node@d88a9fae79)] - **doc**: deprecate coercion to integer in process.exit (Daeyeon Jeong) [#43738](nodejs/node#43738) - \[[`fc843e103d`](nodejs/node@fc843e103d)] - **doc**: add MoLow to triagers (Moshe Atlow) [#43799](nodejs/node#43799) - \[[`8c8c97da61`](nodejs/node@8c8c97da61)] - **(SEMVER-MINOR)** **doc**: deprecate diagnostics_channel object subscribe method (Stephen Belanger) [#42714](nodejs/node#42714) - \[[`9b53a694b5`](nodejs/node@9b53a694b5)] - **doc**: revert anachronistic 'node:' module require()s in API history notes (DeeDeeG) [#43768](nodejs/node#43768) - \[[`2815bd3002`](nodejs/node@2815bd3002)] - **doc**: clarify release process for new releasers (Rafael Gonzaga) [#43739](nodejs/node#43739) - \[[`50b3750e67`](nodejs/node@50b3750e67)] - **doc**: fix typo in ngtcp2 readme (Dan Castillo) [#43767](nodejs/node#43767) - \[[`6bcd40dd85`](nodejs/node@6bcd40dd85)] - **domain**: fix vm promise tracking while keeping isolation (Stephen Belanger) [#43556](nodejs/node#43556) - \[[`e89e0b470b`](nodejs/node@e89e0b470b)] - **esm**: remove superfluous argument (Rich Trott) [#43884](nodejs/node#43884) - \[[`0d2921f396`](nodejs/node@0d2921f396)] - **esm**: fix erroneous re-initialization of ESMLoader (Jacob Smith) [#43763](nodejs/node#43763) - \[[`9b5b8d78c3`](nodejs/node@9b5b8d78c3)] - **esm**: throw on any non-2xx response (LiviaMedeiros) [#43742](nodejs/node#43742) - \[[`dfc4832ef1`](nodejs/node@dfc4832ef1)] - **(SEMVER-MINOR)** **events**: expose CustomEvent on global with CLI flag (Daeyeon Jeong) [#43885](nodejs/node#43885) - \[[`e4473952ae`](nodejs/node@e4473952ae)] - **(SEMVER-MINOR)** **events**: add `CustomEvent` (Daeyeon Jeong) [#43514](nodejs/node#43514) - \[[`100f6deb09`](nodejs/node@100f6deb09)] - **fs**: use signed types for stat data (LiviaMedeiros) [#43714](nodejs/node#43714) - \[[`25ec71db63`](nodejs/node@25ec71db63)] - **http**: fix http server connection list when close (theanarkh) [#43949](nodejs/node#43949) - \[[`ca658c8afe`](nodejs/node@ca658c8afe)] - **(SEMVER-MINOR)** **http**: add drop request event for http server (theanarkh) [#43806](nodejs/node#43806) - \[[`9c699bd8a8`](nodejs/node@9c699bd8a8)] - **http**: wait for pending responses in closeIdleConnections (Paolo Insogna) [#43890](nodejs/node#43890) - \[[`781d5e54e3`](nodejs/node@781d5e54e3)] - **inspector**: set sampling interval before start (Shelley Vohr) [#43779](nodejs/node#43779) - \[[`0b5dbb2a56`](nodejs/node@0b5dbb2a56)] - **lib**: refactor PriorityQueue to use private field (Finn Yu) [#43889](nodejs/node#43889) - \[[`324473ca32`](nodejs/node@324473ca32)] - **(SEMVER-MINOR)** **lib**: improved diagnostics_channel subscribe/unsubscribe (Stephen Belanger) [#42714](nodejs/node#42714) - \[[`5aa3b213ac`](nodejs/node@5aa3b213ac)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#43966](nodejs/node#43966) - \[[`e707552357`](nodejs/node@e707552357)] - **meta**: update `node-api` in label-pr-config (Daeyeon Jeong) [#43794](nodejs/node#43794) - \[[`8a8de94034`](nodejs/node@8a8de94034)] - **meta**: update AUTHORS (Node.js GitHub Bot) [#43872](nodejs/node#43872) - \[[`7d49fc766c`](nodejs/node@7d49fc766c)] - **meta**: use platform dropdown on flaky template (Rafael Gonzaga) [#43855](nodejs/node#43855) - \[[`e4aa50fc3f`](nodejs/node@e4aa50fc3f)] - **meta**: enable blank issues (Matteo Collina) [#43775](nodejs/node#43775) - \[[`ceb7c150ec`](nodejs/node@ceb7c150ec)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#43770](nodejs/node#43770) - \[[`29bcd47738`](nodejs/node@29bcd47738)] - **net**: fix socket.\_getpeername (Daeyeon Jeong) [#43010](nodejs/node#43010) - \[[`380659daf1`](nodejs/node@380659daf1)] - **process**: use `defineProperty` instead of assignment (Mark S. Miller) [#43907](nodejs/node#43907) - \[[`aba9c8ebea`](nodejs/node@aba9c8ebea)] - **repl**: fix overzealous top-level await (Tobias Nießen) [#43827](nodejs/node#43827) - \[[`1deb6b73b7`](nodejs/node@1deb6b73b7)] - **repl**: use `SafePromiseAll` and `SafePromiseRace` (Antoine du Hamel) [#43758](nodejs/node#43758) - \[[`bf8f2e23ff`](nodejs/node@bf8f2e23ff)] - **src**: refactor DH groups to delete crypto_groups.h (Tobias Nießen) [#43896](nodejs/node#43896) - \[[`9435fbf8cd`](nodejs/node@9435fbf8cd)] - **src**: remove dead code in base64\_encode (Tobias Nießen) [#43979](nodejs/node#43979) - \[[`2c47e58ea0`](nodejs/node@2c47e58ea0)] - **src**: fix regression that a source marker is lost (cola119) [#43086](nodejs/node#43086) - \[[`d084150320`](nodejs/node@d084150320)] - **src**: per-isolate eternal template properties (Chengzhong Wu) [#43802](nodejs/node#43802) - \[[`9f9d00ccbb`](nodejs/node@9f9d00ccbb)] - **src**: merge NativeModuleEnv into NativeModuleLoader (Joyee Cheung) [#43824](nodejs/node#43824) - \[[`bb512904e9`](nodejs/node@bb512904e9)] - **src**: use named struct instead of typedef (Tobias Nießen) [#43881](nodejs/node#43881) - \[[`bb5511e8cc`](nodejs/node@bb5511e8cc)] - **src**: use named enum instead of typedef (Tobias Nießen) [#43880](nodejs/node#43880) - \[[`5db0c8f667`](nodejs/node@5db0c8f667)] - **src**: pass only Isolate\* and env_vars to EnabledDebugList::Parse() (Darshan Sen) [#43668](nodejs/node#43668) - \[[`249365524e`](nodejs/node@249365524e)] - **src**: fix node watchdog race condition (theanarkh) [#43780](nodejs/node#43780) - \[[`17cb27237d`](nodejs/node@17cb27237d)] - **src**: deduplicate `SetALPN` implementations (Tobias Nießen) [#43756](nodejs/node#43756) - \[[`b4c75a96be`](nodejs/node@b4c75a96be)] - **src**: fix `napi_check_object_type_tag()` (Daeyeon Jeong) [#43788](nodejs/node#43788) - \[[`8432d6596f`](nodejs/node@8432d6596f)] - **src**: slim down env-inl.h (Ben Noordhuis) [#43745](nodejs/node#43745) - \[[`2266a4b6d6`](nodejs/node@2266a4b6d6)] - **stream**: improve `respondWithNewView()` (Daeyeon Jeong) [#43866](nodejs/node#43866) - \[[`bf3991b406`](nodejs/node@bf3991b406)] - **stream**: fix 0 transform hwm backpressure (Robert Nagy) [#43685](nodejs/node#43685) - \[[`a057510037`](nodejs/node@a057510037)] - **stream**: initial approach to include strategy options on Readable.toWeb() (txxnano) [#43515](nodejs/node#43515) - \[[`198cf59d2c`](nodejs/node@198cf59d2c)] - **test**: update WPT encoding tests (Kohei Ueno) [#43958](nodejs/node#43958) - \[[`f0ed1aed8d`](nodejs/node@f0ed1aed8d)] - **test**: remove test-whatwg-events-add-event-listener-options-once.js (Feng Yu) [#43877](nodejs/node#43877) - \[[`88505556fe`](nodejs/node@88505556fe)] - **test**: work scheduled in process.nextTick can keep the event loop alive (Andreu Botella) [#43787](nodejs/node#43787) - \[[`81a21946eb`](nodejs/node@81a21946eb)] - **test**: simplify test-tls-set-secure-context (Tobias Nießen) [#43878](nodejs/node#43878) - \[[`61cd11a8a7`](nodejs/node@61cd11a8a7)] - **test**: use `common.mustNotMutateObjectDeep()` in fs tests (LiviaMedeiros) [#43819](nodejs/node#43819) - \[[`b1081dbe12`](nodejs/node@b1081dbe12)] - **test**: fix test http upload timeout (theanarkh) [#43935](nodejs/node#43935) - \[[`efd5e0e925`](nodejs/node@efd5e0e925)] - **test**: simplify ReplStream.wait() (Tobias Nießen) [#43857](nodejs/node#43857) - \[[`ef21ad2996`](nodejs/node@ef21ad2996)] - **test**: merge test-crypto-dh-hash with modp18 test (Tobias Nießen) [#43891](nodejs/node#43891) - \[[`e502c50a90`](nodejs/node@e502c50a90)] - **test**: refactor `test/es-module/test-esm-resolve-type` (Antoine du Hamel) [#43178](nodejs/node#43178) - \[[`c782c3dc69`](nodejs/node@c782c3dc69)] - **test**: ensure NODE_EXTRA_CA_CERTS not set before tests (KrayzeeKev) [#43858](nodejs/node#43858) - \[[`bb6787cb57`](nodejs/node@bb6787cb57)] - **test**: add check to test-fs-readfile-tostring-fail (Richard Lau) [#43850](nodejs/node#43850) - \[[`7571704186`](nodejs/node@7571704186)] - **test**: complete TODO in test/wpt/test-url.js (Kohei Ueno) [#43797](nodejs/node#43797) - \[[`6f1d2dfb9d`](nodejs/node@6f1d2dfb9d)] - **test**: add test on worker process.exit in async modules (Chengzhong Wu) [#43751](nodejs/node#43751) - \[[`776cc3abbd`](nodejs/node@776cc3abbd)] - **test**: use `common.mustNotMutateObjectDeep()` in immutability tests (LiviaMedeiros) [#43196](nodejs/node#43196) - \[[`42f2deb3a0`](nodejs/node@42f2deb3a0)] - **test**: add `common.mustNotMutateObjectDeep()` (LiviaMedeiros) [#43196](nodejs/node#43196) - \[[`f3fc51c508`](nodejs/node@f3fc51c508)] - **test**: fix coverity warning in test (Michael Dawson) [#43631](nodejs/node#43631) - \[[`a9ecba2fa8`](nodejs/node@a9ecba2fa8)] - **test**: mark test-http-client-response-timeout flaky (Tobias Nießen) [#43792](nodejs/node#43792) - \[[`cd0d9ddb7c`](nodejs/node@cd0d9ddb7c)] - **test_runner**: add support for boolean values for `concurrency` option (Lenvin Gonsalves) [#43887](nodejs/node#43887) - \[[`f98020138a`](nodejs/node@f98020138a)] - **test_runner**: validate `timeout` option (Antoine du Hamel) [#43843](nodejs/node#43843) - \[[`58d15b3687`](nodejs/node@58d15b3687)] - **test_runner**: pass signal on timeout (Moshe Atlow) [#43911](nodejs/node#43911) - \[[`8b0248506f`](nodejs/node@8b0248506f)] - **test_runner**: do not report an error when tests are passing (Antoine du Hamel) [#43919](nodejs/node#43919) - \[[`aa8053e1fa`](nodejs/node@aa8053e1fa)] - **test_runner**: recieve and pass AbortSignal (Moshe Atlow) [#43554](nodejs/node#43554) - \[[`f13e4c1be9`](nodejs/node@f13e4c1be9)] - **test_runner**: fix `it` concurrency (Moshe Atlow) [#43757](nodejs/node#43757) - \[[`e404a3ef6d`](nodejs/node@e404a3ef6d)] - **test_runner**: support timeout for tests (Moshe Atlow) [#43505](nodejs/node#43505) - \[[`f28198cc05`](nodejs/node@f28198cc05)] - **test_runner**: catch errors thrown within `describe` (Moshe Atlow) [#43729](nodejs/node#43729) - \[[`bfe0ac6cd0`](nodejs/node@bfe0ac6cd0)] - **tools**: add more options to track flaky tests (Antoine du Hamel) [#43954](nodejs/node#43954) - \[[`17a4e5e775`](nodejs/node@17a4e5e775)] - **tools**: add verbose flag to inactive TSC finder (Rich Trott) [#43913](nodejs/node#43913) - \[[`373304b0c7`](nodejs/node@373304b0c7)] - **tools**: add support for using API key to vuln checking script (Facundo Tuesca) [#43909](nodejs/node#43909) - \[[`ed45088c14`](nodejs/node@ed45088c14)] - **tools**: support versioned node shared libs on z/OS (alexcfyung) [#42256](nodejs/node#42256) - \[[`c9ecd6d21f`](nodejs/node@c9ecd6d21f)] - **tools**: update doc to highlight.js@11.6.0 (Node.js GitHub Bot) [#43870](nodejs/node#43870) - \[[`c92135aa0f`](nodejs/node@c92135aa0f)] - **tools**: update lint-md-dependencies to rollup@2.77.0 (Node.js GitHub Bot) [#43871](nodejs/node#43871) - \[[`e12bf40fd1`](nodejs/node@e12bf40fd1)] - **tools**: update eslint to 8.20.0 (Node.js GitHub Bot) [#43873](nodejs/node#43873) - \[[`09fe9b30a9`](nodejs/node@09fe9b30a9)] - **tools**: add script for vulnerability checking (Facundo Tuesca) [#43362](nodejs/node#43362) - \[[`19e8876877`](nodejs/node@19e8876877)] - **trace_events**: trace net connect event (theanarkh) [#43903](nodejs/node#43903) - \[[`1af7f24143`](nodejs/node@1af7f24143)] - **util**: remove unicode support todo for perf implications (Rhys) [#43762](nodejs/node#43762) - \[[`acfc33ca8c`](nodejs/node@acfc33ca8c)] - **(SEMVER-MINOR)** **util**: add tokens to parseArgs (John Gee) [#43459](nodejs/node#43459) - \[[`f32aec8a6d`](nodejs/node@f32aec8a6d)] - **util**: refactor to use validateObject (Kohei Ueno) [#43769](nodejs/node#43769) - \[[`d7cfd0c5ba`](nodejs/node@d7cfd0c5ba)] - **v8**: serialize BigInt64Array and BigUint64Array (Ben Noordhuis) [#43571](nodejs/node#43571)

PR-URL: nodejs#43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

PR-URL: nodejs/node#43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

nodejs-github-bot added cluster Issues and PRs related to the cluster subsystem. needs-ci PRs that need a full CI run. labels Jul 9, 2022

theanarkh changed the title ~~cluster: send the connection to other server when the worker can not accept it.~~ cluster: send or handle later instead of closing it when the worker can not accept a connection Jul 9, 2022

theanarkh force-pushed the send_connection_to_other_server_when_worker_drop_it branch from a80b8de to b1c820d Compare July 9, 2022 21:31

mcollina approved these changes Jul 13, 2022

View reviewed changes

ShogunPanda approved these changes Jul 13, 2022

View reviewed changes

This was referenced Jul 14, 2022

CI Reliability 2022-07-14 nodejs/reliability#322

Open

CI Reliability 2022-07-15 nodejs/reliability#323

Open

F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 16, 2022

theanarkh force-pushed the send_connection_to_other_server_when_worker_drop_it branch from b1c820d to 869dc60 Compare July 16, 2022 10:14

F3n67u added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 17, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 17, 2022

mcollina approved these changes Jul 18, 2022

View reviewed changes

This was referenced Jul 19, 2022

CI Reliability 2022-07-19 nodejs/reliability#325

Open

CI Reliability 2022-07-20 nodejs/reliability#326

Open

CI Reliability 2022-07-21 nodejs/reliability#327

Open

github-actions bot mentioned this pull request Jul 22, 2022

CI Reliability 2022-07-22 nodejs/reliability#328

Open

15 tasks

theanarkh force-pushed the send_connection_to_other_server_when_worker_drop_it branch from 869dc60 to 0a174aa Compare July 22, 2022 20:05

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 23, 2022

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 23, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 23, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jul 23, 2022

mcollina approved these changes Jul 23, 2022

View reviewed changes

github-actions bot mentioned this pull request Jul 24, 2022

CI Reliability 2022-07-24 nodejs/reliability#330

Open

17 tasks

F3n67u added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 24, 2022

nodejs-github-bot merged commit c7ac42f into nodejs:main Jul 24, 2022

This was referenced Jul 25, 2022

CI Reliability 2022-07-25 nodejs/reliability#331

Open

CI Reliability 2022-07-26 nodejs/reliability#332

Open

danielleadams pushed a commit that referenced this pull request Jul 26, 2022

cluster: send connection to other server when worker drop it

7b276b8

PR-URL: #43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

danielleadams mentioned this pull request Jul 26, 2022

v18.7.0 proposal #43993

Merged

github-actions bot mentioned this pull request Jul 27, 2022

CI Reliability 2022-07-27 nodejs/reliability#333

Open

16 tasks

targos pushed a commit that referenced this pull request Jul 31, 2022

cluster: send connection to other server when worker drop it

efcf64d

PR-URL: #43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

targos pushed a commit that referenced this pull request Jul 31, 2022

cluster: send connection to other server when worker drop it

e297afb

PR-URL: #43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

targos pushed a commit that referenced this pull request Aug 1, 2022

cluster: send connection to other server when worker drop it

fe57e56

PR-URL: #43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022

cluster: send connection to other server when worker drop it

5ad8792

PR-URL: nodejs#43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022

cluster: send connection to other server when worker drop it

dd01c45

PR-URL: nodejs/node#43747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cluster: send or handle later instead of closing it when the worker can not accept a connection #43747

cluster: send or handle later instead of closing it when the worker can not accept a connection #43747

theanarkh commented Jul 9, 2022 •

edited

Loading

theanarkh commented Jul 13, 2022

mcollina left a comment

nodejs-github-bot commented Jul 13, 2022

ShogunPanda left a comment

nodejs-github-bot commented Jul 17, 2022

nodejs-github-bot commented Jul 17, 2022

mcollina left a comment

nodejs-github-bot commented Jul 18, 2022

nodejs-github-bot commented Jul 21, 2022

nodejs-github-bot commented Jul 22, 2022

theanarkh commented Jul 22, 2022 •

edited

Loading

theanarkh commented Jul 22, 2022

nodejs-github-bot commented Jul 23, 2022

nodejs-github-bot commented Jul 23, 2022

nodejs-github-bot commented Jul 23, 2022

theanarkh commented Jul 23, 2022 •

edited

Loading

mcollina commented Jul 23, 2022

theanarkh commented Jul 23, 2022

mcollina left a comment

nodejs-github-bot commented Jul 24, 2022

cluster: send or handle later instead of closing it when the worker can not accept a connection #43747

cluster: send or handle later instead of closing it when the worker can not accept a connection #43747

Conversation

theanarkh commented Jul 9, 2022 • edited Loading

theanarkh commented Jul 13, 2022

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 13, 2022

ShogunPanda left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 17, 2022

nodejs-github-bot commented Jul 17, 2022

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 18, 2022

nodejs-github-bot commented Jul 21, 2022

nodejs-github-bot commented Jul 22, 2022

theanarkh commented Jul 22, 2022 • edited Loading

theanarkh commented Jul 22, 2022

nodejs-github-bot commented Jul 23, 2022

nodejs-github-bot commented Jul 23, 2022

nodejs-github-bot commented Jul 23, 2022

theanarkh commented Jul 23, 2022 • edited Loading

mcollina commented Jul 23, 2022

theanarkh commented Jul 23, 2022

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Jul 24, 2022

theanarkh commented Jul 9, 2022 •

edited

Loading

theanarkh commented Jul 22, 2022 •

edited

Loading

theanarkh commented Jul 23, 2022 •

edited

Loading