Skip to content

http: add drop request event for http server #43806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jul 22, 2022
Merged

http: add drop request event for http server #43806

nodejs-github-bot merged 1 commit into from
Jul 22, 2022

Conversation

@theanarkh
Copy link
Contributor

@theanarkh theanarkh commented Jul 12, 2022 •
edited
Loading

Add dropRequest event for http server to notify user when the number of requests on a socket reaches the threshold of
server.maxRequestsPerSocket.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected subsystem: http

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 12, 2022

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 12, 2022
mcollina
mcollina reviewed Jul 13, 2022
View reviewed changes
@theanarkh theanarkh force-pushed the add_drop_request_event_for_http_server branch from c6d3d0e to 99c2e43 Compare July 13, 2022 12:50
F3n67u
F3n67u suggested changes Jul 13, 2022
View reviewed changes
F3n67u
F3n67u reviewed Jul 13, 2022
View reviewed changes
mcollina
mcollina approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@theanarkh theanarkh force-pushed the add_drop_request_event_for_http_server branch 2 times, most recently from 034a24b to 57d8d36 Compare July 13, 2022 15:04
@F3n67u F3n67u added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 13, 2022
lpinca
lpinca reviewed Jul 13, 2022
View reviewed changes
@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 13, 2022
@theanarkh theanarkh force-pushed the add_drop_request_event_for_http_server branch from 57d8d36 to 5adb5e7 Compare July 13, 2022 18:52
lpinca
lpinca reviewed Jul 13, 2022
View reviewed changes
@F3n67u F3n67u removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 14, 2022
@theanarkh theanarkh force-pushed the add_drop_request_event_for_http_server branch from 5adb5e7 to e5b408c Compare July 14, 2022 14:11
@F3n67u F3n67u added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 16, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 16, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45470/

@theanarkh
Copy link
Contributor Author

theanarkh commented Jul 18, 2022 •
edited
Loading

@mcollina Hi. Can you help trigger CI again? Thanks!

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 18, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45519/

This was referenced Jul 19, 2022
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45590/

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 22, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 22, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0592d91 into nodejs:main Jul 22, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2022

Landed in 0592d91

@github-actions github-actions bot mentioned this pull request Jul 23, 2022
Open
15 tasks
@danielleadams danielleadams mentioned this pull request Jul 26, 2022
Merged
@targos targos mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca left review comments

@mcollina mcollina mcollina approved these changes

+1 more reviewer

@F3n67u F3n67u F3n67u approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theanarkh @nodejs-github-bot @mcollina @lpinca @F3n67u