Skip to content

Commit 380659d

Browse files
erightsdanielleadams
authored andcommitted
process: use defineProperty instead of assignment
PR-URL: #43907 Fixes: #43496 Refs: endojs/endo#576 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
1 parent bbc455c commit 380659d

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

lib/internal/process/per_thread.js

+10-3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ const {
1515
Float64Array,
1616
NumberMAX_SAFE_INTEGER,
1717
ObjectFreeze,
18+
ObjectDefineProperty,
1819
ReflectApply,
1920
RegExpPrototypeExec,
2021
SafeArrayIterator,
@@ -371,9 +372,15 @@ function buildAllowedFlags() {
371372
return SetPrototypeValues(this[kInternal].set);
372373
}
373374
}
374-
NodeEnvironmentFlagsSet.prototype.keys =
375-
NodeEnvironmentFlagsSet.prototype[SymbolIterator] =
376-
NodeEnvironmentFlagsSet.prototype.values;
375+
const flagSetValues = NodeEnvironmentFlagsSet.prototype.values;
376+
ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, SymbolIterator, {
377+
__proto__: null,
378+
value: flagSetValues,
379+
});
380+
ObjectDefineProperty(NodeEnvironmentFlagsSet.prototype, 'keys', {
381+
__proto__: null,
382+
value: flagSetValues,
383+
});
377384

378385
ObjectFreeze(NodeEnvironmentFlagsSet.prototype.constructor);
379386
ObjectFreeze(NodeEnvironmentFlagsSet.prototype);

0 commit comments

Comments
 (0)