Skip to content

Commit

Permalink
util: remove unicode support todo for perf implications
Browse files Browse the repository at this point in the history
PR-URL: #43762
Refs: #43721
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
Anemy authored and danielleadams committed Jul 26, 2022
1 parent bf3991b commit 1af7f24
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions lib/internal/util/inspect.js
Original file line number Diff line number Diff line change
Expand Up @@ -1596,8 +1596,9 @@ function formatPrimitive(fn, value, ctx) {
trailer = `... ${remaining} more character${remaining > 1 ? 's' : ''}`;
}
if (ctx.compact !== true &&
// TODO(BridgeAR): Add unicode support. Use the readline getStringWidth
// function.
// We do not support handling unicode characters width with
// the readline getStringWidth function as there are
// performance implications.
value.length > kMinLineLength &&
value.length > ctx.breakLength - ctx.indentationLvl - 4) {
return value
Expand Down

0 comments on commit 1af7f24

Please sign in to comment.