v16.13.1 proposal #40974
Merged
v16.13.1 proposal #40974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #40307 Reviewed-By: Mary Marchini <oss@mmarchini.me>
Update lint-md dependencies and re-create lint-md.mjs. PR-URL: #40404 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Add a .mailmap entry for evantorrie to consolidate their two AUTHORS entries into one. PR-URL: #40430 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
This is useful information to have for applications that don't need to read the other properties. The implementation checks for `nullptr`, see: https://github.com/nodejs/node/blob/master/src/js_native_api_v8.cc#L2879 PR-URL: #40371 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #40401 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40456 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
PR-URL: #40447 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40405 Refs: electron/electron#31349 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #40465 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Only query embedder options when they are needed so that the bootstrap remains as stateless as possible so that the bootstrap snapshot is controlled solely by configure options, and subsequent runtime changes should be done in pre-execution. PR-URL: #40357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: #40445 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
OpenSSL 3.0 increased the minimum values for these parameters. PR-URL: #40416 Fixes: #40410 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
PR-URL: #40469 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #40485 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #40494 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This missing initialization was reported by the coverity scans we are in the process of re-enabling. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40379 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Split test-crypto-dh.js so that it is less likely to timeout on less powerful bots. PR-URL: #40451 Refs: nodejs/reliability#86 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Coverity scan reported a free after use and I think its right. Tweak to avoid double free. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #40380 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Add standard timezone name for Dublin without daylight saving PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
test-benchmark-buffer is consistently timing out on a single Windows host in CI. Rather than try to figure out if we need to scale the timeout up for a certain memory limit or chip speed or something else, let's increase the timeout for benchmark tests in general. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
The win10-COMPILED_BY-vs2019 hosts in CI are very slow and timing out on certain tests in pummel and (previously) benchmark. Increase timeout from 4x to 6x. PR-URL: #40684 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
PR-URL: #39924 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
`url.idl` defines URL's constructor as: ``` constructor(USVString url, optional USVString base); ``` `idlharness.any.js` checks its length as `1`. So we should remove constructor's second argument and use `arguments[1]` in constructor's logic. Refs: https://url.spec.whatwg.org/#idl-index PR-URL: #39848 Backport-PR-URL: #40383 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Are you still working on the notable changes? |
BethGriggs
force-pushed
the
v16.13.1-proposal
branch
from
f369577
to
5bd3d16
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
For #40660 feel free to borrow the notable changes from the v14.18.2 changelog (but adjusting 14.17.5 to 16.6.2 as the release where the regression was introduced). |
BethGriggs
added a commit
that referenced
this pull request
Nov 30, 2021
Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [#40643](#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [#40660](#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [#40566](#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [#40325](#40325) PR-URL: #40974
BethGriggs
force-pushed
the
v16.13.1-proposal
branch
from
5bd3d16
to
88cfa36
Compare
richardlau
approved these changes
Nov 30, 2021
|
A couple of new CITGM failures have appeared in the latest runs, as such I'd like to defer until tomorrow AM to investigate. I'll push an update changing only the date. |
Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [#40643](#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [#40660](#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [#40566](#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [#40325](#40325) PR-URL: #40974
BethGriggs
force-pushed
the
v16.13.1-proposal
branch
from
88cfa36
to
12029ce
Compare
|
Diagnosed the new CITGM failures as issues in the modules (which are now fixed in new versions). |
|
Release build on 12029ce: https://ci-release.nodejs.org/job/iojs+release/8113 |
BethGriggs
added a commit
that referenced
this pull request
Dec 1, 2021
Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [#40643](#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [#40660](#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [#40566](#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [#40325](#40325) PR-URL: #40974
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Dec 1, 2021
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Dec 1, 2021
This was referenced Dec 3, 2021
I just noticed it now. Too bad #40741 was not included. Can you backport it for next v16 release? |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Notable changes: - **deps**: upgrade npm to 8.1.2 (npm team) [nodejs#40643](nodejs#40643) - **deps**: update c-ares to 1.18.1 (Richard Lau) [nodejs#40660](nodejs#40660) - **doc**: add VoltrexMaster to collaborators (voltrexmaster) [nodejs#40566](nodejs#40566) - **lib**: fix regular expression to detect \`/\` and \`\\\` (Francesco Trotta) [nodejs#40325](nodejs#40325) PR-URL: nodejs#40974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2021-11-30, Version 16.13.1 'Gallium' (LTS), @BethGriggs
Notable Changes
c14eb2325d] - deps: upgrade npm to 8.1.2 (npm team) #40643a901b6c53c] - deps: update c-ares to 1.18.1 (Richard Lau) #40660755c08573f] - doc: add VoltrexMaster to collaborators (voltrexmaster) #40566881dd7ba2a] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #40325Commits
996bc6e840] - benchmark: increase crypto DSA keygen params (Brian White) #4041627009092c8] - build: skip long-running Actions for README-only modifications (Rich Trott) #405714581997ed0] - build: disable v8 pointer compression on 32bit archs (Cheng Zhao) #4041817433060d4] - build: fix actions pull request's branch (Mestery) #40494bfdd32fa62] - build: avoid run find inactive authors on forked repo (Jiawen Geng) #40465134e8afc59] - build: update codeowners-validator to 0.6 (FrankQiu) #40307de125a556c] - crypto: avoid double free (Michael Dawson) #40380c14eb2325d] - deps: upgrade npm to 8.1.2 (npm team) #40643a901b6c53c] - deps: update c-ares to 1.18.1 (Richard Lau) #4066076e2c3769e] - deps: upgrade npm to 8.1.1 (npm team) #4055491c3cf5d0a] - deps: V8: cherry-pick 422dc378a1da (Ray Wang) #40450769336ab8c] - deps: add riscv64 config into openssl gypi (Lu Yahan) #4047376d1b5d868] - deps: patch V8 to 9.4.146.24 (Michaël Zasso) #4061623d11a1dd9] - dgram: fix send with out of bounds offset + length (Nitzan Uziely) #4056845bdc77dc0] - doc: update cjs-module-lexer repo link (Guy Bedford) #40707de5c5c8509] - doc: remove--experimental-modulesdocumentation (FrankQiu) #38974befac5ddd9] - doc: update tracking issues of startup performance (Joyee Cheung) #406293cb74d72f8] - doc: fix markdown syntax and HTML tag misses (ryan) #40608eea061f8f1] - doc: use 'GitHub Actions workflow' instead (Mestery) #405867a6e833677] - doc: add node: url scheme (Daniel Nalborczyk) #40573d72fb7df4a] - doc: call cwd function (Daniel Nalborczyk) #40573d732ff4614] - doc: remove unused imports (Daniel Nalborczyk) #40573e2114e21f4] - doc: add info on project's usage of coverity (Michael Dawson) #40506d38077babe] - doc: fix typo in changelogs (Luigi Pinca) #405857c7f8791c6] - doc: update onboarding task (Rich Trott) #405700a7c4ff248] - doc: simplify ccache instructions (Rich Trott) #405505593dd1b25] - doc: fix macOS environment variables for ccache (Rich Trott) #405502d4a042675] - doc: improve async_context introduction (Michaël Zasso) #405609fcfef09ac] - doc: use GFM footnotes in webcrypto.md (Rich Trott) #40477579f01c0a3] - doc: describe buffer limit of v8.serialize (Ray Wang) #402433b6cf090a0] - doc: use GFM footnotes in maintaining-V8.md (doc: use GFM footnotes in maintaining-V8.md #40476) (Rich Trott) #40476dea701004e] - doc: fixfs.symlinkcode example (Juan José Arboleda) #40414595117ff0b] - doc: explain backport labels (Stephen Belanger) #40520042f01e3ed] - doc: fix entry for Slack channel in onboarding.md (Rich Trott) #40563755c08573f] - doc: add VoltrexMaster to collaborators (voltrexmaster) #40566c029d0b61f] - doc: document considerations for inclusion in core (Rich Trott) #40338836fc274e4] - Revert "doc: fix typo in stream docs" (Luigi Pinca) #40819b3a12767a4] - doc: update link in onboarding doc (Rich Trott) #40539aa47c9f38f] - doc: clarify behavior of napi_extended_error_info (Michael Dawson) #40458bf88328bdc] - doc: add updating expected assets to release guide (Richard Lau) #40470621266afc7] - doc: format doc/api/*.md with markdown formatter (Rich Trott) #404037b746381ce] - doc: specify that maxFreeSockets is per host (Luigi Pinca) #40483934dcc85c3] - doc: update Collaborator guide to reflect GitHub web UI update (Antoine du Hamel) #404564724e07476] - doc: indicate n-api out params that may be NULL (Isaac Brodsky) #403713b1499c971] - doc: update CHANGELOG.md for Node.js 16.13.0 (Richard Lau) #40617881dd7ba2a] - lib: fix regular expression to detect `/` and `\` (Francesco Trotta) #403250a8c33123e] - lib,url: correct URL's argument to pass idlharness (Khaidi Chu) #39848480f0e1d20] - meta: use form schema for flaky test template (Michaël Zasso) #4073755ff97342d] - meta: update AUTHORS (Node.js GitHub Bot) #40668ef46cb428d] - meta: consolidate AUTHORS entries for brettkiefer (Rich Trott) #405997230b6d33d] - meta: consolidate AUTHORS entries for alexzherdev (Rich Trott) #406209e12ed4f68] - meta: consolidate AUTHORS entries for Azard (Rich Trott) #4061997aa8e42b8] - meta: move Fishrock123 to emeritus (Jeremiah Senkpiel) #405967b1c89f357] - meta: consolidate AUTHORS entries for clakech (Rich Trott) #405890003cb6b3b] - meta: consolidate AUTHORS entries for darai0512 (Rich Trott) #405697590bacec1] - meta: update AUTHORS (Node.js GitHub Bot) #40580a5475df083] - meta: consolidate AUTHORS entries for dfabulich (Rich Trott) #40527c021a7f169] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #40464d64cf1706c] - meta: add Richard Lau to TSC list in README.md (Rich Trott) #40523d09b8239bf] - meta: consolidate AUTHORS entries for dguo (Rich Trott) #4051766192060e7] - meta: consolidate AUTHORS entries for cxreg (Rich Trott) #40490b4f51276cb] - meta: update AUTHORS (Node.js GitHub Bot) #404852a2b549a28] - meta: consolidate AUTHORS entries for emanuelbuholzer (Rich Trott) #40469618bbbf2f4] - meta: consolidate AUTHORS entries for ebickle (Rich Trott) #4044706706e8dd2] - meta: addtypingsto label-pr-config (Mestery) #40401e2c9e1ccdd] - meta: consolidate AUTHORS entries for evantorrie (Rich Trott) #40430dab574e937] - policy: fix message for invalid manifest specifier (Rich Trott) #4057458de6cebb6] - process: refactor execution (Voltrex) #40664bc0eb0a3ea] - src: make LoadEnvironment with string work with builtin modules path (Michaël Zasso) #406072c8a6ec28e] - src: remove usage ofAllocatedBufferfromnode_http2(Darshan Sen) #4058459c26a2b2c] - src: fix #endif description in crypto_keygen.h (Tobias Nießen) #40639789fef1309] - src: throw error instead of assertion (Ray Wang) #402437a8a6deee7] - src: register external references in os bindings (Joyee Cheung) #402397bb3d43432] - src: register external references in crypto bindings (Joyee Cheung) #40239143c881ccb] - src: add missing inialization in agent.h (Michael Dawson) #40379c15afda79f] - src: get embedder options on-demand (Joyee Cheung) #40357ff3b7d228e] - src: ensure V8 initialized before marking milestone (Shelley Vohr) #40405774bc46327] - src,crypto: removeAllocatedBufferfromcrypto_cipher.cc(Darshan Sen) #404004030eff3d6] - src,fs: removeToLocalChecked()call fromfs::AfterMkdirp()(Darshan Sen) #403863ac99a2417] - src,stream: remove*Check*()calls from non-Initialize()functions (Darshan Sen) #4042536d3b123a0] - stream: support array of streams in promises pipeline (Mestery) #4019301ffe0316c] - test: deflake child-process-pipe-dataflow (Luigi Pinca) #4083863b44fc429] - test: skip macos sandbox test with builtin modules path (Michaël Zasso) #406073d50997ccb] - test: add semicolon after chunk size (Luigi Pinca) #40487f114e35115] - test: deflake http2-cancel-while-client-reading (Luigi Pinca) #40659f778fa230b] - test: testcrypto.setEngine()using an actual engine (Darshan Sen) #40481b9533c592a] - test: use conventional argument order in assertion (Tobias Nießen) #40591e72c95c580] - test: fix test description (Luigi Pinca) #40486af4e682758] - test: pass URL's toascii.window.js WPT (Khaidi Chu) #399106de88bc5ed] - test: adjust CLI flags test to ignore blank lines in doc (Rich Trott) #404038226690097] - test: mark test-policy-integrity flaky on Windows (Rich Trott) #4068450c6666b37] - test: fix test-datetime-change-notify after daylight change (Piotr Rybak) #406849227f2af79] - test: split test-crypto-dh.js (Joyee Cheung) #40451c593cff0af] - test,doc: correct documentation for runBenchmark() (Rich Trott) #40683aef809f5c8] - test,tools: increase pummel/benchmark test timeout from 4x to 6x (Rich Trott) #40684908f6447cd] - test,tools: increase timeout for benchmark tests (Rich Trott) #4068464c6575f44] - tools: simplify and fix commit queue (Michaël Zasso) #40742cba8eaf264] - tools: ensure the PR was not pushed before merging (Antoine du Hamel) #407471c8590e1fe] - tools: update ESLint to 8.2.0 (Luigi Pinca) #4073418800dee0a] - tools: use GitHub Squash and Merge feature when using CQ (Antoine du Hamel) #4066648a785edb7] - tools: fix bug inprefer-primordialsESLint rule (Antoine du Hamel) #40628adde2a7a8c] - tools: add script to update c-ares (Richard Lau) #40660c12ce898e8] - tools: abort CQ session when landing several commits (Antoine du Hamel) #40577dd08e532a2] - tools: fix commit-lint workflow (Antoine du Hamel) #40673b4a80dba79] - tools: avoid fetch extra commits when validating commit messages (Antoine du Hamel) #391282a53995442] - tools: update ESLint to 8.1.0 (Luigi Pinca) #405828648e50183] - tools: fix formatting of warning message in update-authors.js (Rich Trott) #4060059de0f703f] - tools: udpate doc tools to accommodate GFM footnotes (Rich Trott) #40477abf3b84d77] - tools: add support for import assertions in linter (Antoine du Hamel) #3992404c2cbecb9] - tools: update tools/lint-md dependencies to support GFM footnotes (Rich Trott) #40445a9990876f7] - tools: update lint-md dependencies (Rich Trott) #40404f45814bad1] - tools,meta: remove exclusions from AUTHORS (Rich Trott) #406487d550ad966] - tty: support more CI services ingetColorDepth(Richie Bendall) #40385cdea5b671b] - typings: add more bindings typings (Mestery) #4041567c7d11f1a] - typings: add JSDoc typings for inspector (Voltrex) #38390fbe0323ebf] - typings: improve internal bindings typings (Mestery) #4041163ab0031c3] - typings: separateinternalBindingtypings (Mestery) #40409