Skip to content

Commit

Permalink
doc: use GFM footnotes in maintaining-V8.md (#40476)
Browse files Browse the repository at this point in the history
PR-URL: #40476
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and BethGriggs committed Nov 24, 2021
1 parent dea7010 commit 3b6cf09
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions doc/guides/maintaining-V8.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ documented [on the V8 wiki][V8MergingPatching]. The summary of the process is:

At any given time Node.js needs to be maintaining a few different V8 branches
for the various Current, LTS, and nightly releases. At present this list
includes the following branches<sup>1</sup>:
includes the following branches:[^1]

<table>
<tr>
Expand Down Expand Up @@ -222,7 +222,7 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change.
* Run the Node.js [V8 CI][] in addition to the [Node.js CI][].
The CI uses the `test-v8` target in the `Makefile`, which uses
`tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to
run V8 tests<sup>2</sup>.
run V8 tests.[^2]

The [`git-node`][] tool can be used to simplify this task. Run
`git node v8 backport <sha>` to cherry-pick a commit.
Expand Down Expand Up @@ -404,17 +404,13 @@ This would require some tooling to:
promoted from `nodejs/v8` to `nodejs/node`.
* Enabled the V8-CI build in Jenkins to build from the `nodejs/v8` fork.

<!-- Footnotes themselves at the bottom. -->
[^1]: Node.js 0.12 and older are intentionally omitted from this document
as their support has ended.

### Notes

<sup>1</sup>Node.js 0.12 and older are intentionally omitted from this document
as their support has ended.

<sup>2</sup>The V8 tests still require Python 2. To run these tests locally,
you can run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
of this repository. On macOS, this also requires a full Xcode install,
not just the "command line tools" for Xcode.
[^2]: The V8 tests still require Python 2. To run these tests locally, you can
run `PYTHON2 ./configure.py` before running `make test-v8`, in the root
of this repository. On macOS, this also requires a full Xcode install,
not just the "command line tools" for Xcode.

[ChromiumReleaseCalendar]: https://www.chromium.org/developers/calendar
[Node.js CI]: https://ci.nodejs.org/job/node-test-pull-request/
Expand Down

0 comments on commit 3b6cf09

Please sign in to comment.