Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: specify that maxFreeSockets is per host #40483

Closed
wants to merge 1 commit into from
Closed

doc: specify that maxFreeSockets is per host #40483

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Oct 16, 2021 •
edited
Loading

The maxFreeSockets option specifies the maximum number of free
sockets per host.

Fixes: #40446

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Oct 16, 2021
@lpinca
doc: specify that maxFreeSockets is per host
1faecd2 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

Fixes: nodejs#40446
@Mesteery Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2021
@lpinca
Copy link
Member Author

lpinca commented Oct 19, 2021

Landed in 78e8f08.

lpinca added a commit that referenced this pull request Oct 19, 2021
@lpinca
doc: specify that maxFreeSockets is per host
78e8f08 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@lpinca lpinca closed this Oct 19, 2021
@lpinca lpinca deleted the fix/issue-40446 branch October 19, 2021 18:20
targos pushed a commit that referenced this pull request Oct 20, 2021
@lpinca @targos
doc: specify that maxFreeSockets is per host
977016a 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Oct 20, 2021
Merged
targos pushed a commit that referenced this pull request Nov 4, 2021
@lpinca @targos
doc: specify that maxFreeSockets is per host
7b74638 
The `maxFreeSockets` option specifies the maximum number of free
sockets per host.

PR-URL: #40483
Fixes: #40446
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: documentation should mention that maxFreeSockets is per host
5 participants
@lpinca @benjamingr @cjihrig @nodejs-github-bot @Mesteery