benchmark: increase crypto DSA keygen params #40416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
crypto
targos
approved these changes
Oct 12, 2021
Mesteery
added
the
author ready
Lxxyx
approved these changes
Oct 12, 2021
lpinca
approved these changes
Oct 12, 2021
richardlau
approved these changes
Oct 12, 2021
This comment has been minimized.
This comment has been minimized.
tniessen
approved these changes
Oct 13, 2021
This was referenced Oct 14, 2021
This comment has been minimized.
This comment has been minimized.
mscdex
force-pushed
the
benchmark-crypto-fix-error
branch
from
9a616c1 to
282d1e1
Compare
OpenSSL 3.0 increased the minimum values for these parameters. PR-URL: nodejs#40416 Fixes: nodejs#40410 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
mscdex
force-pushed
the
benchmark-crypto-fix-error
branch
from
282d1e1 to
ed01811
Compare
This was referenced Oct 17, 2021
2 tasks
This was referenced Oct 19, 2021
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
OpenSSL 3.0 increased the minimum values for these parameters. PR-URL: #40416 Fixes: #40410 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.0 increased the minimum values for these parameters.
Fixes: #40410