Merged
Conversation
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
nodejs-github-bot
added
the
meta
Trott
approved these changes
Nov 1, 2021
aduh95
force-pushed
the
debug-commit-lint
branch
from
d66b5f7 to
bc567a8
Compare
PR-URL: nodejs#40673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
debug-commit-lint
branch
from
bc567a8 to
14825d6
Compare
Contributor
Author
|
Landed in 14825d6 |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40673 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that #39128 broke something. If I understand correctly, depending on when the PR has diverged from the base branch, git may be incapable of computing the
${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}commit range. Instead we can specify how many commits there are in the PR since it's an information we already have anyway.