-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release proposal: v4.1.2 #3127
Release proposal: v4.1.2 #3127
Commits on Aug 31, 2015
-
doc: add TSC meeting minutes 2015-08-26
PR-URL: nodejs#2591 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 07019b6 - Browse repository at this point
Copy the full SHA 07019b6View commit details
Commits on Sep 2, 2015
-
test: unmark test-process-argv-0.js as flaky
nodejs#2541 fixed flakiness in test-process-argv-0.js. However, it was not removed from the list of flaky tests. This removes it from the list of flaky tests. PR-URL: nodejs#2613 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c4ec1d2 - Browse repository at this point
Copy the full SHA c4ec1d2View commit details -
doc: add TSC meeting minutes 2015-08-12
PR-URL: nodejs#2438 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 499321f - Browse repository at this point
Copy the full SHA 499321fView commit details -
build: fix bad cherry-pick for vcbuild.bat build-release
PR-URL: nodejs#2625 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Configuration menu - View commit details
-
Copy full SHA for 3864af9 - Browse repository at this point
Copy the full SHA 3864af9View commit details -
tools: update release.sh to work with new website
now need to specify "nodejs" or "iojs", also remove .gpg file PR-URL: nodejs#2623 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 4a8ca84 - Browse repository at this point
Copy the full SHA 4a8ca84View commit details -
build: rename 'doc' directory to 'docs' for upload
to match nodejs.org directory name PR-URL: nodejs#2623 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 9f527c0 - Browse repository at this point
Copy the full SHA 9f527c0View commit details -
build: change staging directory on new server
new server has "nodejs" and "iojs" directories, upload to the appropriate one PR-URL: nodejs#2623 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for cdc1b37 - Browse repository at this point
Copy the full SHA cdc1b37View commit details -
build: set file permissions before uploading
PR-URL: nodejs#2623 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 4867cea - Browse repository at this point
Copy the full SHA 4867ceaView commit details -
test: improve performance of stringbytes test
String concatenation in the assert messages has drastic impact on test runtime. Removal of these messages is unlikely to affect debugging if any breaking changes are made. Previous time to run: $ time ./iojs test/parallel/test-stringbytes-external.js real 0m2.321s user 0m2.256s sys 0m0.092s With fix: $ time ./iojs test/parallel/test-stringbytes-external.js real 0m0.518s user 0m0.508s sys 0m0.008s PR-URL: nodejs#2544 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c7351db - Browse repository at this point
Copy the full SHA c7351dbView commit details -
src: only memcmp if length > 0 in Buffer::Compare
Both pointer arguments to memcmp are defined as non-null and compiler optimizes upon that. PR-URL: nodejs#2544 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0357c8f - Browse repository at this point
Copy the full SHA 0357c8fView commit details -
PR-URL: nodejs#2310 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e358a64 - Browse repository at this point
Copy the full SHA e358a64View commit details -
build: fix borked chmod call for release uploads
PR-URL: nodejs#2645 Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 205aab3 - Browse repository at this point
Copy the full SHA 205aab3View commit details -
src: only set v8 flags if argc > 1
ParseArgs sets the first element of v8_args to argv[0], so v8_argc will always be at least 1. This change only calls V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional startup improvement of ~5%. PR-URL: nodejs#2646 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2308a27 - Browse repository at this point
Copy the full SHA 2308a27View commit details
Commits on Sep 3, 2015
-
timers: Avoid linear scan in _unrefActive.
Before this change, _unrefActive would keep the unrefList sorted when adding a new timer. Because _unrefActive is called extremely frequently, this linear scan (O(n) at worse) would make _unrefActive show high in the list of contributors when profiling CPU usage. This commit changes _unrefActive so that it doesn't try to keep the unrefList sorted. The insertion thus happens in constant time. However, when a timer expires, unrefTimeout has to go through the whole unrefList because it's not ordered anymore. It is usually not large enough to have a significant impact on performance because: - Most of the time, the timers will be removed before unrefTimeout is called because their users (sockets mainly) cancel them when an I/O operation takes place. - If they're not, it means that some I/O took a long time to happen, and the initiator of subsequents I/O operations that would add more timers has to wait for them to complete. With this change, _unrefActive does not show as a significant contributor in CPU profiling reports anymore. Fixes: nodejs/node-v0.x-archive#8160 Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com> Conflicts: lib/timers.js Fixes: nodejs/node-convergence-archive#23 Ref: nodejs#268 PR-URL: nodejs#2540 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 7a8c3e0 - Browse repository at this point
Copy the full SHA 7a8c3e0View commit details -
timers: don't mutate unref list while iterating it
Commit 934bfe2 had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes: nodejs/node-v0.x-archive#8897 Conflicts: lib/timers.js Fixes: nodejs/node-convergence-archive#23 Ref: nodejs#268 PR-URL: nodejs#2540 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 403d7ee - Browse repository at this point
Copy the full SHA 403d7eeView commit details -
timers: minor _unrefActive fixes and improvements
This commit addresses most of the review comments in nodejs#2540, which are kept in this separate commit so as to better preserve the prior two patches as they landed in 0.12. This commit: - Fixes a bug with unrefActive timers and disposed domains. - Fixes a bug with unrolling an unrefActive timer from another. - Adds a test for both above bugs. - Improves check logic, making it stricter, simpler, or both. - Optimizes nicer with a smaller, separate function for the try/catch. Fixes: nodejs/node-convergence-archive#23 Ref: nodejs#268 PR-URL: nodejs#2540 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for f6b0933 - Browse repository at this point
Copy the full SHA f6b0933View commit details -
doc: update changelog for io.js v3.3.0
Notable changes: * build: Add a --link-module option to configure that can be used to bundle additional JavaScript modules into a built binary (Bradley Meck) nodejs#2497 * docs: Merge outstanding doc updates from joyent/node (James M Snell) nodejs#2378 * http_parser: Significant performance improvement by having http.Server consume all initial data from its net.Socket and parsing directly without having to enter JavaScript. Any 'data' listeners on the net.Socket will result in the data being "unconsumed" into JavaScript, thereby undoing any performance gains. (Fedor Indutny) nodejs#2355 * libuv: Upgrade to 1.7.3 (from 1.6.1), see https://github.com/libuv/libuv/blob/v1.x/ChangeLog for details (Saúl Ibarra Corretgé) nodejs#2310 * V8: Upgrade to 4.4.63.30 (from 4.4.63.26) (Michaël Zasso) nodejs#2482 cherry-picked from v3.x @ 1a6e52d PR-URL: nodejs#2653 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8a9a3bf - Browse repository at this point
Copy the full SHA 8a9a3bfView commit details -
deps: backport 75e43a6 from v8 upstream
Note: chunk in test-heap.cc:1989 discarded as related code missing from current version in node. Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{nodejs#30103} PR-URL: nodejs#2636 Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 714e96e - Browse repository at this point
Copy the full SHA 714e96eView commit details -
test: mark test-repl-persistent-history as flaky
This test is already being investigated, but until a solution is found it should be marked flaky. Ref: nodejs#2319 Ref: nodejs#2356 PR-URL: nodejs#2659 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for 367140b - Browse repository at this point
Copy the full SHA 367140bView commit details -
test: mark test-vm-syntax-error-stderr as flaky
Ref: nodejs#2660 PR-URL: nodejs#2662 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for 93ba585 - Browse repository at this point
Copy the full SHA 93ba585View commit details
Commits on Sep 6, 2015
-
src: fix memory leak in ExternString
v8 will silently return an empty handle which doesn't delete our data if string length is above String::kMaxLength Fixes: nodejs#1374 PR-URL: nodejs#2402 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Amended by @rvagg to change author date from "1970-08-16 16:09:02 +0200" to "2015-08-16 16:09:02 +0200" as per discussion @ nodejs#2713
Configuration menu - View commit details
-
Copy full SHA for 5201cb0 - Browse repository at this point
Copy the full SHA 5201cb0View commit details -
child_process: add callback parameter to .send()
Add an optional callback parameter to `ChildProcess.prototype.send()` that is invoked when the message has been sent. Juggle the control channel's reference count so that in-flight messages keep the event loop (and therefore the process) alive until they have been sent. `ChildProcess.prototype.send()` and `process.send()` used to operate synchronously but became asynchronous in commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed in io.js in commit 07bd05b ("deps: update libuv to 1.2.1"). Fixes: nodejs#760 PR-URL: nodejs#2620 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d010568 - Browse repository at this point
Copy the full SHA d010568View commit details -
test: mark eval_messages as flaky
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: nodejs#2648 Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for 619721e - Browse repository at this point
Copy the full SHA 619721eView commit details -
doc: reorder collaborators by their usernames
Fixes: nodejs#1972 PR-URL: nodejs#2322 Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ba50cfe - Browse repository at this point
Copy the full SHA ba50cfeView commit details -
doc: update url doc to account for escaping
Fixes: nodejs#2113 Ref: 17a379e PR-URL: nodejs#2605 Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: mscdex - Brian White <mscdex@mscdex.net>
Configuration menu - View commit details
-
Copy full SHA for 29f586a - Browse repository at this point
Copy the full SHA 29f586aView commit details -
test: refactor to eliminate flaky test
This retains the key elements of test-child-process-fork-getconnections (forks a child process, sends a bunch of sockets, uses getConnections() to enumerate them) but contains some code to work around an apparent intermittent bug that occurs on OS X where a socket seems to close itself unexpectedly. nodejs#2610 was opened for the bug that was causing the problem in the first place. PR-URL: nodejs#2609 Fixes: nodejs#1100 Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Configuration menu - View commit details
-
Copy full SHA for fe4b309 - Browse repository at this point
Copy the full SHA fe4b309View commit details -
child_process: check execFile and fork args
Port of joyent/node commits: * nodejs/node-v0.x-archive@e17c5a7 * nodejs/node-v0.x-archive@70dafa7 Pull over test-child-process-spawn-typeerror.js from v0.12, replacing the existing test in master. The new test includes a broader set of tests on the various arg choices and throws. Reviewed-By: trevnorris - Trevor Norris <trevnorris@nodejs.org> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani PR-URL: nodejs#2667 Fixes: nodejs#2515
Configuration menu - View commit details
-
Copy full SHA for 609db5a - Browse repository at this point
Copy the full SHA 609db5aView commit details -
build: add --enable-asan with builtin leakcheck
PR-URL: nodejs#2376 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 101db80 - Browse repository at this point
Copy the full SHA 101db80View commit details -
events,lib: don't require EE#listenerCount()
Now parts of our public and public-ish APIs fall back to old-style listenerCount() if the emitter does not have a listenerCount function. Fixes: nodejs#2655 Refs: 8f58fb9 PR-URL: nodejs#2661 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f3696f6 - Browse repository at this point
Copy the full SHA f3696f6View commit details -
deps: upgrade V8 to 4.5.103.24
Upgrade to the latest branch-head for V8 4.5. For the full commit log see https://github.com/v8/v8-git-mirror/commits/4.5.103.24 PR-URL: nodejs#2509 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for c431725 - Browse repository at this point
Copy the full SHA c431725View commit details -
src: apply debug force load fixups from 41e63fb
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis nodejs@41e63fb PR-URL: nodejs#2509 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 808de0d - Browse repository at this point
Copy the full SHA 808de0dView commit details -
contextify: ignore getters during initialization
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: nodejs#2091 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b2ecbb6 - Browse repository at this point
Copy the full SHA b2ecbb6View commit details -
test: fix test-repl-tab-complete.js for V8 4.5
The list of Array properties needed to be updated to match the new ones added in V8 4.5. PR-URL: nodejs#2509 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for f146f68 - Browse repository at this point
Copy the full SHA f146f68View commit details -
src: enable v8 deprecation warnings and fix them
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New() calls in src/node.cc and src/debug-agent.cc. PR-URL: nodejs#2091 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b1a2d95 - Browse repository at this point
Copy the full SHA b1a2d95View commit details -
src: replace usage of v8::Handle with v8::Local
v8::Handle is deprecated: https://codereview.chromium.org/1224623004 PR-URL: nodejs#2202 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 7ce749d - Browse repository at this point
Copy the full SHA 7ce749dView commit details -
src: enable vector ics on arm again
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: nodejs#2509 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for e137c11 - Browse repository at this point
Copy the full SHA e137c11View commit details -
src: re-enable fast math on arm
Ref: nodejs#1376 Ref: nodejs#1398 Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2 V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019 PR-URL: nodejs#2592 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Configuration menu - View commit details
-
Copy full SHA for dd3f341 - Browse repository at this point
Copy the full SHA dd3f341View commit details -
deps: upgrade V8 to 4.5.103.30
Pick up v8/v8@f9a0a16 Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 PR-URL: nodejs#2632 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for 5424d6f - Browse repository at this point
Copy the full SHA 5424d6fView commit details -
test: fix use of
common
before requiredPR-URL: nodejs#2685 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 384effe - Browse repository at this point
Copy the full SHA 384effeView commit details -
buffer: SlowBuffer only accept valid numeric values
Fixes a regression that appeared with the new Buffer implementation in v3. Without this change, calling the SlowBuffer constructor with something else than a number would abort on the C++ side. This makes sure that the length argument is coerced to number or is 0. Fixes: nodejs#2634 PR-URL: nodejs#2635 Reviewed-By: trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d3178d8 - Browse repository at this point
Copy the full SHA d3178d8View commit details -
doc,test: enable recursive file watching in Windows
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: nodejs#2649 Fixes: nodejs#375 Reviewed-By: rvagg - Rod Vagg <rod@vagg.org> Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 7038388 - Browse repository at this point
Copy the full SHA 7038388View commit details -
src: fix buffer overflow for long exception lines
Long exception lines resulted in a stack buffer overflow or assertion because it was assumed snprintf not counts discarded chars or the assertion itself was incorrect: `(off) >= sizeof(arrow)` PR-URL: nodejs#2404 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for cddbec2 - Browse repository at this point
Copy the full SHA cddbec2View commit details -
src: use standard conform snprintf on windows
The version used before returned -1 on truncation which does not conform to the standard. PR-URL: nodejs#2404 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for eba3d3d - Browse repository at this point
Copy the full SHA eba3d3dView commit details -
doc: update environment vars in manpage and --help
- Added NODE_REPL_HISTORY to the environment variables in the --help and made all descriptions start with lower case for consistency. - Added NODE_REPL_HISTORY and NODE_ICU_DATA to the man page. PR-URL: nodejs#2690 Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for d3d5b93 - Browse repository at this point
Copy the full SHA d3d5b93View commit details -
doc: add TSC meeting minutes 2015-09-02
PR-URL: nodejs#2674 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8637755 - Browse repository at this point
Copy the full SHA 8637755View commit details -
build: fix .pkg creation tooling
PR-URL: nodejs#2687 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5652ce0 - Browse repository at this point
Copy the full SHA 5652ce0View commit details -
deps: backport 75e43a6 from v8 upstream (again)
Note: When this was cherry-picked for v8 v4.4 (landed in nodejs#2636), test-heap.cc:1989 chunk did not exist. It now exists in v8 v4.5.103.30. This PR completes the cherry pick of the whole commit from v8. PR-URL: nodejs#2692 Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com> Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{nodejs#30103}
Configuration menu - View commit details
-
Copy full SHA for 155783d - Browse repository at this point
Copy the full SHA 155783dView commit details
Commits on Sep 7, 2015
-
PR-URL: nodejs#2696 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for babdbfd - Browse repository at this point
Copy the full SHA babdbfdView commit details -
deps: create .npmrc during npm tests
This patch should make the tests pass on the downstreamed npm. PR-URL: nodejs#2696 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for b2c3c6d - Browse repository at this point
Copy the full SHA b2c3c6dView commit details -
cpplint: make it possible to run outside git repo
cpplint uses the top-level .git directory to determine what the root is for #include guards. If it doesn't find a .git directory, it walks up all the way to the system root and subsequently complains that guards must be written as HOME_USER_SRC_NODE_SRC_FILENAME_H_. This commit replaces the .git-based path munging with a fixed root path relative to the location of the cpplint script, making it possible to successfully run `make test` from an extracted tarball. Fixes: nodejs#2693 PR-URL: nodejs#2710 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3711934 - Browse repository at this point
Copy the full SHA 3711934View commit details -
build: make .msi install to "nodejs", not "node"
PR-URL: nodejs#2701 Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for be427e9 - Browse repository at this point
Copy the full SHA be427e9View commit details
Commits on Sep 8, 2015
-
Update AUTHORS list using tools/update-authors.sh
Configuration menu - View commit details
-
Copy full SHA for 81a8d45 - Browse repository at this point
Copy the full SHA 81a8d45View commit details -
crypto: replace rwlocks with simple mutexes
It was pointed out by Zhou Ran that the Windows XP implementation of uv_rwlock_rdlock() and friends may unlock the inner write mutex on a different thread than the one that locked it, resulting in undefined behavior. The only place that uses rwlocks is the crypto module. Make that use normal (simple) mutexes instead. OpenSSL's critical sections are generally very short, with exclusive access outnumbering shared access by a factor of three or more, so it's not as if using rwlocks gives a decisive performance advantage. PR-URL: nodejs#2723 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 03f900a - Browse repository at this point
Copy the full SHA 03f900aView commit details -
child_process: use stdio.fd even if it is 0
Previously, in _validateStdio we were using stdio.fd || stdio. If stdio.fd was falsy (or 0 in the case of stdin), then the entire stdio object would be passed which could cause a crash. Fixes: nodejs#2721 PR-URL: nodejs#2727 Reviewed-By: silverwind - Roman Reiss <me@silverwind.io> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2c3939c - Browse repository at this point
Copy the full SHA 2c3939cView commit details -
src: s/ia32/x86 for process.release.libUrl for win
PR-URL: nodejs#2699 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for d2d9812 - Browse repository at this point
Copy the full SHA d2d9812View commit details -
* support process.release * support all io.js versions * support node v4+ including new download locations * enable delay-load hook by default by default * download header-only tarballs instead of full source See nodejs/node-gyp#711 for full details PR-URL: nodejs#2700 Reviewed-By: Forrest L Norvell <forrest@npmjs.com>
Configuration menu - View commit details
-
Copy full SHA for cc0ab17 - Browse repository at this point
Copy the full SHA cc0ab17View commit details -
build: remote commands on staging in single session
PR-URL: nodejs#2717 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for a7596d7 - Browse repository at this point
Copy the full SHA a7596d7View commit details -
cluster: allow shared reused dgram sockets
Allow listening on reused dgram ports in cluster workers. Fix: nodejs/node-v0.x-archive#9261 PR-URL: nodejs#2548 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for c60857a - Browse repository at this point
Copy the full SHA c60857aView commit details -
deps: improve ArrayBuffer performance in v8
This a backport of the following commits from the v8's upstream: * 1a8c38c50513f9af07ada479629a653e1cf36ff3 * 206f12abee3f1e7eda8fc6521d48f3c319460ee1 * 9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 Original commit message: heap: make array buffer maps disjoint Remove intersection from the `std::map`s representing current live ArrayBuffers. While being simpler to understand, it poses significant performance issue for the active ArrayBuffer users (like node.js). Store buffers separately, and process them together during mark-sweep phase. The results of benchmarks are: $ ./node-slow bench && ./node-fast bench 4997.4 ns/op 4685.7 ns/op NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. PR-URL: nodejs#2732 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for e1c9761 - Browse repository at this point
Copy the full SHA e1c9761View commit details -
node-gyp: float 3.0.1, minor fix for download url
PR-URL: nodejs#2737 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9358eee - Browse repository at this point
Copy the full SHA 9358eeeView commit details -
build: fix v8_enable_handle_zapping override
It was previously ignored by features.gypi and therefore enabled by default for release builds. See https://code.google.com/p/chromium/issues/detail?id=318206 PR-URL: nodejs#2731 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 0cb0f4a - Browse repository at this point
Copy the full SHA 0cb0f4aView commit details -
2015-09-08, Version 4.0.0 (Stable) Release
This list of changes is relative to the last io.js v3.x branch release, v3.3.0. Please see the list of notable changes in the v3.x, v2.x and v1.x releases for a more complete list of changes from 0.12.x. Note, that some changes in the v3.x series as well as major breaking changes in this release constitute changes required for full convergence of the Node.js and io.js projects. * child_process: ChildProcess.prototype.send() and process.send() operate asynchronously across all platforms so an optional callback parameter has been introduced that will be invoked once the message has been sent, i.e. .send(message[, sendHandle][, callback]) (Ben Noordhuis) nodejs#2620. * node: Rename "io.js" code to "Node.js" (cjihrig) nodejs#2367. * node-gyp: This release bundles an updated version of node-gyp that works with all versions of Node.js and io.js including nightly and release candidate builds. From io.js v3 and Node.js v4 onward, it will only download a headers tarball when building addons rather than the entire source. (Rod Vagg) nodejs#2700. * npm: Upgrade to version 2.14.2 from 2.13.3, includes a security update, see https://github.com/npm/npm/releases/tag/v2.14.2 for more details, (Kat Marchán) nodejs#2696. * timers: Improved timer performance from porting the 0.12 implementation, plus minor fixes (Jeremiah Senkpiel) nodejs#2540, (Julien Gilli) nodejs/node-v0.x-archive#8751 nodejs/node-v0.x-archive#8905 * util: The util.is*() functions have been deprecated, beginning with deprecation warnings in the documentation for this release, users are encouraged to seek more robust alternatives in the npm registry, (Sakthipriyan Vairamani) nodejs#2447. * v8: Upgrade to version 4.5.103.30 from 4.4.63.30 (Ali Ijaz Sheikh) nodejs#2632. - Implement new TypedArray prototype methods: copyWithin(), every(), fill(), filter(), find(), findIndex(), forEach(), indexOf(), join(), lastIndexOf(), map(), reduce(), reduceRight(), reverse(), slice(), some(), sort(). See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement new TypedArray.from() and TypedArray.of() functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray for further information. - Implement arrow functions. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions for further information. - Full ChangeLog available at https://github.com/v8/v8-git-mirror/blob/4.5.103/ChangeLog
Configuration menu - View commit details
-
Copy full SHA for f9f8378 - Browse repository at this point
Copy the full SHA f9f8378View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1abe81 - Browse repository at this point
Copy the full SHA b1abe81View commit details -
doc: fix comma splice in Assertion Testing doc
This fixes a minor typographical error in the Assertion Testing doc. PR-URL: nodejs#2728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 1d75012 - Browse repository at this point
Copy the full SHA 1d75012View commit details
Commits on Sep 11, 2015
-
test: expect error for test_lookup_ipv6_hint on FreeBSD
FreeBSD does not support the V4MAPPED flag so expect an error. This is a partial fix for nodejs#2468. It only fixes it on FreeBSD. Failures on other platforms are due to other reasons and need to be fixed separately. PR-URL: nodejs#2724 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Fixes: nodejs#2468
Configuration menu - View commit details
-
Copy full SHA for 779e14f - Browse repository at this point
Copy the full SHA 779e14fView commit details -
doc: describe process API for IPC
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs#1978
Configuration menu - View commit details
-
Copy full SHA for 432cce6 - Browse repository at this point
Copy the full SHA 432cce6View commit details -
win,msi: fix documentation shortcut url
Fixes: nodejs#2779 PR-URL: nodejs#2781 Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for e035266 - Browse repository at this point
Copy the full SHA e035266View commit details -
doc: use 3rd person singular for consistency
PR-URL: nodejs#2765 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 82ba183 - Browse repository at this point
Copy the full SHA 82ba183View commit details -
bindings: close after reading module struct
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: nodejs#2792 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9683e5d - Browse repository at this point
Copy the full SHA 9683e5dView commit details -
deps: cherry-pick 6da51b4 from v8's upstream
Original commit message: TypedArray accessor detection: consider entire prototype chain When looking up a special accessor for known TypedArray fields ("length", "byteLength", "byteOffset"), consider the entire prototype chain, not only the direct prototype. This allows subclasses of TypedArrays to benefit from fast specialized accesses. Review URL: https://codereview.chromium.org/1313493005 Cr-Commit-Position: refs/heads/master@{nodejs#30678} Benchmark results: buffers/buffer-iterate.js size=16386 type=slow method=for n=1000: ./node: 71607 node: 8702.3 ............ 722.85% Improvement depends on the code, but generally brings us back to the performance that we had before the v8 update (if not making it faster). Fixes: nodejs#2463 PR-URL: nodejs#2801 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6098504 - Browse repository at this point
Copy the full SHA 6098504View commit details -
doc: use US English for consistency
behaviour -> behavior PR-URL: nodejs#2784 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d664b95 - Browse repository at this point
Copy the full SHA d664b95View commit details -
test: remove valid hostname check in test-dns.js
Operating systems can and do return invalid hostnames if that's what they have (for example) in /etc/hosts. Test passes if no error is thrown and the hostname string is not empty. Fixes: nodejs#2468 PR-URL: nodejs#2785 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 6e2fe1c - Browse repository at this point
Copy the full SHA 6e2fe1cView commit details
Commits on Sep 15, 2015
-
doc: use "Calls" over "Executes" for consistency
"Calls" is used frequently throughout the docs except for this line. Use "Calls" over "Executes" to make it consistent. PR-URL: nodejs#2800 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd1297f - Browse repository at this point
Copy the full SHA cd1297fView commit details -
deps: update libuv to version 1.7.4
PR-URL: nodejs#2817 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8119693 - Browse repository at this point
Copy the full SHA 8119693View commit details -
src: fix v8::CpuProfiler idle sampling
Ensure that samples are evenly distributed, which is required for v8::CpuProfiler users to work correctly (v8-profiler / node-inspector). PR-URL: nodejs#2324 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for b0df227 - Browse repository at this point
Copy the full SHA b0df227View commit details -
tools: remove hyphen in TAP result
As it is, the TAP result shows an extra hyphen in front of test names. Sample: ci.nodejs.org/job/node-test-commit-osx/nodes=osx1010/454/tapResults/ This patch removes the extra hyphen. PR-URL: nodejs#2718 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for ac004b8 - Browse repository at this point
Copy the full SHA ac004b8View commit details -
test: increase dgram timeout for armv6
test-dgram-broadcast-multi-process.js and test-dgram-multicast-multi-process.js were failing on Pi 1 because the test was timing out. Changed static 5000ms timeout to a dynamically determined timeout based on the processor using common.platformTimeout(). PR-URL: nodejs#2808 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 41f2dde - Browse repository at this point
Copy the full SHA 41f2ddeView commit details -
test: split up internet dns tests
For whatever reason, the CI win2012 machine was timing out on the internet test-dns file. Split out ipv4 and ipv6 specific tests to separate files so tests do not time out. (Each file is given a 60 second timeout on CI. Tests within a file are run in sequence.) PR-URL: nodejs#2802 Fixes: nodejs#2468 Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 9e5f099 - Browse repository at this point
Copy the full SHA 9e5f099View commit details -
doc: fixed io.js references in process.markdown
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> PR-URL: nodejs#2846
Configuration menu - View commit details
-
Copy full SHA for 55ac24f - Browse repository at this point
Copy the full SHA 55ac24fView commit details -
doc: fix two doc errors in stream and process
`process.stdout` always blocks as of 20176a9 `WritableState.buffer` is `getBuffer()` as of 9158666 PR-URL: nodejs#2549 Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for 2d77d03 - Browse repository at this point
Copy the full SHA 2d77d03View commit details -
Remove test file that has been in disabled from its very first commit (9ccf0e5) in 2011. It is a test for nodejs/node-v0.x-archive#670 from 2011. There are no assertions in the test. In that regard, it is more debugging code than a test. PR-URL: nodejs#2841 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5df5d04 - Browse repository at this point
Copy the full SHA 5df5d04View commit details -
src: use ZCtxt as a source for v8::Isolates
Other methods like `After` already use ZCtxt as the source for Enviroment/ v8::Isolate objects, this commit applies the same style to the other missing methods (`After sync` and `Write`) PR-URL: nodejs#2547 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 57707e2 - Browse repository at this point
Copy the full SHA 57707e2View commit details -
doc: add tunniclm as a collaborator
Refs: nodejs#2413 PR-URL: nodejs#2826 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4d1ae26 - Browse repository at this point
Copy the full SHA 4d1ae26View commit details -
- Fixed typo: "insallation" -> "installation" - Added an "that" in a sentence where it was needed for clarity. PR-URL: nodejs#2852 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ee36d6 - Browse repository at this point
Copy the full SHA 7ee36d6View commit details -
doc: fix broken link in repl.markdown
PR-URL: nodejs#2827 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for e8a206e - Browse repository at this point
Copy the full SHA e8a206eView commit details -
tools: fix flakiness in test-tick-processor
Per the discussion on nodejs#2471, the JS symbols checked for by this test were occasionally too deep in the stack and were being ignored by the tick processor. I have addressed this by increasing the stack depth inspected by the tick processor and looking for the eval symbol which is more likely to be present. Additional flakiness was caused by occasional misses of the code creation event for the JS function being executed. I now have separate code snippets to test for JS and C++ symbols and if the code creation event is missed for the JS symbol test then I check for a percentage of UNKNOWN symbols in processed output. This is considered a success as the processing scripts in the node repository are still correctly processing the ticks recieved from the v8 scripts. Further investigation is needed into the v8 profiling scripts to determine why code creation events are being missed. PR-URL: nodejs#2694 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 519caba - Browse repository at this point
Copy the full SHA 519cabaView commit details -
tools: add missing tick processor polyfill
The polyfill is only needed if incorrect command line arguments are passed to the script so it was missed in initial testing. PR-URL: nodejs#2694 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for ff6d30d - Browse repository at this point
Copy the full SHA ff6d30dView commit details -
fs: implemented WriteStream#writev
Streams with writev allow many buffers to be pushed to underlying OS APIs in one batch, in this case improving write throughput by an order of magnitude. This is especially noticeable when writing many (small) buffers. PR-URL: nodejs#2167 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2b6aa94 - Browse repository at this point
Copy the full SHA 2b6aa94View commit details -
PR-URL: nodejs#2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for f4641ae - Browse repository at this point
Copy the full SHA f4641aeView commit details -
deps: upgraded to node-gyp@3.0.3 in npm
No more cherry-picked io patches. hooray. PR-URL: nodejs#2822 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for ed47ab6 - Browse repository at this point
Copy the full SHA ed47ab6View commit details -
http_server: fix resume after socket close
Socket resume may happen on a next tick, and in following scenario: 1. `socket.resume()` 2. `socket._handle.close()` 3. `socket._handle = null;` The `_resume` will be invoked with empty `._handle` property. There is nothing bad about it, and we should just ignore the `resume`/`pause` events in this case. Same applies to the unconsuming of socket on adding `data` and/or `readable` event listeners. Fix: nodejs#2821 PR-URL: nodejs#2824 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for ea15d71 - Browse repository at this point
Copy the full SHA ea15d71View commit details -
fs: consider NaN/Infinity in toUnixTimestamp
PR-URL: nodejs#2387 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6108ea9 - Browse repository at this point
Copy the full SHA 6108ea9View commit details -
streams: refactor LazyTransform to internal/
This commit refactors LazyTransform from the crypto implementation (lib/crypto.js) into an internal module (not publicy accessible) in internal/streams/lazy_transform.js. This promotes a more modular core design and removes code bloat in crypto, as LazyTransform didn't specifically have anything to do with cryptography, but rather a fast way to support two APIs on a stream. PR-URL: nodejs#2566 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eaa8e60 - Browse repository at this point
Copy the full SHA eaa8e60View commit details -
tools: open
test.tap
file in write-binary modeBy default the logfile is opened in append mode. This commit makes sure that the file is opened in write-binary mode, so that the file will be created if it doesn't exist or overwrite if it exists. Fixes: nodejs#2834 PR-URL: nodejs#2837 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for 69e7b87 - Browse repository at this point
Copy the full SHA 69e7b87View commit details -
build: clean up the generated tap file
Make `make clean` cleanup the generated tap file as well. Fixes: nodejs#2834 PR-URL: nodejs#2837 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for e35b1fd - Browse repository at this point
Copy the full SHA e35b1fdView commit details -
tools: enable arrow functions in .eslintrc
As of v8 4.5, arrow functions are rolled out. This patch allows eslint to accept arrow functions as well. PR-URL: nodejs#2840 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 59d0373 - Browse repository at this point
Copy the full SHA 59d0373View commit details -
test: fix default value for additional param
In Python, the default values of parameters are evaluated only once during their declaration. So, whenever the default parameter is used the same object will be used. Since we use a list, which is a mutable object, this could lead to unexpected results. PR-URL: nodejs#2553 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 52019a1 - Browse repository at this point
Copy the full SHA 52019a1View commit details -
deps: upgrade V8 to 4.5.103.33
This brings in the patches from 4.5.103.30...4.5.103.33 fixing the issue with computed property names not working in nested literals. Full V8 4.5 commit log at: https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 Fixes: nodejs#2507 PR-URL: nodejs#2870 Reviewed-By: indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: fishrock123 - Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7ebd881 - Browse repository at this point
Copy the full SHA 7ebd881View commit details -
build: Updates to enable AIX support
These are the core changes that allow AIX to compile. There are still some test failures as there are some patches needed for libuv and npm that we'll need to contribute through those communities but this set allows node to be built on AIX and pass most of the core tests The change in js2c is because AIX does not support $ in identifier names. See the discussion/agreement in nodejs#2272 PR-URL: nodejs#2364 Reviewed-By: Ben Noordhuis <ben@strongloop.com> Reviewed-By: Rod Vagg <r@va.gg>
Configuration menu - View commit details
-
Copy full SHA for 43397b2 - Browse repository at this point
Copy the full SHA 43397b2View commit details -
doc: add missing backtick in buffer.markdown
Fixes: nodejs#2880 PR-URL: nodejs#2881 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for cd643d7 - Browse repository at this point
Copy the full SHA cd643d7View commit details -
doc: rename from iojs(1) to node(1) in benchmarks
Examples in the benchmark readme previously sill referenced iojs(1). PR-URL: nodejs#2884 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for a7bd897 - Browse repository at this point
Copy the full SHA a7bd897View commit details -
tsc: adjust TSC membership for IBM+StrongLoop
Following the IBM+StrongLoop announcement last week, we (@piscisaureus, @bnoordhuis, @srl295, @mhdawson, and myself) want to take a moment to reiterate our personal commitment to Node.js and the Foundation. Per the TSC rules, any one company is limited to no more than 1/4 of the voting seats on the TSC and after talking it over amongst ourselves, @srl295 and @mhdawson have elected to step back from the TSC for now. What I would propose is that they continue to participate in the weekly TSC meetings as observers; and that once the membership expands, they be considered once again for full TSC status. Both Steven and Michael will continue to be actively involved with Node.js. Both are active members of various Working Groups. (Michael chairs the Benchmarking workgroup and Steven chairs the Intl workgroup.) /cc @nodejs/tsc Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Alexis Campailla <orangemocha@nodejs.org> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Trevor Norris <trevnorris@nodejs.org> PR-URL: nodejs#2858
Configuration menu - View commit details
-
Copy full SHA for ba47511 - Browse repository at this point
Copy the full SHA ba47511View commit details
Commits on Sep 16, 2015
-
src: use subarray() in Buffer#slice() for speedup
Use the built-in Typed Array method subarray() to improve performance of Buffer#slice(). Benchmark improvements: benchmark/buffer-slice: 40% benchmark/buffer-creation (pool): 25% Additional tests also added. PR-URL: nodejs#2777 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a5f80a - Browse repository at this point
Copy the full SHA 0a5f80aView commit details -
http: default Agent.getName to 'localhost'
Refactor out the if/else statement checking for option.host. Add whitespace to make concatenation chunks more readable and consistent with the https version of Agent.getName(). PR-URL: nodejs#2825 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 431bf74 - Browse repository at this point
Copy the full SHA 431bf74View commit details -
buffer: construct Uint8Array in JS
Overall construction time of Typed Arrays is faster in JS, but the problem with using it normally is zero-fill of memory. Get around this by using a flag in the ArrayBuffer::Allocator to trigger when memory should or shouldn't be zero-filled. Remove Buffer::Create() as it is no longer called. The creation of the Uint8Array() was done at each callsite because at the time of this patch there was a performance penalty for centralizing the call in a single function. PR-URL: nodejs#2866 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 7df018a - Browse repository at this point
Copy the full SHA 7df018aView commit details -
buffer: always allocate typed arrays outside heap
By default v8 allocates typed arrays <= 64 bytes inside the v8 heap. In these cases the memory pointer returned by Buffer::Data() can change while the memory is being operated on. Resolve by passing a flag that forces all typed arrays outside the v8 heap. Fixes: 74178a5 "buffer: construct Uint8Array in JS" PR-URL: nodejs#2893 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 4b4cfa2 - Browse repository at this point
Copy the full SHA 4b4cfa2View commit details -
Most calls to ref() and unref() are chainable, timers should be chainable, too. Typical use: var to = setTimeout(ontimeout, 123).unref(); PR-URL: nodejs#2905 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trevnorris@nodejs.org>
Configuration menu - View commit details
-
Copy full SHA for f931b9d - Browse repository at this point
Copy the full SHA f931b9dView commit details -
doc: describe spawn option.detached
PR-URL: nodejs#2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 74db963 - Browse repository at this point
Copy the full SHA 74db963View commit details -
doc: correct buffer.slice arg syntax
PR-URL: nodejs#2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 302d59d - Browse repository at this point
Copy the full SHA 302d59dView commit details -
doc: remove incorrect reference to TCP in net docs
createServer() can create socket of types other than TCP. PR-URL: nodejs#2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bb0f869 - Browse repository at this point
Copy the full SHA bb0f869View commit details -
src: null env_ field from constructor
The env_ field in ArrayBufferAllocator needs to be null'd out since it is used during initialization and checked prior to properly being set by set_env(). Fixes: 74178a5 "buffer: construct Uint8Array in JS" PR-URL: nodejs#2913 Reviewed-By: Fedor Indutny <fedor@indutny.com>
Configuration menu - View commit details
-
Copy full SHA for 8e58434 - Browse repository at this point
Copy the full SHA 8e58434View commit details -
test: fix Buffer OOM error message
Now that Buffers instantiate the Uint8Array in JS the error message has changed in case the allocation fails due to OOM. Tests have been updated to match. PR-URL: nodejs#2915 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 079a217 - Browse repository at this point
Copy the full SHA 079a217View commit details
Commits on Sep 17, 2015
-
doc: process exit event is not guaranteed to fire
This change: * notes that the exit event is not guaranteed to fire * provides an example situation where the exit event may not fire * makes a minor copyediting change * enforces 80 character wrap in one place where it was not honored Fixes: nodejs#2853 PR-URL: nodejs#2861 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for bf42cc8 - Browse repository at this point
Copy the full SHA bf42cc8View commit details -
test: use tmp directory in chdir test
This patch - makes chdir test to use the tmp directory - moves the test to parallel - renames the file to test-process-chdir as chdir is in process module PR-URL: nodejs#2589 Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 648c003 - Browse repository at this point
Copy the full SHA 648c003View commit details -
deps: backport 0d01728 from v8's upstream
Original commit message: [objects] do not visit ArrayBuffer's backing store ArrayBuffer's backing store is a pointer to external heap, and can't be treated as a heap object. Doing so will result in crashes, when the backing store is unaligned. See: nodejs#2791 BUG=chromium:530531 R=mlippautz@chromium.org LOG=N Review URL: https://codereview.chromium.org/1327403002 Cr-Commit-Position: refs/heads/master@{nodejs#30771} Fix: nodejs#2791 PR-URL: nodejs#2912 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 94972d5 - Browse repository at this point
Copy the full SHA 94972d5View commit details -
deps: backport 6d32be2 from v8's upstream
Original commit message: [es6] Bound function name Instead of updating the SharedFuntionInfo set the name property on the function directly. BUG=v8:4278 LOG=N R=verwaest@chromium.org, littledan@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1227523003 Cr-Commit-Position: refs/heads/master@{nodejs#29558} Fixes: nodejs#2754 PR-URL: nodejs#2916 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 96670eb - Browse repository at this point
Copy the full SHA 96670ebView commit details -
2015-09-17, Version 4.1.0 (Stable) Release
Notable changes: * buffer: - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) nodejs#2866. - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) nodejs#2777. * fs: - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) nodejs#2387. - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) nodejs#2167. * http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) nodejs#2824. * npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) nodejs#2822. * src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) nodejs#2324. * v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) nodejs#2870. - This fixes a previously known bug where some computed object shorthand properties did not work correctly (nodejs#2507). Refs: nodejs#2844 PR-URL: nodejs#2889
Configuration menu - View commit details
-
Copy full SHA for b4ec2c2 - Browse repository at this point
Copy the full SHA b4ec2c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f6f291 - Browse repository at this point
Copy the full SHA 8f6f291View commit details
Commits on Sep 20, 2015
-
test: update cwd-enoent tests for AIX
On AIX you can not remove a directory that you are currently inside of as it results in an EBUSY error. "EBUSY: resource busy or locked". Updated the tests accordingly so that they are skipped on AIX. PR-URL: nodejs#2909 Reviewed-By: Ben Noordhuis <ben@strongloop.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 3e09dcf - Browse repository at this point
Copy the full SHA 3e09dcfView commit details -
test: make cluster tests more time tolerant
Port nodejs/node-v0.x-archive@f3f4e28 to master, updating to guard changes for AIX as requested PR-URL: nodejs#2891 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 71b5d80 - Browse repository at this point
Copy the full SHA 71b5d80View commit details -
build: fix icutrim when building small-icu on BE
Fix a build error that occurs when icutrim is run to cut down the ICU locale set on Big-Endian platforms when building with --with-intl=small-icu (which is done by the "make binary" target). This fixes the binary build on POWER platforms. Fixes: nodejs#2601 PR-URL: nodejs#2602 Reviewed-By: Steven Loomis <srloomis@us.ibm.com>
Configuration menu - View commit details
-
Copy full SHA for 5905b14 - Browse repository at this point
Copy the full SHA 5905b14View commit details -
Windows 8+ compiled in Release mode exits with code 0xC0000409 when abort() is called. This prevents us from being able to reliably verify an abort exit code (3) on windows. PR-URL: nodejs#2776 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b1ca4a - Browse repository at this point
Copy the full SHA 0b1ca4aView commit details -
src: honor --abort_on_uncaught_exception flag
Fix regression introduced in 0af4c9e that ignores the --abort-on-uncaught-exception flag. Prior to that commit, the flag was passed through to v8. After that commit, the process just calls exit(1). PR-URL: nodejs#2776 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2034f68 - Browse repository at this point
Copy the full SHA 2034f68View commit details -
doc: refine process.kill() and exit explanations
Add corrections about when exit event fires and how .kill() works on Windows. PR-URL: nodejs#2918 Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b2ddf0f - Browse repository at this point
Copy the full SHA b2ddf0fView commit details -
buffer: don't set zero fill for zero-length buffer
Instantiating a Buffer of length zero would set the kNoZeroFill flag to true but never actually call ArrayBuffer::Allocator(). Which means the flag was never set back to false. The result was that the next allocation would unconditionally not be zero filled. Add test to ensure Uint8Array's are zero-filled after creating a Buffer of length zero. This test may falsely succeed, but will not falsely fail. Fix: nodejs#2930 PR-URL: nodejs#2931 Reviewed-By: Rod Vagg <rod@vagg.org>
Configuration menu - View commit details
-
Copy full SHA for d63e02e - Browse repository at this point
Copy the full SHA d63e02eView commit details -
readline: fix tab completion bug
This fixes a problem where tab completion is empty when the input stream column size is undefined. As a solution we can force maxColumns to 1 in this scenario. PR-URL: nodejs#2816 Fixes: nodejs#2396 Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for d4cd5ac - Browse repository at this point
Copy the full SHA d4cd5acView commit details -
test: add test-spawn-cmd-named-pipe
Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: nodejs/node-v0.x-archive#7345 PR-URL: nodejs#2770 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for fa08d1d - Browse repository at this point
Copy the full SHA fa08d1dView commit details -
test: test more http response splitting scenarios
The test verified the output of http.OutgoingMessage#writeHead() but not http.OutgoingMessage#setHeader(). Also check the response body. PR-URL: nodejs#2945 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Configuration menu - View commit details
-
Copy full SHA for 2084f52 - Browse repository at this point
Copy the full SHA 2084f52View commit details -
http: guard against response splitting in trailers
Commit 3c293ba ("http: protect against response splitting attacks") filters out newline characters from HTTP headers but forgot to apply the same logic to trailing HTTP headers, i.e., headers that come after the response body. This commit rectifies that. The expected security impact is low because approximately no one uses trailing headers. Some HTTP clients can't even parse them. PR-URL: nodejs#2945 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Rod Vagg <r@va.gg>
Configuration menu - View commit details
-
Copy full SHA for f542e74 - Browse repository at this point
Copy the full SHA f542e74View commit details -
doc: clarify description of assert.ifError()
This fixes a few typographical errors (comma splices and the like) and clarifies the description of assert.ifError(). It also standardizes the document on "inequality" rather than having both "inequality" and "non- equality". PR-URL: nodejs#2941 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f7edbab - Browse repository at this point
Copy the full SHA f7edbabView commit details -
http_parser: do not dealloc during kOnExecute
`freeParser` deallocates `Parser` instances early if they do not fit into the free list. This does not play well with recent socket consumption change, because it will try to deallocate the parser while executing on its stack. Regression was introduced in: 1bc4468 Fix: nodejs#2928 PR-URL: nodejs#2956 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bc9f629 - Browse repository at this point
Copy the full SHA bc9f629View commit details -
test: use tmpDir instead of fixtures in readdir
This patch - makes the test use tmp directory instead of the fixtures directory, - simplifies the code - moves the test to `parallel`. PR-URL: nodejs#2587 Reviewed-By: Rich Trott <rtrott@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 816f609 - Browse repository at this point
Copy the full SHA 816f609View commit details -
PR-URL: nodejs#2958 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 793aad2 - Browse repository at this point
Copy the full SHA 793aad2View commit details -
deps: upgraded to node-gyp@3.0.3 in npm
PR-URL: nodejs#2958 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Configuration menu - View commit details
-
Copy full SHA for 2600fb8 - Browse repository at this point
Copy the full SHA 2600fb8View commit details
Commits on Sep 22, 2015
-
tools: single, cross-platform tick processor
Currently there are three separate tick processor scripts for mac, windows, and linux. These have been replaced with a single node.js script to improve maintainability and remove the need to preserve parallel logic in these separate places. PR-URL: nodejs#2868 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6ea8ec1 - Browse repository at this point
Copy the full SHA 6ea8ec1View commit details -
deps: backport ff7d70b from V8's upstream
Original commit message: Update BitField3 type in gen-postmortem-metadata.py Since https://codereview.chromium.org/272163002, BitField3 is a raw uint32 field, and not a SMI anymore. Update tools/gen-postmortem-metadata.py so that post-mortem tools can work with versions of V8 that shipped after that change. This change was merged in github.com/joyent/node right before node v0.12.0 was released. R=danno@chromium.org TEST=mdb_v8, a post-mortem debugging tool running on SmartOS, has been using this change since Node.js v0.12.0 was released BUG= Review URL: https://codereview.chromium.org/1296743003 Cr-Commit-Position: refs/heads/master@{nodejs#30839} PR: nodejs#2959 PR-URL: nodejs#2959 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Rod Vagg <r@va.gg>
Configuration menu - View commit details
-
Copy full SHA for 8da3da4 - Browse repository at this point
Copy the full SHA 8da3da4View commit details -
test: test sync version of mkdir & rmdir
This patch includes tests for sync versions of mkdir and rmdir. Also, it moves the test to `parallel`. PR-URL: nodejs#2588 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for 4519dd0 - Browse repository at this point
Copy the full SHA 4519dd0View commit details -
Detect mipsel before mips because mipsel has __mips__ flag as well. PR-URL: nodejs#2971 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Configuration menu - View commit details
-
Copy full SHA for f010cb5 - Browse repository at this point
Copy the full SHA f010cb5View commit details -
doc: remove extra using v8::HandleScope statement
v8::HandleScope does not seem to be required for addon functions. PR-URL: nodejs#2983 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for 9c59d2f - Browse repository at this point
Copy the full SHA 9c59d2fView commit details -
deps: backport 357e6b9 from V8's upstream
Backport 357e6b99ee3927cc075dd8d27c99b89d858f9dd5 from V8's upstream. Original commit message: Add ScopeInfo constants to post-mortem metadata mdb_v8, a post-mortem debugging tool for Node.js, allows users to inspect ScopeInfo structures in order to get more information about closures. Currently, it hardcodes the metadata it uses to find this information. This change allows it to get this metadata from the node binary itself, and thus to adapt to future changes made to the layout of the ScopeInfo data structure. BUG= R=bmeurer@chromium.org PR: nodejs#2974 PR-URL: nodejs#2974 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Ben Noordhuis <ben@strongloop.com>
Configuration menu - View commit details
-
Copy full SHA for b93ad5a - Browse repository at this point
Copy the full SHA b93ad5aView commit details -
The actual problem was with the line parsing logic for string literals. When we use backslash in the string literals, it used to remember the `\` as the previous character even after we parsed the character next to it. This leads to REPL thinking that the end of string literals is not reached. This patch replaces the previous character with `null`, so that it will properly skip the character next to it. Previous Discussion: nodejs#2952 Fixes: nodejs#2749 PR-URL: nodejs#2968 Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for cb971cc - Browse repository at this point
Copy the full SHA cb971ccView commit details -
http: remove redundant code in _deferToConnect
Logic for calling the passed in socket method and/or callback was duplicated. This commit refactors the relevant code to remove the redundancy. PR-URL: nodejs#2769 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Configuration menu - View commit details
-
Copy full SHA for f68fed2 - Browse repository at this point
Copy the full SHA f68fed2View commit details -
repl: don't use tty control codes when $TERM is set to "dumb"
This change stops the REPL from using ANSI control codes for colours when the TERM environment variable is set to "dumb". "dumb" is the terminal type with the smallest set of capabilities as described by terminfo. See: http://invisible-island.net/ncurses/terminfo.ti.html#toc-_Specials Related: nodejs/node-v0.x-archive#5344 Related: nodejs/node-v0.x-archive#25506 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> PR-URL: nodejs#2712
Configuration menu - View commit details
-
Copy full SHA for 9760e04 - Browse repository at this point
Copy the full SHA 9760e04View commit details -
doc: remove usage of events.EventEmitter
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896 PR-URL: nodejs#2921 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 43e2b7f - Browse repository at this point
Copy the full SHA 43e2b7fView commit details -
lib,src: remove usage of events.EventEmitter
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896 PR-URL: nodejs#2921 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1860e0c - Browse repository at this point
Copy the full SHA 1860e0cView commit details -
2015-09-22, Version 4.1.1 (Stable) Release
Notable changes * buffer: Fixed a bug introduced in v4.1.0 where allocating a new zero-length buffer can result in the next allocation of a TypedArray in JavaScript not being zero-filled. In certain circumstances this could result in data leakage via reuse of memory space in TypedArrays, breaking the normally safe assumption that TypedArrays should be always zero-filled. (Trevor Norris) nodejs#2931. * http: Guard against response-splitting of HTTP trailing headers added via response.addTrailers() by removing new-line ([\r\n]) characters from values. Note that standard header values are already stripped of new-line characters. The expected security impact is low because trailing headers are rarely used. (Ben Noordhuis) nodejs#2945. * npm: Upgrade to npm 2.14.4 from 2.14.3, see release notes for full details (Kat Marchán) nodejs#2958 - Upgrades graceful-fs on multiple dependencies to no longer rely on monkey-patching fs - Fix npm link for pre-release / RC builds of Node * v8: Update post-mortem metadata to allow post-mortem debugging tools to find and inspect: - JavaScript objects that use dictionary properties (Julien Gilli) nodejs#2959 - ScopeInfo and thus closures (Julien Gilli) nodejs#2974
Configuration menu - View commit details
-
Copy full SHA for ab55b45 - Browse repository at this point
Copy the full SHA ab55b45View commit details
Commits on Sep 23, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 12fa029 - Browse repository at this point
Copy the full SHA 12fa029View commit details
Commits on Sep 25, 2015
-
doc: switch LICENSE from closure-linter to eslint
Ref: nodejs#1539 PR-URL: nodejs#3018 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 52031e1 - Browse repository at this point
Copy the full SHA 52031e1View commit details -
doc: fix typos in cluster & errors
PR-URL: nodejs#3011 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for a366e84 - Browse repository at this point
Copy the full SHA a366e84View commit details -
build: fix some typos inside the configure script
PR-URL: nodejs#3016 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 8335ec7 - Browse repository at this point
Copy the full SHA 8335ec7View commit details -
doc: make execFileSync in line with execFile
PR-URL: nodejs#2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 4fc33ac - Browse repository at this point
Copy the full SHA 4fc33acView commit details -
doc: rearrange execSync and execFileSync
Changed the ordering so it is in line with the async methods. PR-URL: nodejs#2940 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 5c3f50b - Browse repository at this point
Copy the full SHA 5c3f50bView commit details -
build: iojs -> nodejs of release-urlbase
PR-URL: nodejs#3015 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 9e9bfa4 - Browse repository at this point
Copy the full SHA 9e9bfa4View commit details -
docs: Clarify assert.doesNotThrow behavior
The documentation for assert.doesNotThrow now reflects all the inputs the function accepts, as well as the errors thrown for each combination of parameter types. PR-URL: nodejs#2807 Reviewed-By: Rich Trott <rtrott@gmail.com>
1Configuration menu - View commit details
-
Copy full SHA for b28f6a5 - Browse repository at this point
Copy the full SHA b28f6a5View commit details -
doc: jenkins-iojs.nodesource.com -> ci.nodejs.org
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com to https://ci.nodejs.org. The former address now redirects to the latter. Some jobs has also changed names. PR-URL: nodejs#2886 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Configuration menu - View commit details
-
Copy full SHA for 75d5dce - Browse repository at this point
Copy the full SHA 75d5dceView commit details -
deps: backport c281c15 from V8's upstream
Backport c281c15d6dab8370a7805f0717502d260e0ad433 from V8's upstream to allow post-mortem debugging tools to inspect Buffer instances' length. Original commit message: Add JSTypedArray's length in post-mortem metadata. BUG= R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1363683002 Cr-Commit-Position: refs/heads/master@{nodejs#30873} PR: nodejs#3031 PR-URL: nodejs#3031 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5fbb248 - Browse repository at this point
Copy the full SHA 5fbb248View commit details -
deps: remove and gitignore .bin directory
The .bin/ directory in deps/npm/node_modules seens to have been an accidental check-in in commit e79ccee ("npm: upgrade to v2.1.18"). It causes trouble for distro packagers so delete it and blacklist it. Fixes: nodejs#2839 PR-URL: nodejs#3004 Reviewed-By: Kat Marchán <kzm@sykosomatic.org> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 039f73f - Browse repository at this point
Copy the full SHA 039f73fView commit details -
child_process:
null
channel handle on close`HandleWrap::OnClose` destroys the underlying C++ object and null's the internal field pointer to it. Therefore there should be no references to the wrapping JavaScript object. `null` the process' `_channel` field right after closing it, to ensure no crashes will happen. Fix: nodejs#2847 PR-URL: nodejs#3041 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 798dad2 - Browse repository at this point
Copy the full SHA 798dad2View commit details
Commits on Sep 30, 2015
-
crypto: add more keylen sanity checks in pbkdf2
issue nodejs#2987 makes the point that crypto.pbkdf2 should not fail silently and accept invalid but numeric values like NaN and Infinity. We already check if the keylen is lower than 0, so extending that to NaN and Infinity should make sense. Fixes: nodejs#2987 PR-URL: nodejs#3029 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4c8d96b - Browse repository at this point
Copy the full SHA 4c8d96bView commit details -
src: fix function and variable names in comments
The `src/node.js` file is actually loaded and executed by `node::LoadEnvironment` function. The variable which has the contents is, `native_node`. PR-URL: nodejs#3039 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Configuration menu - View commit details
-
Copy full SHA for fde0c6f - Browse repository at this point
Copy the full SHA fde0c6fView commit details -
src: include signal.h in util.h
It is required for using the "SIGABRT" constant. It doesn't cause compilation errors in Node because most files already have "signal.h" included, but it causes errors for third party embedder. PR-URL: nodejs#3058 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9a593ab - Browse repository at this point
Copy the full SHA 9a593abView commit details -
path: improve posixSplitPath performance
Instead of slicing the first element off of the matches, shift and then return. This improves performance of the following path functions: - basename: 18-20% - extname: 60-70% - dirname: 18-20% - parse: 20-25% PR-URL: nodejs#3034 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ac2bce0 - Browse repository at this point
Copy the full SHA ac2bce0View commit details -
src: internalize per-isolate string properties
Speeds up property lookups a little and it creates the string in the old space straight away. It's a little easier on the garbage collector because it doesn't have to track eternalized strings in the new space. PR-URL: nodejs#3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for c8175fc - Browse repository at this point
Copy the full SHA c8175fcView commit details -
src: internalize binding function property names
Internalized strings are created in the old space and that is where they eventually would end up anyway when created as normal strings. PR-URL: nodejs#3060 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5ec5d0a - Browse repository at this point
Copy the full SHA 5ec5d0aView commit details -
dns: add missing exports.BADNAME
Adds the documented but missing DNS error exports.BADNAME. This export has been there before but got lost in a 2012 commit that added more error codes. nodejs#3076 will remove the wrong error code exports.ADNAME. PR-URL: nodejs#3051 Fixes: nodejs#3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Configuration menu - View commit details
-
Copy full SHA for 6ee5d0f - Browse repository at this point
Copy the full SHA 6ee5d0fView commit details -
dns: remove nonexistant exports.ADNAME
This error code export was mistakingly introduced in a 2012 commit which added more error codes. The correct export.BADNAME was added in nodejs#3051. Semver: Major PR-URL: nodejs#3051 Fixes: nodejs#3050 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 55a1f94 - Browse repository at this point
Copy the full SHA 55a1f94View commit details -
test: replace deprecated util.debug() calls
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: nodejs#3082 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b97358a - Browse repository at this point
Copy the full SHA b97358aView commit details -
test: change calls to deprecated util.print()
common.print() is just util.print() and as such prints a deprecation warning. Per docs, update to console.log(). PR-URL: nodejs#3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Configuration menu - View commit details
-
Copy full SHA for 1e964bb - Browse repository at this point
Copy the full SHA 1e964bbView commit details -
Bye bye, smalloc. I'm not sure why this was still here; it was removed in 70d1f32 and hasn't worked since. It wasn't packaged in the binary, either. Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: nodejs#3099
Configuration menu - View commit details
-
Copy full SHA for 4fc8993 - Browse repository at this point
Copy the full SHA 4fc8993View commit details -
benchmark: update comment in common.js
Very minor update in benchmark/common.js Not exactly a critical change, just continued cleaning out of old joyent/node PRs that never landed. Ref: nodejs/node-v0.x-archive#8515 PR-URL: nodejs#2399 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3de58b9 - Browse repository at this point
Copy the full SHA 3de58b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6482c6 - Browse repository at this point
Copy the full SHA e6482c6View commit details