Docs: Used 3rd person singular for consistency #2765
Conversation
mscdex
added
doc
|
Looks good to me. Bonus change if you want to make it too: LGTM (There's no CLA to sign. Closest thing might be the Developer's Certificate of Origin and the Code of Conduct at the bottom of https://github.com/nodejs/node/blob/master/CONTRIBUTING.md. But there's nothing to sign.) |
|
@Trott brilliant! Thanks. Will make this additional change as suggested. Sorry for being super lazy and using the GH web editor ;-) |
|
@Trott added the additional change to the patch-1 branch |
|
LGTM |
1 similar comment
|
LGTM |
| @@ -132,7 +132,7 @@ Returns a copy of the array of listeners for the specified event. | |||
|
|
|||
| ### emitter.emit(event[, arg1][, arg2][, ...]) | |||
|
|
|||
| Execute each of the listeners in order with the supplied arguments. | |||
| Executes each of the listeners in order with the supplied arguments. | |||
There was a problem hiding this comment.
While you're at it ... Calls?
|
@Trott @targos @nodejs/documentation Do you prefer |
|
I don't have any preference on this one |
|
No preference. Maybe someone on @nodejs/documentation has a preference on |
PR-URL: #2765 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in d2f70fe If anyone feels strongly about |
PR-URL: #2765 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #2765 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
remove -> removes
Also, I don't know whether you have a CLA I should sign?