Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: output of completions when column is undefined #2396

Closed
jasnell opened this issue Aug 16, 2015 · 3 comments
Closed

readline: output of completions when column is undefined #2396

jasnell opened this issue Aug 16, 2015 · 3 comments
Labels
good first issue Issues that are suitable for first-time contributors. readline Issues and PRs related to the built-in readline module.

Comments

@jasnell
Copy link
Member

jasnell commented Aug 16, 2015

Per: nodejs/node-v0.x-archive#9001

@ackalker originally reported the issue and @TooTallNate reviewed. Unfortunately
it appears to have stalled. There were a number of issues in the PR that were never
resolved. That said, the issue is still present in master. To reproduce:

bash-3.2$ ./iojs
> process.stdout.columns = undefined;
undefined
> process.std<TAB>

>

(note the blank line after pressing the TAB)
@mscdex mscdex added the readline Issues and PRs related to the built-in readline module. label Aug 16, 2015
@Fishrock123 Fishrock123 added the good first issue Issues that are suitable for first-time contributors. label Aug 25, 2015
@mtharrison mtharrison mentioned this issue Aug 29, 2015
Closed
@tyleranton
Copy link
Contributor

I've only ever contributed to doc changes, but I'd like to get into the code. What are the issues with the PR?

@mtharrison mtharrison mentioned this issue Sep 11, 2015
Closed
silverwind pushed a commit that referenced this issue Sep 18, 2015
@mtharrison @silverwind
readline: fix tab completion bug
e29e470 
This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.

PR-URL: #2816
Fixes: #2396
Reviewed-By: Roman Reiss <me@silverwind.io>
@silverwind
Copy link
Contributor

Fixed by e29e470.

@tyleranton Looks like I missed your comment, sorry. This issue already had an pending PR, so would have been a bad candidate. I'll try to flag more issues for contributions in the future.

@tyleranton
Copy link
Contributor

No problem, thanks!

Fishrock123 pushed a commit that referenced this issue Sep 20, 2015
@mtharrison @Fishrock123
readline: fix tab completion bug
d4cd5ac 
This fixes a problem where tab completion is empty when the input
stream column size is undefined. As a solution we can force maxColumns
to 1 in this scenario.

PR-URL: #2816
Fixes: #2396
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues that are suitable for first-time contributors. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

readline: fix tab completion bug mtharrison/node
5 participants
@mscdex @silverwind @jasnell @Fishrock123 @tyleranton