Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to npm 2.14.3 #2822

Closed
wants to merge 2 commits into from
Closed

deps: upgrade to npm 2.14.3 #2822

wants to merge 2 commits into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Sep 11, 2015

Yay! New npm for node 4 :)

There's not much in this release that would affect node except a patch to our test suite to make the released version of npm pass its tests (which is what stopped the release 2 weeks ago from getting upstreamed).

Additionally, I've manually included an upgrade so we use node-gyp@3.0.3, which isn't officially part of this release but will be included in next week's (and is currently in npm@next).

See our release notes at https://github.com/npm/npm/releases/tag/v2.14.3

r: @Fishrock123
r: @chrisdickinson

@zkat zkat mentioned this pull request Sep 11, 2015
@mscdex mscdex added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 11, 2015
@rvagg
Copy link
Member

rvagg commented Sep 11, 2015

Please hold off on merging this one in, there'll be a node-gyp@3.0.2 shortly to fix a bug that should go in here. I'll update here when that's done.

@rvagg
Copy link
Member

rvagg commented Sep 12, 2015

node-gyp@3.0.2 is published, @zkat if you're around could you update your PR to replace the second commit with 3.0.2 please? otherwise if someone else is going to land this, just do @zkat's first commit then make a second with cd deps/npm && npm i node-gyp@latest -S for the same effect (and remember to PR-URL it..)

@Fishrock123
Copy link
Contributor

This has got to be the easiest npm pr to review ever. LGTM with node-gyp@3.0.2

@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
7 tasks
No more cherry-picked io patches. hooray.
@zkat
Copy link
Contributor Author

zkat commented Sep 14, 2015

node-gyp updated to 3.0.3. :)

@jasnell
Copy link
Member

jasnell commented Sep 14, 2015

LGTM so long as the bundled npm tests all pass :-)

@Fishrock123
Copy link
Contributor

I'll look at this soon.

Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
No more cherry-picked io patches. hooray.

PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Landed in 1f842c2...3351305 -- thanks!

Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 15, 2015
No more cherry-picked io patches. hooray.

PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Sep 15, 2015
PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Sep 15, 2015
No more cherry-picked io patches. hooray.

PR-URL: #2822
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@rvagg rvagg mentioned this pull request Sep 15, 2015
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 17, 2015
Notable changes:

* buffer:
  - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) nodejs#2866.
  - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) nodejs#2777.
* fs:
  - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) nodejs#2387.
  - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) nodejs#2167.
* http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) nodejs#2824.
* npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) nodejs#2822.
* src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) nodejs#2324.
* v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) nodejs#2870.
  - This fixes a previously known bug where some computed object shorthand properties did not work correctly (nodejs#2507).

Refs: nodejs#2844
PR-URL: nodejs#2889
Fishrock123 added a commit that referenced this pull request Sep 17, 2015
Notable changes:

* buffer:
  - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) #2866.
  - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) #2777.
* fs:
  - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) #2387.
  - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) #2167.
* http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) #2824.
* npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) #2822.
* src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) #2324.
* v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) #2870.
  - This fixes a previously known bug where some computed object shorthand properties did not work correctly (#2507).

Refs: #2844
PR-URL: #2889
@rvagg rvagg mentioned this pull request Sep 22, 2015
@MylesBorins
Copy link
Contributor

landed in lts-v4.x staging as 816f609...2600fb8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants