node: rename from io.js to node #2884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM Maybe we should also change to ```bash in the process? Would be more correct. |
Contributor
|
(also, better commit message: "doc: rename from io.js to node in benchmarks", or the like.) |
benchmark exec examples
Contributor
Author
|
Fixup! |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
Examples in the benchmark readme previously sill referenced iojs(1). PR-URL: #2884 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
|
Thanks, landed in 942da88 with commit log clarity edits. :) |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 15, 2015
Examples in the benchmark readme previously sill referenced iojs(1). PR-URL: #2884 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark exec examples