Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtc height #970

Merged
merged 7 commits into from
Jun 8, 2018
Merged

Fix rtc height #970

merged 7 commits into from
Jun 8, 2018

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented Jun 8, 2018

Fixes the build error (I hope) - #962 requires meta.json entries to include "height", but the PR for adding an examples for <rtc> snuck in before that was merged.

This PR adds "height" for the <rtc> example.

Will Bamberg added 7 commits May 2, 2018 20:40
* upstream/master:
  fix: run tests on different port than dev server (mdn#871)
  Add <var> example (mdn#872)
  Add <dd> example (mdn#839)
  Add <ins> example (mdn#847)
  chore: add @sheeeng as contributor (mdn#869)
  test: add sanity pupeteer tests for tabbed editor (mdn#717)
  Adds sanity puppeteer test for CSS editor (mdn#716)
* upstream/master:
  Add interactive example for <section> (mdn#888)
  Add embed example. (mdn#863)
  Add <span> example (mdn#882)
  chore: add @tbazin as contributor (mdn#889)
  Improve naming of unbound function example (mdn#886)
  Add html input number (mdn#866)
  Add html input range (mdn#878)
  chore(deps): update dependency jest-puppeteer to v3 (mdn#879)
  Add input-image example (mdn#864)
  Add html input radio (mdn#868)
  Add iframe example. (mdn#875)
  fix: change output for tabbed editor to shadow dom (mdn#873)
  Remove unused CSS
  Add input-month example
* upstream/master:
  Add source example. (mdn#885)
  Add object and param examples. (mdn#876)
  Add <li> example (mdn#896)
  small js change (mdn#894)
  Add <ul> example (mdn#895)
  Add <wbr> example (mdn#874)
  Add html input password (mdn#867)
  Replace <br> with <div> in input examples (mdn#877)
  chore(deps): update dependency npm-run-all to v4.1.3 (mdn#893)
  Add <hr> example (mdn#883)
  Add <p> example (mdn#884)
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
* upstream/master:
  adding oblique plus angle option to font-style example (mdn#963)
  fix(tabbed-editor): Apply output class to output container (mdn#961)
  Add rt example. (mdn#957)
  chore(deps): update dependency prettier to v1.13.4 (mdn#953)
  chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954)
  chore(deps): update dependency jest to v23.1.0 (mdn#955)
  Fix console util to support negative zero (mdn#960)
  Add rp example. (mdn#945)
  Bug 1462897 - Directly use Math.round in the demo code. (mdn#956)
  chore(docs): update README with maintainers and good first issues (mdn#934)
  Implemented example for <figcaption> tag (mdn#941)
  Font variation settings (mdn#948)
  Fix font optical sizing (mdn#947)
  chore(deps): update dependency jest to v23 (mdn#944)
  chore(deps): update dependency prettier to v1.13.0 (mdn#950)
  chore(community): add @elharony as contributor (mdn#951)
  Add object-keys.html (mdn#937)
* upstream/master:
  Issue#693 add sizing util classes tabbed editor (mdn#962)
  Add rtc example. (mdn#958)
  Issue#837 html entity workaround (mdn#965)
@wbamberg wbamberg merged commit ee243f5 into mdn:master Jun 8, 2018
wbamberg pushed a commit to sheeeng/interactive-examples that referenced this pull request Jun 8, 2018
* upstream/master:
  Add one-value example for place-content (mdn#966)
  Add height to rtc example (mdn#970)
  Issue#693 add sizing util classes tabbed editor (mdn#962)
  Add rtc example. (mdn#958)
  Issue#837 html entity workaround (mdn#965)
  adding oblique plus angle option to font-style example (mdn#963)
  fix(tabbed-editor): Apply output class to output container (mdn#961)
  Add rt example. (mdn#957)
  chore(deps): update dependency prettier to v1.13.4 (mdn#953)
  chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954)
  chore(deps): update dependency jest to v23.1.0 (mdn#955)
  Fix console util to support negative zero (mdn#960)
wbamberg pushed a commit to a2sheppy/interactive-examples that referenced this pull request Jun 16, 2018
* upstream/master: (55 commits)
  Issue#223 small tweaks to tabbed editor heights (mdn#972)
  fix(editor): change height of tabbed-taller (mdn#971)
  fix(performance): send loadEventEnd to parent via postMessage (mdn#967)
  chore(deps): update dependency all-contributors-cli to v5 (mdn#969)
  chore(deps): update dependency prettier to v1.13.5 (mdn#968)
  chore(deps): update dependency puppeteer to v1.5.0 (mdn#964)
  Add ruby example. (mdn#959)
  Add one-value example for place-content (mdn#966)
  Add height to rtc example (mdn#970)
  Issue#693 add sizing util classes tabbed editor (mdn#962)
  Add rtc example. (mdn#958)
  Issue#837 html entity workaround (mdn#965)
  adding oblique plus angle option to font-style example (mdn#963)
  fix(tabbed-editor): Apply output class to output container (mdn#961)
  Add rt example. (mdn#957)
  chore(deps): update dependency prettier to v1.13.4 (mdn#953)
  chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954)
  chore(deps): update dependency jest to v23.1.0 (mdn#955)
  Fix console util to support negative zero (mdn#960)
  Add rp example. (mdn#945)
  ...
wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request Jun 19, 2018
* upstream/master:
  chore(deps): update dependency stylelint to v9.3.0 (mdn#973)
  chore(deps): update dependency jest-puppeteer to v3.1.0 (mdn#974)
  Issue#223 small tweaks to tabbed editor heights (mdn#972)
  fix(editor): change height of tabbed-taller (mdn#971)
  fix(performance): send loadEventEnd to parent via postMessage (mdn#967)
  chore(deps): update dependency all-contributors-cli to v5 (mdn#969)
  chore(deps): update dependency prettier to v1.13.5 (mdn#968)
  chore(deps): update dependency puppeteer to v1.5.0 (mdn#964)
  Add ruby example. (mdn#959)
  Add one-value example for place-content (mdn#966)
  Add height to rtc example (mdn#970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant