Fix console util to support negative zero #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schalkneethling
added
bug
|
👍 |
wbamberg
pushed a commit
to wbamberg/interactive-examples
that referenced
this pull request
Jun 8, 2018
* upstream/master: adding oblique plus angle option to font-style example (mdn#963) fix(tabbed-editor): Apply output class to output container (mdn#961) Add rt example. (mdn#957) chore(deps): update dependency prettier to v1.13.4 (mdn#953) chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954) chore(deps): update dependency jest to v23.1.0 (mdn#955) Fix console util to support negative zero (mdn#960) Add rp example. (mdn#945) Bug 1462897 - Directly use Math.round in the demo code. (mdn#956) chore(docs): update README with maintainers and good first issues (mdn#934) Implemented example for <figcaption> tag (mdn#941) Font variation settings (mdn#948) Fix font optical sizing (mdn#947) chore(deps): update dependency jest to v23 (mdn#944) chore(deps): update dependency prettier to v1.13.0 (mdn#950) chore(community): add @elharony as contributor (mdn#951) Add object-keys.html (mdn#937)
wbamberg
pushed a commit
to sheeeng/interactive-examples
that referenced
this pull request
Jun 8, 2018
* upstream/master: Add one-value example for place-content (mdn#966) Add height to rtc example (mdn#970) Issue#693 add sizing util classes tabbed editor (mdn#962) Add rtc example. (mdn#958) Issue#837 html entity workaround (mdn#965) adding oblique plus angle option to font-style example (mdn#963) fix(tabbed-editor): Apply output class to output container (mdn#961) Add rt example. (mdn#957) chore(deps): update dependency prettier to v1.13.4 (mdn#953) chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954) chore(deps): update dependency jest to v23.1.0 (mdn#955) Fix console util to support negative zero (mdn#960)
wbamberg
pushed a commit
to a2sheppy/interactive-examples
that referenced
this pull request
Jun 16, 2018
* upstream/master: (55 commits) Issue#223 small tweaks to tabbed editor heights (mdn#972) fix(editor): change height of tabbed-taller (mdn#971) fix(performance): send loadEventEnd to parent via postMessage (mdn#967) chore(deps): update dependency all-contributors-cli to v5 (mdn#969) chore(deps): update dependency prettier to v1.13.5 (mdn#968) chore(deps): update dependency puppeteer to v1.5.0 (mdn#964) Add ruby example. (mdn#959) Add one-value example for place-content (mdn#966) Add height to rtc example (mdn#970) Issue#693 add sizing util classes tabbed editor (mdn#962) Add rtc example. (mdn#958) Issue#837 html entity workaround (mdn#965) adding oblique plus angle option to font-style example (mdn#963) fix(tabbed-editor): Apply output class to output container (mdn#961) Add rt example. (mdn#957) chore(deps): update dependency prettier to v1.13.4 (mdn#953) chore(deps): update dependency all-contributors-cli to v4.11.2 (mdn#954) chore(deps): update dependency jest to v23.1.0 (mdn#955) Fix console util to support negative zero (mdn#960) Add rp example. (mdn#945) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #952
The bug is caused by using
String(value)function, which per the spec callsToString(value). ToString(value) for number as per defined at the spec states thatSo, this PR adds the case where if we meet negative zero at
formatOutput, then return-0, else callString(input). Also, more tests are added.