-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add object and param examples. #876
Conversation
Thanks again for an excellent contribution! I'd love to have an example for |
This is difficult — our options are quite limited here, as our stance is quite firmly anti-plugin. We don't want to be seen to be advocating Flash usage, and my article on the subject explains this fairly clearly: How about a PDF, as seen in this example? You wouldn't do this very often, but I see this as less politically difficult than using Flash. |
PDF example works for <object type="application/pdf"
data="/media/examples/pdf_open_parameters.pdf"
width="300"
height="200">
<param name="page" value="5">
<param name="scrollbar" value="1">
</object>
<footer><a href="https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/pdf_open_parameters.pdf">PDF</a> by Adobe</footer> The Flash example works with both |
What is the recommended way to resolve merge conflicts? Manually fix it here? |
Yes, that's how I have been doing it. It's usually only meta.json that's conflicted, and the fix is quite simple. You are welcome to fix merge conflicts yourself, otherwise when the PR is ready to merge I will resolve them :-). |
Yes, I think we don't want to use Flash. Apart from anything else, the example will not work well in many cases - some people (myself included :) disable Flash, and problems with this example are only going to increase as Flash is gradually EOL'd. So I suggest we do the simple thing:
@sheeeng , does that sound like a good plan to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sheeeng , this looks great. Thanks again for contributing these examples, it is a big help.
* upstream/master: Add source example. (mdn#885) Add object and param examples. (mdn#876) Add <li> example (mdn#896) small js change (mdn#894) Add <ul> example (mdn#895) Add <wbr> example (mdn#874) Add html input password (mdn#867) Replace <br> with <div> in input examples (mdn#877) chore(deps): update dependency npm-run-all to v4.1.3 (mdn#893) Add <hr> example (mdn#883) Add <p> example (mdn#884)
Fix #741.
Fix #742.