Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object and param examples. #876

Merged
merged 4 commits into from
May 7, 2018

Conversation

sheeeng
Copy link

@sheeeng sheeeng commented May 2, 2018

Fix #741.
Fix #742.

@wbamberg
Copy link
Contributor

wbamberg commented May 3, 2018

Thanks again for an excellent contribution! I'd love to have an example for <object> that doesn't use Flash, but I wasn't sure what would be good. @chrisdavidmills , any ideas?

@schalkneethling schalkneethling added p1 We will address this soon and will provide capacity from our team for it in the next few releases. in sprint labels May 3, 2018
@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone May 3, 2018
@chrisdavidmills
Copy link
Contributor

This is difficult — our options are quite limited here, as our stance is quite firmly anti-plugin. We don't want to be seen to be advocating Flash usage, and my article on the subject explains this fairly clearly:

https://developer.mozilla.org/en-US/docs/Learn/HTML/Multimedia_and_embedding/Other_embedding_technologies

How about a PDF, as seen in this example?

https://mdn.github.io/learning-area/html/multimedia-and-embedding/other-embedding-technologies/object-pdf.html

You wouldn't do this very often, but I see this as less politically difficult than using Flash.

@sheeeng
Copy link
Author

sheeeng commented May 3, 2018

PDF example works for <object>. But, none of the <param> works for PDF using below code.

<object type="application/pdf"
    data="/media/examples/pdf_open_parameters.pdf"
    width="300"
    height="200">
    <param name="page" value="5">
    <param name="scrollbar" value="1">
</object>

<footer><a href="https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/pdf_open_parameters.pdf">PDF</a> by Adobe</footer>

The Flash example works with both <object> and <param> elements.

@sheeeng
Copy link
Author

sheeeng commented May 3, 2018

What is the recommended way to resolve merge conflicts? Manually fix it here?

@wbamberg
Copy link
Contributor

wbamberg commented May 3, 2018

What is the recommended way to resolve merge conflicts? Manually fix it here?

Yes, that's how I have been doing it. It's usually only meta.json that's conflicted, and the fix is quite simple. You are welcome to fix merge conflicts yourself, otherwise when the PR is ready to merge I will resolve them :-).

@wbamberg
Copy link
Contributor

wbamberg commented May 4, 2018

Yes, I think we don't want to use Flash. Apart from anything else, the example will not work well in many cases - some people (myself included :) disable Flash, and problems with this example are only going to increase as Flash is gradually EOL'd.

So I suggest we do the simple thing:

  • go with your PDF suggestion here for <object>
  • omit an example for <param>

@sheeeng , does that sound like a good plan to you?

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheeeng , this looks great. Thanks again for contributing these examples, it is a big help.

@wbamberg wbamberg merged commit 08d98e6 into mdn:master May 7, 2018
wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request May 7, 2018
* upstream/master:
  Add source example. (mdn#885)
  Add object and param examples. (mdn#876)
  Add <li> example (mdn#896)
  small js change (mdn#894)
  Add <ul> example (mdn#895)
  Add <wbr> example (mdn#874)
  Add html input password (mdn#867)
  Replace <br> with <div> in input examples (mdn#877)
  chore(deps): update dependency npm-run-all to v4.1.3 (mdn#893)
  Add <hr> example (mdn#883)
  Add <p> example (mdn#884)
@sheeeng sheeeng deleted the add-object-and-param-examples branch May 14, 2018 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants