-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <area> example #920
Add <area> example #920
Conversation
This is really cool! Nice job :) I think you do need I take your point about horizontal space though. What I do is use hard line breaks to make sure that the markup will be readable when the browser window is 1000px (preferably less, more like 900px). I've done this a lot with the Then you get the other problem of course, which is lots of lines in the example. In this case I would probably suggest having fewer hotspots in the image. For example you could have just three - HTML, CSS, JS. Or maybe four, and you could put MDN in the middle, then you could demo What do you think about having the links go somewhere, using something like:
|
@wbamberg I agree about the links going to real articles in MDN, that's what I thought in the beginning but the lines were too long and I went for dummy links instead. Now that you suggest about using hard coded break lines, I'll apply then all what you said. And about changing the figure for one with less I'm thinking about using this kind of figure instead (see drawing attached please). If you find it suitable to use, I have two questions:
|
And because the example is for |
Actually, thinking some more about this, I think you can keep the image and the example won't be too long. Let's say you split each
...then I think the example would be about 25 lines long, which is fine. One thing I missed before: even when you don't need it we are preferring to use
not:
|
Done! |
eek! I wondered what had happened to it! :-) |
sorry!! I was trying to push delete another branch from terminal, and I mistakenly deleted this one 😅, but I think all is back to normal now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really nice example. Thanks for taking the time on it :).
thank to you for reviewing it and all the corrections you pointed out :) |
* upstream/master: (39 commits) Add video example. (mdn#939) Add track example. (mdn#940) Change `html` to `tabbed` in Publishing section (mdn#942) adding font-optical-sizing example (mdn#919) chore(deps): update dependency jest to v22.4.4 (mdn#935) fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927) Add img example. (mdn#923) Add <area> example (mdn#920) Add <map> example (mdn#931) Add HTML example for <audio> (mdn#930) chore(community): add @Regaddi as contributor (mdn#933) chore(community): add @stephanmax as contributor (mdn#932) Add HTML example for <summary> (mdn#926) Add HTML example for <details> (mdn#924) Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929) Add String trim examples (mdn#922) chore(deps): update dependency stylelint to v9.2.1 (mdn#928) Add example for week input (mdn#902) Add url input example (mdn#901) Add html input search (mdn#897) ...
Fixes #758
This one, was full of fun 😁.
Because of the length taken by the coordinates of a polygon area, I decided to not put an
alt
property in the anchors (but I did in the image). If I need to specify that anyway, I could writealt="go to ..."
and it will take at least 16 more characters of horizontal space, please let me know.The whole graphic, was made from scratch by me in inkscape (I only took the dinosaur head from an external source), so there won't be any kind of copyright problem 😉.