Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html input search #897

Merged
merged 6 commits into from
May 16, 2018
Merged

Conversation

wbamberg
Copy link
Contributor

@wbamberg wbamberg commented May 7, 2018

Will Bamberg added 4 commits May 2, 2018 20:40
* upstream/master:
  fix: run tests on different port than dev server (mdn#871)
  Add <var> example (mdn#872)
  Add <dd> example (mdn#839)
  Add <ins> example (mdn#847)
  chore: add @sheeeng as contributor (mdn#869)
  test: add sanity pupeteer tests for tabbed editor (mdn#717)
  Adds sanity puppeteer test for CSS editor (mdn#716)
* upstream/master:
  Add interactive example for <section> (mdn#888)
  Add embed example. (mdn#863)
  Add <span> example (mdn#882)
  chore: add @tbazin as contributor (mdn#889)
  Improve naming of unbound function example (mdn#886)
  Add html input number (mdn#866)
  Add html input range (mdn#878)
  chore(deps): update dependency jest-puppeteer to v3 (mdn#879)
  Add input-image example (mdn#864)
  Add html input radio (mdn#868)
  Add iframe example. (mdn#875)
  fix: change output for tabbed editor to shadow dom (mdn#873)
  Remove unused CSS
  Add input-month example
* upstream/master:
  Add source example. (mdn#885)
  Add object and param examples. (mdn#876)
  Add <li> example (mdn#896)
  small js change (mdn#894)
  Add <ul> example (mdn#895)
  Add <wbr> example (mdn#874)
  Add html input password (mdn#867)
  Replace <br> with <div> in input examples (mdn#877)
  chore(deps): update dependency npm-run-all to v4.1.3 (mdn#893)
  Add <hr> example (mdn#883)
  Add <p> example (mdn#884)
@schalkneethling schalkneethling self-assigned this May 9, 2018
@schalkneethling schalkneethling added the p1 We will address this soon and will provide capacity from our team for it in the next few releases. label May 9, 2018
@schalkneethling schalkneethling added this to the Quarter 2 ~ Sprint 2 milestone May 9, 2018
Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, one suggestion, and a conflict. r+w/c

@schalkneethling
Copy link

The search field and buttons seems a bit small to me.

screen shot 2018-05-09 at 11 27 09

Perhaps add font-size: 1.2rem;

screen shot 2018-05-09 at 11 29 21

@wbamberg
Copy link
Contributor Author

wbamberg commented May 9, 2018

Good call @schalkneethling , I've made that change. This wasn't the most exciting example, I guess I'm low on inspiration at the moment :).

Copy link

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@schalkneethling schalkneethling merged commit 59190c6 into mdn:master May 16, 2018
wbamberg pushed a commit to wbamberg/interactive-examples that referenced this pull request May 25, 2018
* upstream/master: (39 commits)
  Add video example. (mdn#939)
  Add track example. (mdn#940)
  Change `html` to `tabbed` in Publishing section (mdn#942)
  adding font-optical-sizing example (mdn#919)
  chore(deps): update dependency jest to v22.4.4 (mdn#935)
  fix(tabbed-editor): issue mdn#860, isolate CSS to output (mdn#927)
  Add img example. (mdn#923)
  Add <area> example (mdn#920)
  Add <map> example (mdn#931)
  Add HTML example for <audio> (mdn#930)
  chore(community): add @Regaddi as contributor (mdn#933)
  chore(community): add @stephanmax as contributor (mdn#932)
  Add HTML example for <summary> (mdn#926)
  Add HTML example for <details> (mdn#924)
  Fix example: issue mdn#925, add (max-)width to container and left-align text to see full effect (mdn#929)
  Add String trim examples (mdn#922)
  chore(deps): update dependency stylelint to v9.2.1 (mdn#928)
  Add example for week input (mdn#902)
  Add url input example (mdn#901)
  Add html input search (mdn#897)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants