Closed
Description
I created this task to provide a list of PRs that should be re-triaged from the developer experience point of view, and probably we should raise the priority of them.
Here is a list of PRs that I'd like to discuss, groped by the decision that was done:
Increased priority to high (p1 or p2):
- Avoid binding magnifier events in duplicate on resize #30695 - improves performance on the frontend
- Removed code redundancy for module frontend layouts. #30644 - removes setting not needed page layout. It's not so easy to change it if you would like to use a different layout
- Catch php syntax errors (or other errors) in bin/magento and output the error instead of staying silent #32145 - PHP syntax errors not catch
- Fix issue #24635: Use of undefined constant GLOB_BRACE in dependency … #31296 - fixes an issue when running Magento on PHP in docker using Alpine Linux
- Move assign category ids to beforeToHtml instead inside load collection #32390 - improves backward compatibility that we recently broke, and no alternative provided from an extensibility point of view
- Seperate js out template to avoid render issue #32434 - fixes PHP ParseError in admin when HTML minification enabled
- Item resolvers should be optional #30823 - fixes object creation when configurable and grouped product modules are disabled (for instance, in case if shop contains only simple products, it might be disabled due to performance reasons)
- Add event listeners passive for fotorama lib improves lighthouse metrics #31080 - improves lighthouse / google page speed metric, got stuck for 3 months already in "Accept" column
- Update Api functional test install-config-mysql file template #30995 - fixes missing mandatory params for running tests
- Incorrect Annotation for
Magento\Framework\App\CacheInterface::load#31987 - fixes incorrect return type (missing bool type) that was confusing from the developer perspective when working with the cache. SVC should be approved
Fixed in a different PR:
- Allow higher versions of phpstan to be installed (Magento 2.4 edition) #31972 - allow updating phpstan to newer versions. New versions contain bug fixes and false positives
Decided to be rejected:
- Reuse password reset tokens until they expire #25280 - significantly improves customer experience when some forgot password email got delayed
Still requires discussion:
- Magento fails on captcha even it not used #30991 - absolutely not an expected issue, failing during object creation. It reproduces mainly on Docker-based installations, as quite often PHP extensions are build from sources there
- Fixed use inconsistently viewModels in codebase #31503 - fixes inconsistency between different pieces in Magento. Such inconsistency causing harder understanding how it should be
- Add variable font size for input display on iOS #32253 - improves customer experience on iPhone. Mobile is really a major part of traffic right now
- Refactor: Swatches Helper / Remove misleading aliases, refactor the class #31355 - improves maintainability. Fixes confusing aliases for classes/interfaces