Catch php syntax errors (or other errors) in bin/magento and output the error instead of staying silent

[hostep]

Description (*)

When a PHP error occurs somewhere in code that is executed by bin/magento it should output that error instead of staying silent

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

I'll update these steps with more concrete things, not much time at the moment to put a lot more info here, will try this weekend if I find more time

1. Have a module installed in app/code which uses PHP 7.4 specific syntax which doesn't work on PHP 7.3
2. Run bin/magento using PHP 7.3

Expected

1. Exit code other then 0
2. Explanation of the error

Actual

1. Exit code other then 0 => correct!
2. Just silence, nothing else, this makes it extremely confusing why the command doesn't seem to do anything

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Catch php syntax errors (or other errors) in bin/magento and output the error instead of staying silent #32786: Catch php syntax errors (or other errors) in bin/magento and output the error instead of staying silent

[m2-assistant]

Hi @hostep. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[hostep]

@magento run all tests

[hostep]

It's a bit hard to find propper steps to reproduce, because on my local errors are seen but on the server where we ran into this, there was just no output. Probably related to display_error and some other php.ini settings ...

Update: production mode can probably cause differences as well, didn't test though ...

[ihor-sviziev]

@magento run Functional Tests EE

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8783 has been created to process this Pull Request

[engcom-Oscar]

@magento create issue

[m2-assistant]

Hi @hostep, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.